From: Chao Gao <chao.gao@intel.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: <kvm@vger.kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>,
<robert.hu@linux.intel.com>
Subject: Re: [PATCH v5 4/4] x86: Add test case for INVVPID with LAM
Date: Tue, 6 Jun 2023 15:02:51 +0800 [thread overview]
Message-ID: <ZH7aGywSih+TcFyu@chao-email> (raw)
In-Reply-To: <fa4a405f-0ee6-c6de-7947-e56c4ee22734@linux.intel.com>
On Tue, Jun 06, 2023 at 01:47:07PM +0800, Binbin Wu wrote:
>> > + try_invvpid(INVVPID_ADDR, 0xffff, NONCANONICAL);
>> shouldn't we use a kernel address here? e.g., vaddr. otherwise, we
>> cannot tell if there is an error in KVM's emulation because in this
>> test, LAM is enabled only for kernel address while INVVPID_ADDR is a
>> userspace address.
>
>INVVPID_ADDR is the invalidation type, not the address.
>The address used here is NONCANONICAL, which is 0xaaaaaaaaaaaaaaaaull and
>is considered as kernel address.
Yes. Sorry about this misunderstanding.
Do you need the address to be canonical after masking metadata?
next prev parent reply other threads:[~2023-06-06 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 2:43 [PATCH v5 0/4] x86: Add test cases for LAM Binbin Wu
2023-05-30 2:43 ` [PATCH v5 1/4] x86: Allow setting of CR3 LAM bits if LAM supported Binbin Wu
2023-05-30 2:43 ` [PATCH v5 2/4] x86: Add test case for LAM_SUP Binbin Wu
2023-05-30 2:43 ` [PATCH v5 3/4] x86: Add test cases for LAM_{U48,U57} Binbin Wu
2023-05-30 2:43 ` [PATCH v5 4/4] x86: Add test case for INVVPID with LAM Binbin Wu
2023-06-05 13:22 ` Chao Gao
2023-06-06 5:47 ` Binbin Wu
2023-06-06 7:02 ` Chao Gao [this message]
2023-06-06 7:08 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH7aGywSih+TcFyu@chao-email \
--to=chao.gao@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=robert.hu@linux.intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.