From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46EA537B71 for ; Tue, 6 Jun 2023 13:59:10 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-56942442eb0so90498937b3.1 for ; Tue, 06 Jun 2023 06:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686059949; x=1688651949; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gn/dFH22odtX6QmxBFqPjy05b5sFU03Muxh5Wl7MUWY=; b=TWSahW0vclogrCSwDkxLN7KbfBui2xZPFmRmleHMQtHFfaCSNrPPzfDjDqHXfb6jlC fGl1bvZdtJcTcY6w1eZ64W2sAMLQ1lsW8DXHUQatb3MzPz3fsz06PWlOa6FQXJoGZOYA D9Y49O2nk9w4ZqIYXDWbCv8nCwuENtkoOLDtWGMJbWbkFCZv8h/rW+tgIiX6dk+ZzBr6 TDSdTYmuEVMTm1g2U8mUkCG8KJkliOEIsTB2IULTwYnETUGgH8imNWo0bUMVY1FmRCKN 2UhxoTpquppB32KtCK0gxsdMntNHVQL7Q/9wSyEeqDJ2Tv8JnPZ1a5E97/VEfkG+OZf0 +JTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686059949; x=1688651949; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gn/dFH22odtX6QmxBFqPjy05b5sFU03Muxh5Wl7MUWY=; b=GS5XSNb03Dk7nxo5X71XIjkEkvjyy7cp9SS7hZe8jmWvc8a3a9SlrWLM4asxrpipQJ i6Qc5aNTQbqRwqQptahiyB4GsSF+dJ0Dn+JigG7nZ01ize6Ia9Fl0R6PBewPKPSyi0ac 3op+TJNdI6eqV0MncJobUDcUrf5TqqQf5x2g/hw1Pl8aIbUmD+Qjwo4c8iHqqitE7OmJ Khexri9uDNn1vZydwHrckmOk5nel6gY8E5AtCAS/bhdE7Xk6meHM/PXbFWMAzpD/acxu wBXB1onVowv5PPyw66/gy2Ehgvw5MEmIO6fOcrmsSMQ3QDq+ID3IXRGnEpNf1ae0uQR5 +DEg== X-Gm-Message-State: AC+VfDyfJ9EsXAVhiqY7ufuhM69RTP7cfNjK1SlI3efR28n8SHzgAiYR INNJXbNxbdiVIclmxkTqQmHprYuJBqY= X-Google-Smtp-Source: ACHHUZ6/D/quV4fAtDjo6gBujt5UE2X+Hx20Ph0wcv5OeWnrjKAnqhhJ2HIJEjaFM6gSsFSJeQer8lrw+gI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:b1c4:0:b0:565:a43e:23c7 with SMTP id p187-20020a81b1c4000000b00565a43e23c7mr1077489ywh.0.1686059949165; Tue, 06 Jun 2023 06:59:09 -0700 (PDT) Date: Tue, 6 Jun 2023 06:59:07 -0700 In-Reply-To: <2f16f83e-ed60-fcb7-7f3d-0fa216c41cb9@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <2f16f83e-ed60-fcb7-7f3d-0fa216c41cb9@redhat.com> Message-ID: Subject: Re: [PATCH] KVM: arm64: Fix smp_processor_id() call in preemptible context From: Sean Christopherson To: Sebastian Ott Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Oliver Upton Content-Type: text/plain; charset="us-ascii" On Tue, Jun 06, 2023, Sebastian Ott wrote: > Fixes: 1c913a1c35aa ("KVM: arm64: Iterate arm_pmus list to probe for default PMU") > Signed-off-by: Sebastian Ott > --- > arch/arm64/kvm/pmu-emul.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c > index 491ca7eb2a4c..f9e4e4334875 100644 > --- a/arch/arm64/kvm/pmu-emul.c > +++ b/arch/arm64/kvm/pmu-emul.c > @@ -700,6 +700,7 @@ static struct arm_pmu *kvm_pmu_probe_armpmu(void) > > mutex_lock(&arm_pmus_lock); > > + preempt_disable(); get_cpu() + put_cpu() would be more succinct and self-documenting. > cpu = smp_processor_id(); > list_for_each_entry(entry, &arm_pmus, entry) { > tmp = entry->arm_pmu; > @@ -709,7 +710,7 @@ static struct arm_pmu *kvm_pmu_probe_armpmu(void) > break; > } > } > - > + preempt_enable(); > mutex_unlock(&arm_pmus_lock); > > return pmu; > -- > 2.40.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E172C7EE24 for ; Tue, 6 Jun 2023 13:59:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Jv7mh7yIyRbSa1/pbL4DypjL3LbtqKZPsIpI9vtE+1M=; b=xLT6Yng7KKsxwpt2Zbo+1DjG4x m8fw+0E0X9UtQWnHK9Z1pLz0qZpWyuyM23oLJBUb+z2hMm2P5Ma64pnXRYsvlrK4SjZYNXZRgnSMU zMMK/DB1+lZbw5CxXNeI7NCpbtNhNzbsSgQG01fNanf8yv0K82i9vxycdY11DGtwctm33er24FzIW VCefT6HAkBtYhkYptvZ51Uu4n6ZyOKQCXC/YiLwVz6qCJep7rThLOSkLQA6d2JIWpJiBmvgFZiXOk PLdIDffb7wqoGctWfX8jGLzCuRL8jwyfY8kX7ND6gv07tP3gs+tmKBDqXKmCSB58uYnodjtKWq5+o mL6+mT7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6XDQ-001vkn-0q; Tue, 06 Jun 2023 13:59:16 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6XDN-001vjZ-2o for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2023 13:59:15 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-565d1b86a63so101944287b3.0 for ; Tue, 06 Jun 2023 06:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686059949; x=1688651949; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gn/dFH22odtX6QmxBFqPjy05b5sFU03Muxh5Wl7MUWY=; b=TWSahW0vclogrCSwDkxLN7KbfBui2xZPFmRmleHMQtHFfaCSNrPPzfDjDqHXfb6jlC fGl1bvZdtJcTcY6w1eZ64W2sAMLQ1lsW8DXHUQatb3MzPz3fsz06PWlOa6FQXJoGZOYA D9Y49O2nk9w4ZqIYXDWbCv8nCwuENtkoOLDtWGMJbWbkFCZv8h/rW+tgIiX6dk+ZzBr6 TDSdTYmuEVMTm1g2U8mUkCG8KJkliOEIsTB2IULTwYnETUGgH8imNWo0bUMVY1FmRCKN 2UhxoTpquppB32KtCK0gxsdMntNHVQL7Q/9wSyEeqDJ2Tv8JnPZ1a5E97/VEfkG+OZf0 +JTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686059949; x=1688651949; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gn/dFH22odtX6QmxBFqPjy05b5sFU03Muxh5Wl7MUWY=; b=cwyqExb546OlLLj2ewFMbr4l73sCbeI9w67t+xWCSD4ARNnbVFh5/DlHEjsxnA0+wK zIJ1jr/qRS15CzDushNMq6hgPqWhw4W3RW9tNflPb4C5Q3czW9GoU/09RaxSwBz3kT0i G+F1DPAMOYm03VYvOGq2oUpPjg8/QamZnwiO8oyBH10G4SNDHNdAyfb65yE3cyw+TtQr RFpXcPpK131mJ+RAaWdykTj51TIzvcxJnUdhPksWoIlSZZKNIy1sFG8x8NG2JyLrOYjG SDF6sK7NvEum6boM8vWQUHXyhPxeRY8A7CNAdnYCvySXu0MmBONZ4V1JBpQNa3Kp7nBm 9l9A== X-Gm-Message-State: AC+VfDzW9ISOKcdJUcC3c8q+N2NkfKRcJEYrXAbH8eQzJ8MzmTWTvlNj 1JBDRBzuYkY9C5pAKZ4/OqhQ1r2+lEA= X-Google-Smtp-Source: ACHHUZ6/D/quV4fAtDjo6gBujt5UE2X+Hx20Ph0wcv5OeWnrjKAnqhhJ2HIJEjaFM6gSsFSJeQer8lrw+gI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:b1c4:0:b0:565:a43e:23c7 with SMTP id p187-20020a81b1c4000000b00565a43e23c7mr1077489ywh.0.1686059949165; Tue, 06 Jun 2023 06:59:09 -0700 (PDT) Date: Tue, 6 Jun 2023 06:59:07 -0700 In-Reply-To: <2f16f83e-ed60-fcb7-7f3d-0fa216c41cb9@redhat.com> Mime-Version: 1.0 References: <2f16f83e-ed60-fcb7-7f3d-0fa216c41cb9@redhat.com> Message-ID: Subject: Re: [PATCH] KVM: arm64: Fix smp_processor_id() call in preemptible context From: Sean Christopherson To: Sebastian Ott Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Oliver Upton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_065913_908589_72454427 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 06, 2023, Sebastian Ott wrote: > Fixes: 1c913a1c35aa ("KVM: arm64: Iterate arm_pmus list to probe for default PMU") > Signed-off-by: Sebastian Ott > --- > arch/arm64/kvm/pmu-emul.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c > index 491ca7eb2a4c..f9e4e4334875 100644 > --- a/arch/arm64/kvm/pmu-emul.c > +++ b/arch/arm64/kvm/pmu-emul.c > @@ -700,6 +700,7 @@ static struct arm_pmu *kvm_pmu_probe_armpmu(void) > > mutex_lock(&arm_pmus_lock); > > + preempt_disable(); get_cpu() + put_cpu() would be more succinct and self-documenting. > cpu = smp_processor_id(); > list_for_each_entry(entry, &arm_pmus, entry) { > tmp = entry->arm_pmu; > @@ -709,7 +710,7 @@ static struct arm_pmu *kvm_pmu_probe_armpmu(void) > break; > } > } > - > + preempt_enable(); > mutex_unlock(&arm_pmus_lock); > > return pmu; > -- > 2.40.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel