From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EBCC77B7A for ; Tue, 6 Jun 2023 18:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238896AbjFFSrL (ORCPT ); Tue, 6 Jun 2023 14:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238708AbjFFSrK (ORCPT ); Tue, 6 Jun 2023 14:47:10 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3458EE42 for ; Tue, 6 Jun 2023 11:46:43 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-565ef5a707dso92149887b3.3 for ; Tue, 06 Jun 2023 11:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686077200; x=1688669200; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8vjpQ/gPzw4IAJmjKfdYy1HzHlAdIXHWfCI3TgMZlwU=; b=ypxK+3K3Wqh9SEziB1wlVd3OXIxJkoZxUU29TjkP4NQfcmqUjYpzEI0ZCaGkW9laDX nlSauA7rwSDQTkXavXsmp2sFJQwjlS7Z7N8rlBs/HGdQAO+X6saXMRiRUwSZ2QsSo8Oc ECKz0m4J/WylJgGkqyV5saqIXdWNicH0E5miuOcb2beDdzJkL1jGRsJny8+chyiyklgQ m+6gNf7c7+JO4bl04XWNNlAxUEa93DKd5AkQ/W0WvN3qWS3eOJLtq97gP2573eH0BSnR WYCeeAcpO+8GjAkkxNN3FK7QMMh35AWVvnzwEGVp6iTvwWiflZuLsF3V/vEcbQwBnBIi Eknw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686077200; x=1688669200; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8vjpQ/gPzw4IAJmjKfdYy1HzHlAdIXHWfCI3TgMZlwU=; b=UEI8JdsfDqWO1YdVl3bQFgqvjCBwxfJQo05d6Nbrso5L98jnYalsWPR6TI0yIxEuCN qW66Txckj6M4VBt9PB+GCgvXmptucU0o54WKfhfNEoVbG9h3gBDpOrLeTZ05VSiEUPZu cQOBnD+GEiuSbwQvhI0PgFi6BU1AaYW5NVfzDEI10Nbr3c7GOjLmtKPAGySh37+z5d7B W/CewSkpBQ0AbXKUH7MzcATXdtP2N6eUPY6vyOpLR7Dhtd0+9GYMhYWcBbGMzks9gYBP OTKmTYyfA6b2RxIiMn846HuX5btmzOCx2WxRD3rw9CZv7sGEU6OIKifjXib5CAQwKGHB 3eFA== X-Gm-Message-State: AC+VfDy6T5XTGl2lUqqh/SQcK2Eh4xDVrv8yA3YF+RFzdXgKB2S4X2HC v5RfMtanSdct0abDZKctqFnKy6VC+do= X-Google-Smtp-Source: ACHHUZ7D4X5yRQTBWsHRPpLKxwHpepmjLlEx5mAwqv7Ydx6p+XrFcpF8l2408/KWu4GJ21U8881K0JtJPa4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:b619:0:b0:565:b20e:5b28 with SMTP id u25-20020a81b619000000b00565b20e5b28mr1565461ywh.8.1686077200223; Tue, 06 Jun 2023 11:46:40 -0700 (PDT) Date: Tue, 6 Jun 2023 11:46:38 -0700 In-Reply-To: <20230522161249.800829-3-aleksandr.mikhalitsyn@canonical.com> Mime-Version: 1.0 References: <20230522161249.800829-1-aleksandr.mikhalitsyn@canonical.com> <20230522161249.800829-3-aleksandr.mikhalitsyn@canonical.com> Message-ID: Subject: Re: [PATCH v2 2/2] KVM: SVM: enhance info printk's in SEV init From: Sean Christopherson To: Alexander Mikhalitsyn Cc: pbonzini@redhat.com, "=?iso-8859-1?Q?St=E9phane?= Graber" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, May 22, 2023, Alexander Mikhalitsyn wrote: > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index cc832a8d1bca..fff63d1f2a34 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -2224,7 +2224,6 @@ void __init sev_hardware_setup(void) > goto out; > } > > - pr_info("SEV supported: %u ASIDs\n", sev_asid_count); > sev_supported = true; > > /* SEV-ES support requested? */ > @@ -2252,10 +2251,16 @@ void __init sev_hardware_setup(void) > if (misc_cg_set_capacity(MISC_CG_RES_SEV_ES, sev_es_asid_count)) > goto out; > > - pr_info("SEV-ES supported: %u ASIDs\n", sev_es_asid_count); > sev_es_supported = true; > > out: > + if (boot_cpu_has(X86_FEATURE_SEV)) > + pr_info("SEV %s (ASIDs %u - %u)\n", > + sev_supported ? "enabled" : "disabled", min_sev_asid, max_sev_asid); > + if (boot_cpu_has(X86_FEATURE_SEV_ES)) > + pr_info("SEV-ES %s (ASIDs %u - %u)\n", > + sev_es_supported ? "enabled" : "disabled", 1, min_sev_asid - 1); The min should print '0' if min_sev_asid<=1, otherwise the output will be SEV-ES disabled (ASIDs 1 - 0) which is confusing. That would also align with what gets printed out for SEV when it's not supported at all (min==max=0). No need for v3, I'll fixup when applying.