From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0AD6C7EE2F for ; Tue, 6 Jun 2023 14:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2dS7cQYgBMLxXTBK9Y/+MC3YJj/lOKYmyF6VnJqV4Eo=; b=GZH2XHInV+VNp7 8E1xJMePhtjH8wUkHC/7GT9GZEojo6p6gZHj3ghha/7ml4cn6oja8y9fBP6ORzTaBoSDnOw1HwdsP IswhNrtm/dRPaRVh1ZTBSfKjWc+VxlURN4ki8jR9nyTLef5xsC9r62STiFeu5CnScpLH+5rJfXJtE IfQ/+puZKXreYCiV8XAkBH6esEsg8ilAZC0E+DDqZd5a072uzCCix17gNJUrKw+Tv0v/rx2QDqqNA +PjWcF7AE1rD1U1YCYiO8/9JkPGrY698DEWMfUXlLIXbf9JQej2PbLrsLZXw15WYQmvW9V53CEOpq WatwXqIc3ussRoWos81Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6XkN-00228L-0N; Tue, 06 Jun 2023 14:33:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6XkJ-00225T-2f for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2023 14:33:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+6wSVTqC9hZ5yHI/YY+rD+TrYLWp05DjiD+d7o8/gMY=; b=yc5efNVbf19ymsAUUBaBnelebW JyPWfx8REfOqdg5mC0LbkgJmSxIHCLoHZnt1fwAd9Fb5fhMIGrRHRZGK7fy3cJf+WE/4st62wQM5+ MOqXIOAFOBxT38GvyJnHWLcDmysjFpSEIAyjGe6F8rMIWrlnXnjUn3lVmLnvaoJ9sISul+HRAvj5j /EXmlgr4td587HKgTQSC5TzgBkjUYp6hQx9Be3A/FhskmJuqzh0lH+r38Q8PX4/x+6ZhjZQuOmIix 3Lp2CsuH/l5Plxbdh2M5eVjziM82JUbkWg/dif1UHsooLS370KkCj/ULsxrD+gEltO5MmN0TtMOXe KumfUCXg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53228) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6Xk2-0005rf-Rf; Tue, 06 Jun 2023 15:32:58 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q6Xjx-0007Dl-Vz; Tue, 06 Jun 2023 15:32:54 +0100 Date: Tue, 6 Jun 2023 15:32:53 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman Subject: Re: [PATCH net-next v2 0/3] Followup fixes for the dwmac and altera lynx conversion Message-ID: References: <20230606142144.308675-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230606142144.308675-1-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_073315_863063_23E38D69 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 06, 2023 at 04:21:41PM +0200, Maxime Chevallier wrote: > Following the TSE PCS removal and port of altera_tse and dwmac_socfpga, > this series fixes some issues that slipped through the cracks. > > Patch 1 fixes an unitialized struct in altera_tse > > Patch 2 uses the correct Kconfig option for altera_tse > > Patch 3 makes the Lynx PCS specific to dwmac_socfpga. This patch was > originally written by Russell, my modifications just moves the > #include around, to use it only in dwmac_socfpga. Hi Maxime, I'm sorry, but I think you need an extra patch added to this series. Looking at include/linux/mdio/mdio-regmap.h, that defines: struct mdio_regmap_config { struct device *parent; struct regmap *regmap; char name[MII_BUS_ID_SIZE]; u8 valid_addr; bool autoscan; }; In dwmac-socfpga.c, you have: struct mdio_regmap_config mrc; mrc.regmap = pcs_regmap; mrc.parent = &pdev->dev; mrc.valid_addr = 0x0; snprintf(mrc.name, MII_BUS_ID_SIZE, "%s-pcs-mii", ndev->name); So that's a tick for parent, tick for regmap, tick for name, tick for valid_addr, but... autoscan is left uninitialised. devm_mdio_regmap_register() reads this, and uses it to decide how to set mii->phy_mask, which will be randomly ~0 or ~BIT(0) depending on the value of mrc.autoscan. Other than that, the series looks good. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4394C77B73 for ; Tue, 6 Jun 2023 14:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238008AbjFFOdX (ORCPT ); Tue, 6 Jun 2023 10:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238038AbjFFOdK (ORCPT ); Tue, 6 Jun 2023 10:33:10 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA964E6C; Tue, 6 Jun 2023 07:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+6wSVTqC9hZ5yHI/YY+rD+TrYLWp05DjiD+d7o8/gMY=; b=yc5efNVbf19ymsAUUBaBnelebW JyPWfx8REfOqdg5mC0LbkgJmSxIHCLoHZnt1fwAd9Fb5fhMIGrRHRZGK7fy3cJf+WE/4st62wQM5+ MOqXIOAFOBxT38GvyJnHWLcDmysjFpSEIAyjGe6F8rMIWrlnXnjUn3lVmLnvaoJ9sISul+HRAvj5j /EXmlgr4td587HKgTQSC5TzgBkjUYp6hQx9Be3A/FhskmJuqzh0lH+r38Q8PX4/x+6ZhjZQuOmIix 3Lp2CsuH/l5Plxbdh2M5eVjziM82JUbkWg/dif1UHsooLS370KkCj/ULsxrD+gEltO5MmN0TtMOXe KumfUCXg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53228) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6Xk2-0005rf-Rf; Tue, 06 Jun 2023 15:32:58 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q6Xjx-0007Dl-Vz; Tue, 06 Jun 2023 15:32:54 +0100 Date: Tue, 6 Jun 2023 15:32:53 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman Subject: Re: [PATCH net-next v2 0/3] Followup fixes for the dwmac and altera lynx conversion Message-ID: References: <20230606142144.308675-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606142144.308675-1-maxime.chevallier@bootlin.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 04:21:41PM +0200, Maxime Chevallier wrote: > Following the TSE PCS removal and port of altera_tse and dwmac_socfpga, > this series fixes some issues that slipped through the cracks. > > Patch 1 fixes an unitialized struct in altera_tse > > Patch 2 uses the correct Kconfig option for altera_tse > > Patch 3 makes the Lynx PCS specific to dwmac_socfpga. This patch was > originally written by Russell, my modifications just moves the > #include around, to use it only in dwmac_socfpga. Hi Maxime, I'm sorry, but I think you need an extra patch added to this series. Looking at include/linux/mdio/mdio-regmap.h, that defines: struct mdio_regmap_config { struct device *parent; struct regmap *regmap; char name[MII_BUS_ID_SIZE]; u8 valid_addr; bool autoscan; }; In dwmac-socfpga.c, you have: struct mdio_regmap_config mrc; mrc.regmap = pcs_regmap; mrc.parent = &pdev->dev; mrc.valid_addr = 0x0; snprintf(mrc.name, MII_BUS_ID_SIZE, "%s-pcs-mii", ndev->name); So that's a tick for parent, tick for regmap, tick for name, tick for valid_addr, but... autoscan is left uninitialised. devm_mdio_regmap_register() reads this, and uses it to decide how to set mii->phy_mask, which will be randomly ~0 or ~BIT(0) depending on the value of mrc.autoscan. Other than that, the series looks good. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!