From: Wei Liu <wei.liu@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Subject: Re: [PATCH] xen/netback: Pass (void *) to virt_to_page()
Date: Fri, 26 May 2023 02:49:51 +0000 [thread overview]
Message-ID: <ZHAeT2m7297SOKfS@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20230524221147.5791ba3a@kernel.org>
On Wed, May 24, 2023 at 10:11:47PM -0700, Jakub Kicinski wrote:
> On Tue, 23 May 2023 16:03:42 +0200 Linus Walleij wrote:
> > virt_to_page() takes a virtual address as argument but
> > the driver passes an unsigned long, which works because
> > the target platform(s) uses polymorphic macros to calculate
> > the page.
> >
> > Since many architectures implement virt_to_pfn() as
> > a macro, this function becomes polymorphic and accepts both a
> > (unsigned long) and a (void *).
> >
> > Fix this up by an explicit (void *) cast.
>
> Paul, Wei, looks like netdev may be the usual path for this patch
> to flow thru, although I'm never 100% sure with Xen.
Yes. Netdev is the right path.
Thanks,
Wei.
prev parent reply other threads:[~2023-05-26 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 14:03 [PATCH] xen/netback: Pass (void *) to virt_to_page() Linus Walleij
2023-05-23 15:15 ` Wei Liu
2023-05-25 5:11 ` Jakub Kicinski
2023-05-25 5:12 ` Jakub Kicinski
2023-05-25 13:47 ` Linus Walleij
2023-05-26 2:49 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHAeT2m7297SOKfS@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.