From: andy.shevchenko@gmail.com
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linus.walleij@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field()
Date: Sat, 27 May 2023 01:02:01 +0300 [thread overview]
Message-ID: <ZHEsWS0PySD6j1MR@surfacebook> (raw)
In-Reply-To: <1680076012-10785-3-git-send-email-quic_mojha@quicinc.com>
Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti:
> Use qcom_scm_io_update_field() exported function introduced
> in last commit.
...
> u32 val;
> + u32 mask;
Swapping their order may help with readability.
...
> + mask = (7 << g->intr_target_bit);
Why not GENMASK(2, 0) at the same time?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-26 22:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:46 [PATCH v6 0/5] Refactor to support multiple download mode Mukesh Ojha
2023-03-29 7:46 ` [PATCH v6 1/5] firmware: qcom_scm: provide a read-modify-write function Mukesh Ojha
2023-05-26 22:00 ` andy.shevchenko
2023-03-29 7:46 ` [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field() Mukesh Ojha
2023-05-26 22:02 ` andy.shevchenko [this message]
2023-03-29 7:46 ` [PATCH v6 3/5] firmware: scm: Modify only the download bits in TCSR register Mukesh Ojha
2023-05-26 20:17 ` Bjorn Andersson
2023-03-29 7:46 ` [PATCH v6 4/5] firmware: qcom_scm: Refactor code to support multiple download mode Mukesh Ojha
2023-05-26 22:08 ` andy.shevchenko
2023-06-26 16:27 ` Mukesh Ojha
2023-06-26 17:12 ` Andy Shevchenko
2023-03-29 7:46 ` [PATCH v6 5/5] firmware: qcom_scm: Add multiple download mode support Mukesh Ojha
2023-05-26 22:14 ` andy.shevchenko
2023-05-26 23:36 ` Bjorn Andersson
2023-05-27 7:22 ` Andy Shevchenko
2023-04-10 14:34 ` [PATCH v6 0/5] Refactor to support multiple download mode Mukesh Ojha
2023-05-26 22:15 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHEsWS0PySD6j1MR@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.