From: Prathu Baronia <prathubaronia2011@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: dan.carpenter@linaro.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev, oe-kbuild@lists.linux.dev,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings
Date: Sat, 27 May 2023 14:23:16 +0530 [thread overview]
Message-ID: <ZHHE/H2p4Go/Igc/@redkillpc> (raw)
In-Reply-To: <2023052705-modular-unpleased-0e62@gregkh>
On Sat, May 27, 2023 at 08:35:57AM +0100, Greg KH wrote:
>
> Maybe error-prone, but all is fine with the original code, right?
>
Yes, all is fine with the original code. Replaced it only because it was error-prone.
> When you have "also" in a changelog commit, that usually means this
> needs to be split out into a separate patch. And that's the case here,
> make the first patch of the series fix the problem. Then do your
> cleanups on later patches.
>
Point taken, will split it in v4.
> > Fixes: d2d7aa53891e ("staging: axis-fifo: convert to use miscdevice")
>
> changing to a different string function does not fix anything.
Right, this should only be part of the smatch warning fixing commit.
>
> > Reported-by: kernel test robot <lkp@intel.com>
>
> It did not report that you need to replace a string function, right?
>
> See, things got messy when you mixed in changes into one. Please break
> these up.
Understood, will do.
Prathu
next prev parent reply other threads:[~2023-05-27 8:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 21:40 [PATCH] axis-fifo: use devm_kasprintf for device name Prathu Baronia
2023-05-14 6:37 ` Greg Kroah-Hartman
2023-05-14 13:01 ` Prathu Baronia
2023-05-14 13:01 ` [PATCH v2 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings Prathu Baronia
2023-05-15 7:42 ` Dan Carpenter
2023-05-18 14:31 ` Prathu Baronia
2023-05-18 14:51 ` [PATCH v3 " Prathu Baronia
2023-05-18 14:51 ` [PATCH v3 2/2] axis-fifo: cleanup space issues with fops struct Prathu Baronia
2023-05-27 7:35 ` [PATCH v3 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings Greg KH
2023-05-27 8:53 ` Prathu Baronia [this message]
2023-05-27 11:50 ` [PATCH v4 1/3] axis-fifo: fix smatch warning for format specifier Prathu Baronia
2023-05-27 11:50 ` [PATCH v4 2/3] axis-fifo: use devm_kasprintf() for allocating formatted strings Prathu Baronia
2023-05-28 9:00 ` Greg Kroah-Hartman
2023-06-13 16:03 ` Prathu Baronia
2023-05-27 11:51 ` [PATCH v4 3/3] axis-fifo: cleanup space issues with fops struct Prathu Baronia
2023-05-27 22:31 ` Uwe Kleine-König
2023-05-28 8:57 ` Greg Kroah-Hartman
2023-06-13 16:01 ` Prathu Baronia
2023-06-13 15:56 ` Prathu Baronia
2023-05-28 8:59 ` [PATCH v4 1/3] axis-fifo: fix smatch warning for format specifier Greg Kroah-Hartman
2023-06-13 16:02 ` Prathu Baronia
2023-06-16 15:25 ` [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings Prathu Baronia
2023-06-16 15:26 ` [PATCH v5 2/2] axis-fifo: remove the unnecessary dev_info() Prathu Baronia
2023-06-17 14:00 ` [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings Greg Kroah-Hartman
2023-06-19 6:43 ` Prathu Baronia
2023-06-19 16:22 ` [PATCH v6 " Prathu Baronia
2023-06-19 16:22 ` [PATCH v6 2/2] axis-fifo: change device name by assigning unique device id Prathu Baronia
2023-06-20 5:18 ` [PATCH v6 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings Dan Carpenter
2023-06-20 9:24 ` Greg Kroah-Hartman
2023-05-14 13:01 ` [PATCH v2 2/2] axis-fifo: cleanup space issues with fops struct Prathu Baronia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHHE/H2p4Go/Igc/@redkillpc \
--to=prathubaronia2011@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.