From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Sandipan Das <sandipan.das@amd.com>,
James Clark <james.clark@arm.com>,
Dmitrii Dolgov <9erthalion6@gmail.com>,
Changbin Du <changbin.du@huawei.com>,
Rob Herring <robh@kernel.org>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Fixes from evsel__group_pmu_name asan error
Date: Sun, 28 May 2023 10:19:21 -0300 [thread overview]
Message-ID: <ZHNU2ULCyO/H6uWA@kernel.org> (raw)
In-Reply-To: <20230526194442.2355872-1-irogers@google.com>
Em Fri, May 26, 2023 at 12:44:40PM -0700, Ian Rogers escreveu:
> evsel__group_pmu_name triggered an asan error as a list_head was cast
> to an evsel, when it was the head, and the accessed as if it were a
> full evsel. Further investigation showed problematic list iteration
> for evsel__group_pmu_name whilst the list was being sorted so switch
> to pre-computation.
>
> v3: Rebase on perf-tools-next (branch getting ready for 6.5) rather
> than perf-tools (fixes for 6.4).
> v2: Address review comments/feedback from Adrian Hunter
> <adrian.hunter@intel.com>.
Thanks, applied.
- Arnaldo
> Ian Rogers (2):
> perf evsel: evsel__group_pmu_name fixes
> perf evsel: for_each_group fixes
>
> tools/perf/util/evsel.c | 31 ++++-----------
> tools/perf/util/evsel.h | 26 +++++++-----
> tools/perf/util/evsel_fprintf.c | 1 +
> tools/perf/util/parse-events.c | 70 +++++++++++++++++++++++++++------
> 4 files changed, 84 insertions(+), 44 deletions(-)
>
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>
--
- Arnaldo
prev parent reply other threads:[~2023-05-28 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 19:44 [PATCH v3 0/2] Fixes from evsel__group_pmu_name asan error Ian Rogers
2023-05-26 19:44 ` [PATCH v3 1/2] perf evsel: evsel__group_pmu_name fixes Ian Rogers
2023-05-26 19:44 ` [PATCH v3 2/2] perf evsel: for_each_group fixes Ian Rogers
2023-05-28 13:19 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHNU2ULCyO/H6uWA@kernel.org \
--to=acme@kernel.org \
--cc=9erthalion6@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sandipan.das@amd.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.