All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-leds@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v3 03/13] Documentation: leds: leds-class: Document new Hardware driven LEDs APIs
Date: Mon, 29 May 2023 15:10:15 +0700	[thread overview]
Message-ID: <ZHRd5wDnMrWZlwrd@debian.me> (raw)
In-Reply-To: <20230527112854.2366-4-ansuelsmth@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

On Sat, May 27, 2023 at 01:28:44PM +0200, Christian Marangi wrote:
> +     - hw_control_set:
> +                activate hw control. LED driver will use the provided
> +                flags passed from the supported trigger, parse them to
> +                a set of mode and setup the LED to be driven by hardware
> +                following the requested modes.
> +
> +                Set LED_OFF via the brightness_set to deactivate hw control.
> +
> +                Return 0 on success, a negative error number on flags apply
> +                fail.
		   "... on failing to apply flags."

> +    - hw_control_get_device:
> +                return the device associated with the LED driver in
> +                hw control. A trigger might use this to match the
> +                returned device from this function with a configured
> +                device for the trigger as the source for blinking
> +                events and correctly enable hw control.
> +                (example a netdev trigger configured to blink for a
> +                particular dev match the returned dev from get_device
> +                to set hw control)
> +
> +                Return a device or NULL if nothing is currently attached.
Returns a device name?

> +
> +LED driver can activate additional modes by default to workaround the
> +impossibility of supporting each different mode on the supported trigger.
> +Example are hardcoding the blink speed to a set interval, enable special
"Examples are hardcoding ..."

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-05-29  8:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 11:28 [net-next PATCH v3 00/13] leds: introduce new LED hw control APIs Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 01/13] leds: add APIs for LEDs hw control Christian Marangi
2023-05-29 15:31   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 02/13] leds: add API to get attached device for LED " Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 03/13] Documentation: leds: leds-class: Document new Hardware driven LEDs APIs Christian Marangi
2023-05-29  8:10   ` Bagas Sanjaya [this message]
2023-05-29 14:12     ` Jonathan Corbet
2023-05-29 14:09       ` Christian Marangi
2023-05-30  3:09         ` Bagas Sanjaya
2023-05-30 12:24           ` Andrew Lunn
2023-05-29 14:52     ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 04/13] leds: trigger: netdev: refactor code setting device name Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 05/13] leds: trigger: netdev: introduce check for possible hw control Christian Marangi
2023-05-29 15:32   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 06/13] leds: trigger: netdev: add basic check for hw control support Christian Marangi
2023-05-29 15:33   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 07/13] leds: trigger: netdev: reject interval store for hw_control Christian Marangi
2023-05-29 15:33   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 08/13] leds: trigger: netdev: add support for LED hw control Christian Marangi
2023-05-29 15:45   ` Andrew Lunn
2023-05-29 15:52     ` Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 09/13] leds: trigger: netdev: validate configured netdev Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 10/13] leds: trigger: netdev: init mode if hw control already active Christian Marangi
2023-05-27 11:28 ` [net-next PATCH v3 11/13] leds: trigger: netdev: expose netdev trigger modes in linux include Christian Marangi
2023-05-29 15:47   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 12/13] net: dsa: qca8k: implement hw_control ops Christian Marangi
2023-05-29 15:52   ` Andrew Lunn
2023-05-27 11:28 ` [net-next PATCH v3 13/13] net: dsa: qca8k: add op to get ports netdev Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHRd5wDnMrWZlwrd@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.