From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <linux@rempel-privat.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: phy: fix a signedness bug in genphy_loopback()
Date: Tue, 30 May 2023 11:06:47 +0100 [thread overview]
Message-ID: <ZHXKt2Zfr/zSqIMq@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZHXGoaXX2YhqP2lm@shell.armlinux.org.uk>
On Tue, May 30, 2023 at 10:49:22AM +0100, Russell King (Oracle) wrote:
> On Tue, May 30, 2023 at 12:23:32PM +0300, Dan Carpenter wrote:
> > I don't see an issue in r8169_main.c and in drivers/net/phy/phy_device.c
> > then I only find the bug from this patch.
>
> I agree - inspecting the code reveals that "val" would be of type "int".
>
> > + BUILD_BUG_ON((typeof(val))~0ULL > 0); \
>
> I've just thrown this in to my builds, and building for arm64 using
> debian stable's gcc, I don't see any errors with genphy_loopback()
> suitably hacked, even with r8169 included in the build.
Also successfully built with 32-bit ARM gcc.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-30 10:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 11:45 [PATCH net] net: phy: fix a signedness bug in genphy_loopback() Dan Carpenter
2023-05-26 11:50 ` Russell King (Oracle)
2023-05-30 4:58 ` Jakub Kicinski
2023-05-30 9:01 ` Russell King (Oracle)
2023-05-30 9:06 ` Paolo Abeni
2023-05-30 9:23 ` Dan Carpenter
2023-05-30 9:40 ` Paolo Abeni
2023-05-30 9:49 ` Russell King (Oracle)
2023-05-30 10:06 ` Russell King (Oracle) [this message]
2023-05-30 12:39 ` Andrew Lunn
2023-05-30 14:40 ` Dan Carpenter
2023-05-30 17:06 ` Andrew Lunn
2023-05-30 19:19 ` Jakub Kicinski
2023-05-30 19:39 ` Russell King (Oracle)
2023-05-30 20:04 ` Andrew Lunn
2023-05-30 21:09 ` Russell King (Oracle)
2023-05-30 21:28 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHXKt2Zfr/zSqIMq@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.