From: Matthias Kaehlcke <mka@chromium.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] usb: misc: onboard_hub: Don't warn twice about problems during remove
Date: Tue, 30 May 2023 14:22:40 +0000 [thread overview]
Message-ID: <ZHYGsNmySbxvvdEv@google.com> (raw)
In-Reply-To: <20230530073633.2193618-1-u.kleine-koenig@pengutronix.de>
On Tue, May 30, 2023 at 09:36:33AM +0200, Uwe Kleine-König wrote:
> If onboard_hub_power_off() called by onboard_hub_remove() fails it emits
> an error message. Forwarding the returned error value to the driver core
> results in another error message. As the return value is otherwise
> ignored, just drop the return value. There is no side effect apart from
> suppressing the core's warning.
>
> Instead of returning zero unconditionally, convert to .remove_new()
> which has the same semantics as .remove() that unconditionally returns
> zero.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Matthias Kaehlcke <mka@chromium.org>
prev parent reply other threads:[~2023-05-30 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 7:36 [PATCH] usb: misc: onboard_hub: Don't warn twice about problems during remove Uwe Kleine-König
2023-05-30 14:22 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHYGsNmySbxvvdEv@google.com \
--to=mka@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.