From: Phillip Duncan <turtlekernelsanders@gmail.com>
To: David Sterba <dsterba@suse.cz>
Cc: Josef Bacik <josef@toxicpanda.com>, Linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: tests: fix formatting in btrfs-tests
Date: Tue, 30 May 2023 12:14:05 -0700 [thread overview]
Message-ID: <ZHZK/fXtzwuW8Zrf@flip-desktop> (raw)
In-Reply-To: <20230530185411.GD32581@twin.jikos.cz>
On Tue, May 30, 2023 at 08:54:11PM +0200, David Sterba wrote:
> On Mon, May 29, 2023 at 06:02:38PM -0700, Phillip Duncan wrote:
> > checkpatch.pl had a couple of formatting suggestions:
> > - #38: Don't use multiple blank lines
> > - #42: Missing a blank line after declarations
> > - #282: Alignment should match open parenthesis
> >
> > Fixed these format suggestions, checkpatch.pl is a little cleaner now.
>
> Please don't send such patches, or at least not to btrfs. A more
> elaborate answer:
>
> https://btrfs.readthedocs.io/en/latest/dev/Developer-s-FAQ.html#how-not-to-start
Thank you for taking the time to respond, I appreciate the direction for
where to start.
prev parent reply other threads:[~2023-05-30 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 1:02 [PATCH] btrfs: tests: fix formatting in btrfs-tests Phillip Duncan
2023-05-30 18:54 ` David Sterba
2023-05-30 19:14 ` Phillip Duncan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHZK/fXtzwuW8Zrf@flip-desktop \
--to=turtlekernelsanders@gmail.com \
--cc=Linux-btrfs@vger.kernel.org \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.