From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/3] btrfs: remove processed_extent infrastructure
Date: Tue, 30 May 2023 21:33:46 -0700 [thread overview]
Message-ID: <ZHbOKs8dS2ojyTNZ@infradead.org> (raw)
In-Reply-To: <b3f0ae3a-5f3d-8525-70e2-ace053350c59@gmx.com>
On Wed, May 31, 2023 at 07:35:44AM +0800, Qu Wenruo wrote:
> The objective looks like an optimization, if we submit two btrfs_bio for
> the two ranges, we will read the compressed extents twice, and do
> de-compression twice.
>
> Although this is anti-instinct, it at least has a valid reason.
>
> But I can argue that, this only works for holes, as if the range [4K,
> 8K) is not a hole, then we still need to submit two different btrfs_bio
> for [0, 4K) and [8K, 32K).
>
> Maybe it's time for us to determine whether the behavior is worthy.
To me this behaviour looks reaѕonable and worthwhile, but a comment
in end_bio_extent_readpage would probably have saved both of us a
fair amount of time..
next prev parent reply other threads:[~2023-05-31 4:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 1:45 [PATCH v2 0/3] btrfs: small cleanups mostly for subpage cases Qu Wenruo
2023-05-30 1:45 ` [PATCH v2 1/3] btrfs: make alloc_extent_buffer() handle previously uptodate range more efficient for subpage Qu Wenruo
2023-05-30 5:41 ` Christoph Hellwig
2023-05-30 1:45 ` [PATCH v2 2/3] btrfs: use the same @uptodate variable for end_bio_extent_readpage() Qu Wenruo
2023-05-30 5:41 ` Christoph Hellwig
2023-05-30 6:06 ` Anand Jain
2023-05-30 1:45 ` [PATCH v2 3/3] btrfs: remove processed_extent infrastructure Qu Wenruo
2023-05-30 5:43 ` Christoph Hellwig
2023-05-30 6:19 ` Qu Wenruo
2023-05-30 23:35 ` Qu Wenruo
2023-05-31 4:33 ` Christoph Hellwig [this message]
2023-05-30 12:48 ` [PATCH v2 0/3] btrfs: small cleanups mostly for subpage cases David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHbOKs8dS2ojyTNZ@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.