From: Andrea Claudi <aclaudi@redhat.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
dsahern@gmail.com, leon@kernel.org
Subject: Re: [PATCH iproute2-next] treewide: fix indentation
Date: Wed, 31 May 2023 12:12:58 +0200 [thread overview]
Message-ID: <ZHcdqoGUEs+Qcfgs@renaissance-vector> (raw)
In-Reply-To: <ZHbfVC03hq/wsHwG@shredder>
On Wed, May 31, 2023 at 08:47:00AM +0300, Ido Schimmel wrote:
> On Tue, May 30, 2023 at 07:19:53PM +0200, Andrea Claudi wrote:
> > Replace multiple whitespaces with tab where appropriate.
> >
> > Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
> > ---
> > bridge/vni.c | 2 +-
> > genl/ctrl.c | 2 +-
> > ip/ipaddress.c | 2 +-
> > ip/ipmacsec.c | 4 ++--
> > ip/ipprefix.c | 2 +-
> > ip/ipvrf.c | 2 +-
> > lib/fs.c | 2 +-
> > lib/ll_types.c | 10 +++++-----
> > rdma/dev.c | 10 +++++-----
> > tc/m_ipt.c | 4 ++--
> > tc/m_xt_old.c | 4 ++--
> > tc/q_fq.c | 8 ++++----
> > tc/q_htb.c | 4 ++--
> > tc/tc_core.c | 2 +-
> > 14 files changed, 29 insertions(+), 29 deletions(-)
>
> Thanks for the patch. Do you mind folding this one as well?
>
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 48cfafdbc3c0..d68c9d2a194b 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -88,7 +88,7 @@ static void explain(void)
> " enc_ttl MASKED-IP_TTL |\n"
> " geneve_opts MASKED-OPTIONS |\n"
> " vxlan_opts MASKED-OPTIONS |\n"
> - " erspan_opts MASKED-OPTIONS |\n"
> + " erspan_opts MASKED-OPTIONS |\n"
> " gtp_opts MASKED-OPTIONS |\n"
> " ip_flags IP-FLAGS |\n"
> " enc_dst_port [ port_number ] |\n"
>
> Before:
>
> $ tc filter add flower help 2>&1 | grep opts
> geneve_opts MASKED-OPTIONS |
> vxlan_opts MASKED-OPTIONS |
> erspan_opts MASKED-OPTIONS |
> gtp_opts MASKED-OPTIONS |
>
> After:
>
> $ tc filter add flower help 2>&1 | grep opts
> geneve_opts MASKED-OPTIONS |
> vxlan_opts MASKED-OPTIONS |
> erspan_opts MASKED-OPTIONS |
> gtp_opts MASKED-OPTIONS |
>
Thanks for the review.
I'll include it in v2, and I'll fix another issue in tc flower help.
prev parent reply other threads:[~2023-05-31 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 17:19 [PATCH iproute2-next] treewide: fix indentation Andrea Claudi
2023-05-31 5:47 ` Ido Schimmel
2023-05-31 10:12 ` Andrea Claudi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHcdqoGUEs+Qcfgs@renaissance-vector \
--to=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.