From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0118B2578 for ; Wed, 31 May 2023 19:17:08 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6af8b25fc72so92213a34.3 for ; Wed, 31 May 2023 12:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1685560627; x=1688152627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MHtweHA3SWHMpKKRoTnSYY+2sgOnMlETASaKZp5cnWg=; b=G8LdxrQVJXzPvDv6pj7E1fjzv3QptzwoXHIyMdWEmnvJfe91bWWQtAEUbaA6Nzl7Ky WCqn5A+Ib0XWSTJicI7+WetfhK7KQp318g0KeWJT1/vt4cdoJbEX7/oEO9dSKb/it9kA FsRFBszIqWGuho6X7dJOAYHqRjKwcQ/Jyz/eVKr5ZRT5HKgJuIzgfC3aRXtVSAyPaXoc ZnOEI6C1jQy2wrHvtZe0yTA1D2Gu5BufPvPbIqjVHpYfOSNMzoMO61TFbfhGoJBFYoYi mnzg1QOCQwYafPevYqJT5QgdPe4Jxi6B0eCez6eIsp/lkI9+cx82bblFziCVR9vO1iYZ mFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685560627; x=1688152627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MHtweHA3SWHMpKKRoTnSYY+2sgOnMlETASaKZp5cnWg=; b=HR6n/yigyd7mp2H0Qz/GOis8aAKhw7k1n1Td3tVVKGpBTViBEZAetQ3tRowAfEDfNV 0u2u1JFL/wYTzx0afWjY0+emRsupdBTCtgL+4D+Ayl+z5kufc5h3NUHcoc5DoCxfJ6Q6 26QGx8NH1lD42R/Q348Su6QH3OO1whl8P8Xy9jUWmwtV6zKfbXt+alxuxO3jEnwDzeIU ZhhklHsOOnu1rLxoTGbveoUTEqSVjSGDE0yW3wmyja+huxn/Swf2WReNn0gyCm5TFgvf z7I2pzySmlWDMdecWZcd/1qfum6n6i4kjkGrlQmDM9P7siI8px6gkJqzjwFphxZjZzLV TOeA== X-Gm-Message-State: AC+VfDxxZGtL3yGOSqJzQX/cB2eODu8gYldLrYfj2wNMCYwtyi9G256N yDFHSQD6aOVxkyA/rZc5eDOUBw== X-Google-Smtp-Source: ACHHUZ5EAb6uxqk7kkbizac+JrcIuoYNmIlHHRhpUDjRmBZ8boj1JThitoXP6J0DZ/TEoplrWHjlbg== X-Received: by 2002:a05:6358:7e9b:b0:123:3203:928a with SMTP id o27-20020a0563587e9b00b001233203928amr1487114rwn.27.1685560627568; Wed, 31 May 2023 12:17:07 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id g3-20020a17090a300300b00250d670306esm1594668pjb.35.2023.05.31.12.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 12:17:06 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1q4RJh-0017d4-7W; Wed, 31 May 2023 16:17:05 -0300 Date: Wed, 31 May 2023 16:17:05 -0300 From: Jason Gunthorpe To: Yu Zhao Cc: Andrew Morton , Paolo Bonzini , Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com Subject: Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() Message-ID: References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-2-yuzhao@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526234435.662652-2-yuzhao@google.com> On Fri, May 26, 2023 at 05:44:26PM -0600, Yu Zhao wrote: > @@ -122,6 +124,10 @@ struct mmu_notifier_ops { > struct mm_struct *mm, > unsigned long address); > > + int (*test_clear_young)(struct mmu_notifier *mn, struct mm_struct *mm, > + unsigned long start, unsigned long end, > + bool clear, unsigned long *bitmap); > + Why leave clear_young behind? Just make a NULL bitmap mean clear_young? Jason