From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-18.mta1.migadu.com (out-18.mta1.migadu.com [95.215.58.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A3F168A8 for ; Wed, 31 May 2023 23:23:05 +0000 (UTC) Date: Wed, 31 May 2023 23:22:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685575383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXIoTlecMC6VxxSME1sHTXGjADcYTmN1y7mvnJvjlhM=; b=lyfbrHT4Q4zo1L0ArqeQIdJoep5zRjHJ2OLTTh3iRuaDrDCmyrt6ZdUnmT8D0VRFrnKrfd Fay41KvYXJP8CWHfKOE6M8su7vw1n8IEhIPvIvj0EphIHYOG0Ve9WKW9yduPpl6rDOCxtx CeLsU8HW8TNpYdjp9DmTE9Euk9lTN+Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Yu Zhao Cc: Andrew Morton , Paolo Bonzini , Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com Subject: Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe Message-ID: References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-5-yuzhao@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, May 31, 2023 at 05:10:52PM -0600, Yu Zhao wrote: > On Wed, May 31, 2023 at 1:28 PM Oliver Upton wrote: > > On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > > > On Tue, May 30, 2023 at 1:37 PM Oliver Upton wrote: > > > > As it is currently implemented, yes. But, there's potential to fast-path > > > > the implementation by checking page_count() before starting the walk. > > > > > > Do you mind posting another patch? I'd be happy to ack it, as well as > > > the one you suggested above. > > > > I'd rather not take such a patch independent of the test_clear_young > > series if you're OK with that. Do you mind implementing something > > similar to the above patch w/ the proposed optimization if you need it? > > No worries. I can take the above together with the following, which > would form a new series with its own merits, since apparently you > think the !AF case is important. Sorry if my suggestion was unclear. I thought we were talking about ->free_removed_table() being called from the stage-2 unmap path, in which case we wind up unnecessarily visiting PTEs on a table known to be empty. You could fast-path that by only initiating a walk if page_count() > 1: diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c index 95dae02ccc2e..766563dc465c 100644 --- a/arch/arm64/kvm/hyp/pgtable.c +++ b/arch/arm64/kvm/hyp/pgtable.c @@ -1331,7 +1331,8 @@ void kvm_pgtable_stage2_free_removed(struct kvm_pgtable_mm_ops *mm_ops, void *pg .end = kvm_granule_size(level), }; - WARN_ON(__kvm_pgtable_walk(&data, mm_ops, ptep, level + 1)); + if (mm_ops->page_count(pgtable) > 1) + WARN_ON(__kvm_pgtable_walk(&data, mm_ops, ptep, level + 1)); WARN_ON(mm_ops->page_count(pgtable) != 1); mm_ops->put_page(pgtable); A lock-free access fault walker is interesting, but in my testing it hasn't led to any significant improvements over acquiring the MMU lock for read. Because of that I hadn't bothered with posting the series upstream. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD28FC77B73 for ; Wed, 31 May 2023 23:24:09 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QWlhS1Wvvz3fGL for ; Thu, 1 Jun 2023 09:24:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lyfbrHT4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=2001:41d0:203:375::15; helo=out-21.mta1.migadu.com; envelope-from=oliver.upton@linux.dev; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lyfbrHT4; dkim-atps=neutral Received: from out-21.mta1.migadu.com (out-21.mta1.migadu.com [IPv6:2001:41d0:203:375::15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QWlgV2FKvz3bnP for ; Thu, 1 Jun 2023 09:23:16 +1000 (AEST) Date: Wed, 31 May 2023 23:22:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685575383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXIoTlecMC6VxxSME1sHTXGjADcYTmN1y7mvnJvjlhM=; b=lyfbrHT4Q4zo1L0ArqeQIdJoep5zRjHJ2OLTTh3iRuaDrDCmyrt6ZdUnmT8D0VRFrnKrfd Fay41KvYXJP8CWHfKOE6M8su7vw1n8IEhIPvIvj0EphIHYOG0Ve9WKW9yduPpl6rDOCxtx CeLsU8HW8TNpYdjp9DmTE9Euk9lTN+Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Yu Zhao Subject: Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe Message-ID: References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-5-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , x86@kernel.org, Gavin Shan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Peter Xu , linux-mm@kvack.org, Ben Gardon , Chao Peng , Will Deacon , Gaosheng Cui , Marc Zyngier , "H. Peter Anvin" , Jonathan Corbet , Alistair Popple , Jason Gunthorpe , Ingo Molnar , Zenghui Yu , linux-trace-kernel@vger.kernel.org, linux-mm@google.com, Thomas Huth , Suzuki K Poulose , Nicholas Piggin , Borislav Petkov , Steven Rostedt , kvmarm@lists.linux.dev, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Fab iano Rosas , Michael Larabel , Sean Christopherson , linux-kernel@vger.kernel.org, James Morse , Masami Hiramatsu , Anup Patel , Paolo Bonzini , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 31, 2023 at 05:10:52PM -0600, Yu Zhao wrote: > On Wed, May 31, 2023 at 1:28 PM Oliver Upton wrote: > > On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > > > On Tue, May 30, 2023 at 1:37 PM Oliver Upton wrote: > > > > As it is currently implemented, yes. But, there's potential to fast-path > > > > the implementation by checking page_count() before starting the walk. > > > > > > Do you mind posting another patch? I'd be happy to ack it, as well as > > > the one you suggested above. > > > > I'd rather not take such a patch independent of the test_clear_young > > series if you're OK with that. Do you mind implementing something > > similar to the above patch w/ the proposed optimization if you need it? > > No worries. I can take the above together with the following, which > would form a new series with its own merits, since apparently you > think the !AF case is important. Sorry if my suggestion was unclear. I thought we were talking about ->free_removed_table() being called from the stage-2 unmap path, in which case we wind up unnecessarily visiting PTEs on a table known to be empty. You could fast-path that by only initiating a walk if page_count() > 1: diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c index 95dae02ccc2e..766563dc465c 100644 --- a/arch/arm64/kvm/hyp/pgtable.c +++ b/arch/arm64/kvm/hyp/pgtable.c @@ -1331,7 +1331,8 @@ void kvm_pgtable_stage2_free_removed(struct kvm_pgtable_mm_ops *mm_ops, void *pg .end = kvm_granule_size(level), }; - WARN_ON(__kvm_pgtable_walk(&data, mm_ops, ptep, level + 1)); + if (mm_ops->page_count(pgtable) > 1) + WARN_ON(__kvm_pgtable_walk(&data, mm_ops, ptep, level + 1)); WARN_ON(mm_ops->page_count(pgtable) != 1); mm_ops->put_page(pgtable); A lock-free access fault walker is interesting, but in my testing it hasn't led to any significant improvements over acquiring the MMU lock for read. Because of that I hadn't bothered with posting the series upstream. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A61CC77B73 for ; Wed, 31 May 2023 23:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MWBmf5vqzt1XvV8txxaxCRgbKYtpIAORqoWV67KpZ0U=; b=tTAe03lb5j0yyL uH3xtmBprKYhmgIlhADRQOl7IMXn+czy9VnI6Nig+udv/BmEZeJG+Af0/wMRCombRTleoQoeAMF7r Ms3DPfk3uU4ay9GThF9Gdj+WtdFbhdl25p6QTos96oZDGdkLLIBAP0x58Z0Drj6l15NFH6CjvwH8H CF6fvs01l6hVds3CPrg3dgNPZP6m3/BkErOCpSCldW6wDrg854nVfDZiS9I7N8/qxM3W6SZV+WkLN 8oimwTwKdRoF0aD4Tl4ZAllOSSo+9m92xILJkpHPD5QhfDFpTukaEc5CazqC3agZRmG3+7nheI/lM a/ByY0J3W8ozkj15JJYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4V9q-001Sal-28; Wed, 31 May 2023 23:23:10 +0000 Received: from out-36.mta1.migadu.com ([2001:41d0:203:375::24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4V9n-001SZS-0w for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 23:23:09 +0000 Date: Wed, 31 May 2023 23:22:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685575383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXIoTlecMC6VxxSME1sHTXGjADcYTmN1y7mvnJvjlhM=; b=lyfbrHT4Q4zo1L0ArqeQIdJoep5zRjHJ2OLTTh3iRuaDrDCmyrt6ZdUnmT8D0VRFrnKrfd Fay41KvYXJP8CWHfKOE6M8su7vw1n8IEhIPvIvj0EphIHYOG0Ve9WKW9yduPpl6rDOCxtx CeLsU8HW8TNpYdjp9DmTE9Euk9lTN+Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Yu Zhao Cc: Andrew Morton , Paolo Bonzini , Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com Subject: Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe Message-ID: References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-5-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_162307_870769_6F392263 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgMDU6MTA6NTJQTSAtMDYwMCwgWXUgWmhhbyB3cm90ZToK PiBPbiBXZWQsIE1heSAzMSwgMjAyMyBhdCAxOjI44oCvUE0gT2xpdmVyIFVwdG9uIDxvbGl2ZXIu dXB0b25AbGludXguZGV2PiB3cm90ZToKPiA+IE9uIFR1ZSwgTWF5IDMwLCAyMDIzIGF0IDAyOjA2 OjU1UE0gLTA2MDAsIFl1IFpoYW8gd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgTWF5IDMwLCAyMDIzIGF0 IDE6MzfigK9QTSBPbGl2ZXIgVXB0b24gPG9saXZlci51cHRvbkBsaW51eC5kZXY+IHdyb3RlOgo+ ID4gPiA+IEFzIGl0IGlzIGN1cnJlbnRseSBpbXBsZW1lbnRlZCwgeWVzLiBCdXQsIHRoZXJlJ3Mg cG90ZW50aWFsIHRvIGZhc3QtcGF0aAo+ID4gPiA+IHRoZSBpbXBsZW1lbnRhdGlvbiBieSBjaGVj a2luZyBwYWdlX2NvdW50KCkgYmVmb3JlIHN0YXJ0aW5nIHRoZSB3YWxrLgo+ID4gPgo+ID4gPiBE byB5b3UgbWluZCBwb3N0aW5nIGFub3RoZXIgcGF0Y2g/IEknZCBiZSBoYXBweSB0byBhY2sgaXQs IGFzIHdlbGwgYXMKPiA+ID4gdGhlIG9uZSB5b3Ugc3VnZ2VzdGVkIGFib3ZlLgo+ID4KPiA+IEkn ZCByYXRoZXIgbm90IHRha2Ugc3VjaCBhIHBhdGNoIGluZGVwZW5kZW50IG9mIHRoZSB0ZXN0X2Ns ZWFyX3lvdW5nCj4gPiBzZXJpZXMgaWYgeW91J3JlIE9LIHdpdGggdGhhdC4gRG8geW91IG1pbmQg aW1wbGVtZW50aW5nIHNvbWV0aGluZwo+ID4gc2ltaWxhciB0byB0aGUgYWJvdmUgcGF0Y2ggdy8g dGhlIHByb3Bvc2VkIG9wdGltaXphdGlvbiBpZiB5b3UgbmVlZCBpdD8KPiAKPiBObyB3b3JyaWVz LiBJIGNhbiB0YWtlIHRoZSBhYm92ZSB0b2dldGhlciB3aXRoIHRoZSBmb2xsb3dpbmcsIHdoaWNo Cj4gd291bGQgZm9ybSBhIG5ldyBzZXJpZXMgd2l0aCBpdHMgb3duIG1lcml0cywgc2luY2UgYXBw YXJlbnRseSB5b3UKPiB0aGluayB0aGUgIUFGIGNhc2UgaXMgaW1wb3J0YW50LgoKU29ycnkgaWYg bXkgc3VnZ2VzdGlvbiB3YXMgdW5jbGVhci4KCkkgdGhvdWdodCB3ZSB3ZXJlIHRhbGtpbmcgYWJv dXQgLT5mcmVlX3JlbW92ZWRfdGFibGUoKSBiZWluZyBjYWxsZWQgZnJvbQp0aGUgc3RhZ2UtMiB1 bm1hcCBwYXRoLCBpbiB3aGljaCBjYXNlIHdlIHdpbmQgdXAgdW5uZWNlc3NhcmlseSB2aXNpdGlu ZwpQVEVzIG9uIGEgdGFibGUga25vd24gdG8gYmUgZW1wdHkuIFlvdSBjb3VsZCBmYXN0LXBhdGgg dGhhdCBieSBvbmx5CmluaXRpYXRpbmcgYSB3YWxrIGlmICBwYWdlX2NvdW50KCkgPiAxOgoKZGlm ZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMgYi9hcmNoL2FybTY0L2t2bS9o eXAvcGd0YWJsZS5jCmluZGV4IDk1ZGFlMDJjY2MyZS4uNzY2NTYzZGM0NjVjIDEwMDY0NAotLS0g YS9hcmNoL2FybTY0L2t2bS9oeXAvcGd0YWJsZS5jCisrKyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9w Z3RhYmxlLmMKQEAgLTEzMzEsNyArMTMzMSw4IEBAIHZvaWQga3ZtX3BndGFibGVfc3RhZ2UyX2Zy ZWVfcmVtb3ZlZChzdHJ1Y3Qga3ZtX3BndGFibGVfbW1fb3BzICptbV9vcHMsIHZvaWQgKnBnCiAJ CS5lbmQJPSBrdm1fZ3JhbnVsZV9zaXplKGxldmVsKSwKIAl9OwogCi0JV0FSTl9PTihfX2t2bV9w Z3RhYmxlX3dhbGsoJmRhdGEsIG1tX29wcywgcHRlcCwgbGV2ZWwgKyAxKSk7CisJaWYgKG1tX29w cy0+cGFnZV9jb3VudChwZ3RhYmxlKSA+IDEpCisJCVdBUk5fT04oX19rdm1fcGd0YWJsZV93YWxr KCZkYXRhLCBtbV9vcHMsIHB0ZXAsIGxldmVsICsgMSkpOwogCiAJV0FSTl9PTihtbV9vcHMtPnBh Z2VfY291bnQocGd0YWJsZSkgIT0gMSk7CiAJbW1fb3BzLT5wdXRfcGFnZShwZ3RhYmxlKTsKCgpB IGxvY2stZnJlZSBhY2Nlc3MgZmF1bHQgd2Fsa2VyIGlzIGludGVyZXN0aW5nLCBidXQgaW4gbXkg dGVzdGluZyBpdCBoYXNuJ3QKbGVkIHRvIGFueSBzaWduaWZpY2FudCBpbXByb3ZlbWVudHMgb3Zl ciBhY3F1aXJpbmcgdGhlIE1NVSBsb2NrIGZvcgpyZWFkLiBCZWNhdXNlIG9mIHRoYXQgSSBoYWRu J3QgYm90aGVyZWQgd2l0aCBwb3N0aW5nIHRoZSBzZXJpZXMgdXBzdHJlYW0uCgotLSAKVGhhbmtz LApPbGl2ZXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK