From: Jason Gunthorpe <jgg@nvidia.com>
To: 00000000000063657005fbf44fb2@google.com
Cc: zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org, Zhu Yanjun <yanjun.zhu@linux.dev>,
syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/1] RDMA/rxe: Fix the use-before-initialization error of resp_pkts
Date: Thu, 1 Jun 2023 12:58:55 -0300 [thread overview]
Message-ID: <ZHjAPwKB/si3qJSb@nvidia.com> (raw)
In-Reply-To: <20230523054739.594384-1-yanjun.zhu@intel.com>
On Tue, May 23, 2023 at 01:47:39PM +0800, Zhu Yanjun wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> In the following:
> "
> Call Trace:
> <TASK>
> __dump_stack lib/dump_stack.c:88 [inline]
> dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
> assign_lock_key kernel/locking/lockdep.c:982 [inline]
> register_lock_class+0xdb6/0x1120 kernel/locking/lockdep.c:1295
> __lock_acquire+0x10a/0x5df0 kernel/locking/lockdep.c:4951
> lock_acquire kernel/locking/lockdep.c:5691 [inline]
> lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5656
> __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
> _raw_spin_lock_irqsave+0x3d/0x60 kernel/locking/spinlock.c:162
> skb_dequeue+0x20/0x180 net/core/skbuff.c:3639
> drain_resp_pkts drivers/infiniband/sw/rxe/rxe_comp.c:555 [inline]
> rxe_completer+0x250d/0x3cc0 drivers/infiniband/sw/rxe/rxe_comp.c:652
> rxe_qp_do_cleanup+0x1be/0x820 drivers/infiniband/sw/rxe/rxe_qp.c:761
> execute_in_process_context+0x3b/0x150 kernel/workqueue.c:3473
> __rxe_cleanup+0x21e/0x370 drivers/infiniband/sw/rxe/rxe_pool.c:233
> rxe_create_qp+0x3f6/0x5f0 drivers/infiniband/sw/rxe/rxe_verbs.c:583
> ...
> "
> This is a use-before-initialization problem.
>
> In the following function
> "
> 291 /* called by the create qp verb */
> 292 int rxe_qp_from_init(struct rxe_dev *rxe, struct rxe_qp *qp,
> struct rxe_pd *pd,
> 297 {
> ...
> 317 rxe_qp_init_misc(rxe, qp, init);
> ...
> 322
> 323 err = rxe_qp_init_resp(rxe, qp, init, udata, uresp);
> 324 if (err)
> 325 goto err2; <--- error
>
> ...
>
> 334 err2:
> 335 rxe_queue_cleanup(qp->sq.queue); <--- Goto here
> 336 qp->sq.queue = NULL;
> "
> In rxe_qp_init_resp, the error occurs before skb_queue_head_init.
> So this call trace appeared.
>
> Reported-by: syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
This needs a fixes line and a link line to the syzkaller report email
Jason
next prev parent reply other threads:[~2023-06-01 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 5:47 [PATCH 1/1] RDMA/rxe: Fix the use-before-initialization error of resp_pkts Zhu Yanjun
2023-06-01 15:58 ` Jason Gunthorpe [this message]
2023-06-02 2:22 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjAPwKB/si3qJSb@nvidia.com \
--to=jgg@nvidia.com \
--cc=00000000000063657005fbf44fb2@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.