All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: simatic-ipc-leds-gpio: add new model BX-21A
Date: Thu, 1 Jun 2023 19:50:59 +0300	[thread overview]
Message-ID: <ZHjMcwcCbSyMx5d9@smile.fi.intel.com> (raw)
In-Reply-To: <20230531155457.31632-2-henning.schild@siemens.com>

On Wed, May 31, 2023 at 05:54:57PM +0200, Henning Schild wrote:
> This adds support for the Siemens Simatic IPC BX-21A. Its LEDs are
> connected to GPIO pins provided by the Intel Elkhart Lake pinctrl
> driver.

...

> +static struct platform_driver simatic_ipc_led_gpio_elkhartlake_driver = {
> +	.probe = simatic_ipc_leds_gpio_elkhartlake_probe,
> +	.remove = simatic_ipc_leds_gpio_elkhartlake_remove,
> +	.driver = {
> +		.name = KBUILD_MODNAME,

Just wondering if module name and hence device instance name (which may be
longer) can be so long.

Hint: you can use EHL/ehl for elkhartlake and in same way for the rest if any.

> +	},
> +};

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2023-06-01 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 15:54 [PATCH 0/1] leds: simatic-ipc-leds-gpio: add new model BX-21A Henning Schild
2023-05-31 15:54 ` [PATCH 1/1] " Henning Schild
2023-06-01  8:53   ` Hans de Goede
2023-07-05 10:48     ` Henning Schild
2023-07-13 13:20       ` Lee Jones
2023-06-01 16:50   ` Andy Shevchenko [this message]
2023-05-31 16:01 ` [PATCH 0/1] " Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHjMcwcCbSyMx5d9@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=henning.schild@siemens.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.