From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Longfang Liu <liulongfang@huawei.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH] vfio: Fixup kconfig ordering for VFIO_PCI_CORE
Date: Thu, 1 Jun 2023 19:45:28 -0300 [thread overview]
Message-ID: <ZHkfiMSGuseMabEI@nvidia.com> (raw)
In-Reply-To: <20230601154857.62cbe199.alex.williamson@redhat.com>
On Thu, Jun 01, 2023 at 03:48:57PM -0600, Alex Williamson wrote:
> Allowing VFIO_PCI_CORE without building an in-kernel module that
> depends on it seals the deal for me that this is the wrong approach
> though.
I don't think that is abnormal, we have constructs like this around,
kconfig has its limits.
> > > I don't see why we wouldn't just make each of the variant drivers
> > > select VFIO_PCI_CORE. Thanks,
> >
> > It can be done, but it seems more fragile.
>
> How so?
The if stanza in the core's kconfig does the right thing automatically
without any need to think about the driver kconfigs.
Jason
prev parent reply other threads:[~2023-06-01 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 17:47 [PATCH] vfio: Fixup kconfig ordering for VFIO_PCI_CORE Jason Gunthorpe
2023-06-01 20:42 ` Alex Williamson
2023-06-01 20:48 ` Jason Gunthorpe
2023-06-01 21:48 ` Alex Williamson
2023-06-01 22:45 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHkfiMSGuseMabEI@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.