From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA62C77B7A for ; Fri, 2 Jun 2023 10:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235328AbjFBK5M (ORCPT ); Fri, 2 Jun 2023 06:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235190AbjFBK5L (ORCPT ); Fri, 2 Jun 2023 06:57:11 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3330123 for ; Fri, 2 Jun 2023 03:57:07 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1q52Sv-0001wW-H2; Fri, 02 Jun 2023 12:57:05 +0200 Date: Fri, 2 Jun 2023 12:57:05 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH iptables] nft: check for source and destination address in first place Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20230601192828.86384-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601192828.86384-1-pablo@netfilter.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jun 01, 2023 at 09:28:28PM +0200, Pablo Neira Ayuso wrote: > When generating bytecode, check for source and destination address in > first place, then, check for the input and output device. In general, > the first expression in the rule is the most evaluated during the > evaluation process. These selectors are likely to show more variability > in rulesets. The change is effective only for rules which match on both address(es) and interface(s) anyway. Patch applied, thanks!