From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpiolib: Do not unexport GPIO on freeing
Date: Fri, 2 Jun 2023 19:29:00 +0300 [thread overview]
Message-ID: <ZHoYzFPNrwwNpm93@smile.fi.intel.com> (raw)
In-Reply-To: <20230602162258.63853-1-andriy.shevchenko@linux.intel.com>
On Fri, Jun 02, 2023 at 07:22:58PM +0300, Andy Shevchenko wrote:
> Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> GPIO on freeing. Remove that call.
>
> Note, the other users of this functionality do that explicitly,
> except one SH boardfile which doesn't free GPIO anyways, so it
> is safe to drop the call.
Note, that this might be squashed with the above mentioned commit, because
I haven't checked current users I didn't do the removal in that patch.
But this will probably needs rebase which is not good thing process wise.
So, just my 2 cents in case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-02 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:22 [PATCH v1 1/1] gpiolib: Do not unexport GPIO on freeing Andy Shevchenko
2023-06-02 16:29 ` Andy Shevchenko [this message]
2023-06-02 16:34 ` Andy Shevchenko
2023-06-09 9:35 ` Bartosz Golaszewski
2023-06-06 18:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHoYzFPNrwwNpm93@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.