From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, suresh.b.siddha@intel.com,
Kishon Vijay Abraham I <kvijayab@amd.com>,
Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v1] x86/apic: Fix kernel panic when "intremap=off" and "x2apic_phys" are set
Date: Mon, 19 Jun 2023 01:24:01 +0300 [thread overview]
Message-ID: <ZI+EARkh3xsvkRfA@grain> (raw)
In-Reply-To: <20230616212236.1389-1-dheerajkumar.srivastava@amd.com>
On Sat, Jun 17, 2023 at 02:52:36AM +0530, Dheeraj Kumar Srivastava wrote:
> x2APIC mode requires "Interrupt Remapping" to be enabled and the
> "physical x2apic" driver can be used only when x2APIC mode is enabled.
> However when "intremap=off" and "x2apic_phys" kernel command line
> parameters are passed, "physical x2apic" driver is being used even when
> x2APIC mode is disabled ("intremap=off" disables x2APIC mode).
> This results in the below kernel panic:
...
Hi! Good catch! In long term I think we could switch to use x2apic_state variable
instead since at the moment the code is somehow hard to read and remember which exactly
deps are to be satisfied to enable x2apic mode.
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2023-06-18 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 21:22 [PATCH v1] x86/apic: Fix kernel panic when "intremap=off" and "x2apic_phys" are set Dheeraj Kumar Srivastava
2023-06-18 22:24 ` Cyrill Gorcunov [this message]
2023-06-19 15:25 ` Thomas Gleixner
2023-06-19 14:50 ` Borislav Petkov
2023-06-19 16:31 ` Thomas Gleixner
2023-06-19 19:10 ` [tip: x86/urgent] x86/apic: Fix kernel panic when booting with intremap=off and x2apic_phys tip-bot2 for Dheeraj Kumar Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI+EARkh3xsvkRfA@grain \
--to=gorcunov@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dheerajkumar.srivastava@amd.com \
--cc=hpa@zytor.com \
--cc=kvijayab@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=vasant.hegde@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.