From: Simon Horman <simon.horman@corigine.com>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org,
Alexander Duyck <alexander.duyck@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next 01/17] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES)
Date: Sat, 17 Jun 2023 15:52:04 +0200 [thread overview]
Message-ID: <ZI26hJuixlQHOjk4@corigine.com> (raw)
In-Reply-To: <708510.1686984195@warthog.procyon.org.uk>
On Sat, Jun 17, 2023 at 07:43:15AM +0100, David Howells wrote:
> Simon Horman <simon.horman@corigine.com> wrote:
>
> > > + cache = get_cpu_ptr(&skb_splice_frag_cache);
> ...
> > > + put_cpu_ptr(skb_splice_frag_cache);
> >
> > Hi David,
> >
> > I don't think it makes any difference at run-time.
> > But to keep Sparse happy, perhaps this ought to be put_cpu_var()
>
> Actually, the problem is a missing "&". I think I should use put_cpu_ptr() to
> match get_cpu_ptr(). It doesn't crash because the argument is ignored.
Thanks David, I agree that is a better idea.
next prev parent reply other threads:[~2023-06-17 13:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 16:12 [PATCH net-next 00/17] splice, net: Switch over users of sendpage() and remove it David Howells
2023-06-16 16:12 ` [PATCH net-next 01/17] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES) David Howells
2023-06-16 19:49 ` Simon Horman
2023-06-17 6:43 ` David Howells
2023-06-17 13:52 ` Simon Horman [this message]
2023-06-16 16:12 ` [PATCH net-next 02/17] net: Display info about MSG_SPLICE_PAGES memory handling in proc David Howells
2023-06-16 16:12 ` [PATCH net-next 03/17] tcp_bpf, smc, tls, espintcp: Reduce MSG_SENDPAGE_NOTLAST usage David Howells
2023-06-16 16:12 ` [PATCH net-next 04/17] siw: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage to transmit David Howells
2023-06-16 16:12 ` [PATCH net-next 05/17] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage David Howells
2023-06-16 16:12 ` [PATCH net-next 06/17] net: Use sendmsg(MSG_SPLICE_PAGES) not sendpage in skb_send_sock() David Howells
2023-06-16 16:12 ` [PATCH net-next 07/17] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage() David Howells
2023-06-16 16:12 ` [PATCH net-next 08/17] rds: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage David Howells
2023-06-16 16:12 ` [Cluster-devel] [PATCH net-next 09/17] dlm: " David Howells
2023-06-16 16:12 ` David Howells
2023-06-16 16:12 ` [PATCH net-next 10/17] nvme: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage David Howells
2023-06-16 16:12 ` [PATCH net-next 11/17] smc: Drop smc_sendpage() in favour of smc_sendmsg() + MSG_SPLICE_PAGES David Howells
2023-06-16 16:12 ` [Ocfs2-devel] [PATCH net-next 12/17] ocfs2: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage() David Howells via Ocfs2-devel
2023-06-16 16:12 ` David Howells
2023-06-16 16:12 ` [PATCH net-next 13/17] drbd: " David Howells
2023-06-16 16:12 ` [Drbd-dev] " David Howells
2023-06-16 16:12 ` [PATCH net-next 14/17] drdb: Send an entire bio in a single sendmsg David Howells
2023-06-16 16:12 ` [Drbd-dev] " David Howells
2023-06-16 16:12 ` [PATCH net-next 15/17] iscsi: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage David Howells
2023-06-16 16:12 ` [PATCH net-next 16/17] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) David Howells
2023-06-16 16:12 ` David Howells
2023-06-16 16:12 ` David Howells
2023-06-16 16:12 ` David Howells
2023-06-16 16:13 ` [PATCH net-next 17/17] net: Kill MSG_SENDPAGE_NOTLAST David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI26hJuixlQHOjk4@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexander.duyck@gmail.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.