From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Zhi Wang <zhi.wang.linux@gmail.com>
Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
Date: Wed, 7 Jun 2023 17:34:40 +0800 [thread overview]
Message-ID: <ZIBPMHS9xHL9PgH0@debian-scheme> (raw)
In-Reply-To: <878rd4hmvk.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On 2023.05.31 12:27:11 +0300, Jani Nikula wrote:
> On Wed, 31 May 2023, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > On 2023.05.31 02:04:11 +0000, Zhi Wang wrote:
> >> Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
> >> commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
> >> gma_bottom in several functions to calculate the size of the command
> >> buffer. However, some of them are set but actually unused.
> >>
> >> When compiling the code with ccflags -Wunused-but-set-variable, gcc
> >> throws warnings.
> >>
> >> Remove unused variables to avoid the gcc warnings. Tested via compiling
> >> the code with ccflags -Wunused-but-set-variable.
> >>
> >> Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
> >> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> >> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> >> Cc: intel-gvt-dev@lists.freedesktop.org
> >> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> >> ---
> >
> > Good with me. I think I also caught this before but never send the change..
> > Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
>
> I'd like to pick this up via drm-intel-next if that's all right.
>
Sorry for missed this. Pls feel free to do so. I'll sync to check anything left in gvt tree.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-06-07 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
2023-05-31 5:39 ` Zhenyu Wang
2023-05-31 9:27 ` Jani Nikula
2023-06-07 9:34 ` Zhenyu Wang [this message]
2023-05-31 9:20 ` Andi Shyti
2023-05-31 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2) Patchwork
2023-06-02 17:02 ` Jani Nikula
2023-06-05 14:35 ` Jani Nikula
2023-06-08 8:14 ` Wang, Zhi A
2023-06-08 9:00 ` Jani Nikula
2023-06-08 9:04 ` Wang, Zhi A
2023-05-31 17:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-02 5:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIBPMHS9xHL9PgH0@debian-scheme \
--to=zhenyuw@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.