From: Peter Xu <peterx@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH V3] migration: simplify notifiers
Date: Wed, 7 Jun 2023 11:10:02 -0400 [thread overview]
Message-ID: <ZICdyhgXhvsBM5jM@x1n> (raw)
In-Reply-To: <1686148954-250144-1-git-send-email-steven.sistare@oracle.com>
On Wed, Jun 07, 2023 at 07:42:34AM -0700, Steve Sistare wrote:
> Pass the callback function to add_migration_state_change_notifier so
> that migration can initialize the notifier on add and clear it on
> delete, which simplifies the call sites. Shorten the function names
> so the extra arg can be added more legibly. Hide the global notifier
> list in a new function migration_call_notifiers, and make it externally
> visible so future live update code can call it.
>
> No functional change.
>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2023-06-07 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:42 [PATCH V3] migration: simplify notifiers Steve Sistare
2023-06-07 15:10 ` Peter Xu [this message]
2023-07-13 21:34 ` Michael Galaxy
2023-10-18 18:16 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZICdyhgXhvsBM5jM@x1n \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.