From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Scally <dan.scally@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 15/28] media: ov2680: Add support for 19.2 MHz clock
Date: Wed, 7 Jun 2023 23:53:52 +0300 [thread overview]
Message-ID: <ZIDuYN5Zmh2ZzPBc@smile.fi.intel.com> (raw)
In-Reply-To: <20230607164712.63579-16-hdegoede@redhat.com>
On Wed, Jun 07, 2023 at 06:46:59PM +0200, Hans de Goede wrote:
> Most x86/ACPI boards use the ov2680 with a 19.2 MHz xvclk,
> rather then the expected 24MHz, add support for this.
>
> Compensate for the lower clk by setting a higher PLL multiplier
> of 69 when using 19.2 MHz vs the default multiplier of 55 for
> a 24MHz xvclk.
...
> @@ -720,12 +736,19 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
I believe this call is solely the part of the ->probe() flow, hence...
...
> + if (i == ARRAY_SIZE(ov2680_xvclk_freqs)) {
> + dev_err(dev, "unsupported xvclk frequency %d Hz\n", sensor->xvclk_freq);
> return -EINVAL;
return dev_err_probe(...);
?
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-07 20:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 16:46 [PATCH 00/28] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Hans de Goede
2023-06-07 16:46 ` [PATCH 01/28] media: ov2680: Remove auto-gain and auto-exposure controls Hans de Goede
2023-06-08 12:41 ` Sakari Ailus
2023-06-12 6:53 ` Dan Scally
2023-06-12 7:44 ` Hans de Goede
2023-06-12 7:59 ` Dan Scally
2023-06-12 9:57 ` Andy Shevchenko
2023-06-12 11:30 ` Dan Scally
2023-06-07 16:46 ` [PATCH 02/28] media: ov2680: Fix ov2680_bayer_order() Hans de Goede
2023-06-12 7:22 ` Dan Scally
2023-06-07 16:46 ` [PATCH 03/28] media: ov2680: Fix vflip / hflip set functions Hans de Goede
2023-06-12 7:32 ` Dan Scally
2023-06-12 8:06 ` Hans de Goede
2023-06-12 9:00 ` Laurent Pinchart
2023-06-07 16:46 ` [PATCH 04/28] media: ov2680: Use select VIDEO_V4L2_SUBDEV_API Hans de Goede
2023-06-12 8:20 ` Dan Scally
2023-06-12 8:57 ` Hans de Goede
2023-06-07 16:46 ` [PATCH 05/28] media: ov2680: Don't take the lock for try_fmt calls Hans de Goede
2023-06-08 12:44 ` Sakari Ailus
2023-06-08 12:48 ` Laurent Pinchart
2023-06-08 13:15 ` Sakari Ailus
2023-06-08 13:17 ` Hans de Goede
2023-06-07 16:46 ` [PATCH 06/28] media: ov2680: Add ov2680_fill_format() helper function Hans de Goede
2023-06-07 16:46 ` [PATCH 07/28] media: ov2680: Fix ov2680_set_fmt() which == V4L2_SUBDEV_FORMAT_TRY not working Hans de Goede
2023-06-07 16:46 ` [PATCH 08/28] media: Add MIPI CCI register access helper functions Hans de Goede
2023-06-07 20:22 ` Andy Shevchenko
2023-06-07 20:23 ` Andy Shevchenko
2023-06-07 16:46 ` [PATCH 09/28] media: ov2680: Convert to new CCI register access helpers Hans de Goede
2023-06-07 16:46 ` [PATCH 10/28] media: ov2680: Store dev instead of i2c_client in ov2680_dev Hans de Goede
2023-06-07 20:43 ` Andy Shevchenko
2023-06-07 16:46 ` [PATCH 11/28] media: ov2680: Check for "powerdown" GPIO con-id before checking for "reset" GPIO con-id Hans de Goede
2023-06-07 16:46 ` [PATCH 12/28] media: ov2680: Add runtime-pm support Hans de Goede
2023-06-07 16:46 ` [PATCH 13/28] media: ov2680: Drop is_enabled flag Hans de Goede
2023-06-07 16:46 ` [PATCH 14/28] media: ov2680: Add support for more clk setups Hans de Goede
2023-06-07 20:51 ` Andy Shevchenko
2023-06-07 16:46 ` [PATCH 15/28] media: ov2680: Add support for 19.2 MHz clock Hans de Goede
2023-06-07 20:53 ` Andy Shevchenko [this message]
2023-06-07 16:47 ` [PATCH 16/28] media: ov2680: Add endpoint matching support Hans de Goede
2023-06-07 16:47 ` [PATCH 17/28] media: ov2680: Add support for ACPI enumeration Hans de Goede
2023-06-07 20:57 ` Andy Shevchenko
2023-06-07 16:47 ` [PATCH 18/28] media: ov2680: Fix ov2680_enum_frame_interval() Hans de Goede
2023-06-07 16:47 ` [PATCH 19/28] media: ov2680: Annotate the per mode register setting lists Hans de Goede
2023-06-07 16:47 ` [PATCH 20/28] media: ov2680: Add ov2680_mode struct Hans de Goede
2023-06-07 16:47 ` [PATCH 21/28] media: ov2680: Make setting the mode algorithm based Hans de Goede
2023-06-07 16:47 ` [PATCH 22/28] media: ov2680: Add an __ov2680_get_pad_format() helper function Hans de Goede
2023-06-07 16:47 ` [PATCH 23/28] media: ov2680: Implement selection support Hans de Goede
2023-06-07 21:01 ` Andy Shevchenko
2023-06-07 21:04 ` Andy Shevchenko
2023-06-07 16:47 ` [PATCH 24/28] media: ov2680: Fix exposure and gain ctrls range and default value Hans de Goede
2023-06-07 16:47 ` [PATCH 25/28] media: ov2680: Add a bunch of register tweaks Hans de Goede
2023-06-07 16:47 ` [PATCH 26/28] media: ov2680: Add g_skip_frames op support Hans de Goede
2023-06-07 17:04 ` Laurent Pinchart
2023-06-07 17:49 ` Hans de Goede
2023-06-07 16:47 ` [PATCH 27/28] media: ov2680: Drop unnecessary pad checks Hans de Goede
2023-06-07 16:47 ` [PATCH 28/28] media: ov2680: Read and log sensor revision during probe Hans de Goede
2023-06-09 9:37 ` [PATCH 00/28] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Sakari Ailus
2023-06-09 14:28 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIDuYN5Zmh2ZzPBc@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.