From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 5/5] gitlab: support disabling job auto-run in upstream
Date: Thu, 8 Jun 2023 12:42:23 +0100 [thread overview]
Message-ID: <ZIG+n/NQG0auGL+w@redhat.com> (raw)
In-Reply-To: <bae4ecb4-b03f-e1c4-d5cf-de3b591fe36a@linaro.org>
On Fri, May 26, 2023 at 09:04:34AM -0700, Richard Henderson wrote:
> On 5/26/23 03:19, Daniel P. Berrangé wrote:
> > + # Upstream pipeline jobs start automatically unless told not to
> > + # by setting QEMU_CI=1
> > + - if: '$QEMU_CI == "1" && $CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM && $CI_COMMIT_BRANCH =~/staging/'
> > + when: manual
> > + variables:
> > + QEMU_CI_CONTAINER_TAG: $CI_COMMIT_REF_SLUG
>
> So.. in this case we don't want 'latest' for 'staging' because we may not
> run all jobs? Or should this have checked staging-X.Y, since the following
> rule will handle 'staging'?
Yes, this was a mistake. My original v1 was in fact correct.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-06-08 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 10:19 [PATCH v2 0/5] gitlab: improvements to handling of stable staging branches Daniel P. Berrangé
2023-05-26 10:19 ` [PATCH v2 1/5] gitlab: centralize the container tag name Daniel P. Berrangé
2023-05-26 10:19 ` [PATCH v2 2/5] gitlab: allow overriding name of the upstream repository Daniel P. Berrangé
2023-05-26 15:58 ` Richard Henderson
2023-05-26 10:19 ` [PATCH v2 3/5] gitlab: stable staging branches publish containers in a separate tag Daniel P. Berrangé
2023-05-26 15:59 ` Richard Henderson
2023-05-26 10:19 ` [PATCH v2 4/5] gitlab: avoid extra pipelines for tags and stable branches Daniel P. Berrangé
2023-05-26 16:00 ` Richard Henderson
2023-05-26 10:19 ` [PATCH v2 5/5] gitlab: support disabling job auto-run in upstream Daniel P. Berrangé
2023-05-26 16:04 ` Richard Henderson
2023-06-08 11:42 ` Daniel P. Berrangé [this message]
2023-05-30 7:36 ` [PATCH v2 0/5] gitlab: improvements to handling of stable staging branches Michael Tokarev
2023-05-30 10:56 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIG+n/NQG0auGL+w@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.