From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB0D5C7EE25 for ; Fri, 9 Jun 2023 07:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686294058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=X/KWuSmq7Dlyj9pQOJilwqodBQsIdxPtAEanycfUljg=; b=Vz3V4bxX6V0zKFHs8XgOBBQpoqts5cKncIB4rcVs81Rae4kWIYUXivxanUy03dXsxwx0V6 y6gRsaT5fKbYeMJsNxcTSH1CuusRA0ORHpji2hUoof6813ShXUQfERnkavBJzzNe0RQ/EW whlDMgHfzxKQuNczqFOiCr1dKCzZ4rM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-1szvA9-SPVKMFZW7BsSL4Q-1; Fri, 09 Jun 2023 03:00:55 -0400 X-MC-Unique: 1szvA9-SPVKMFZW7BsSL4Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08030185A791; Fri, 9 Jun 2023 07:00:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA3D5C16044; Fri, 9 Jun 2023 07:00:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CE4C519451C0; Fri, 9 Jun 2023 07:00:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3F8E4194658C for ; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 25F609E94; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E2039E93 for ; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2B5F801182 for ; Thu, 8 Jun 2023 09:44:25 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-sZUhAUd0MfSLb9_XymtsAw-1; Thu, 08 Jun 2023 05:44:24 -0400 X-MC-Unique: sZUhAUd0MfSLb9_XymtsAw-1 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-30c55d2b9f3so278068f8f.2 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=G5Cwlgab8rZm8iNhCUzHNpbdM45tjKvmayqxXLbaCJ21sxyq17RNahRXeYLol9PVIi 2ihwfXONl5WlAxWvfQSEBqaFSAAOVbdISQX+6ugpHjIIovNZGhlzc+vlpoMBwDhD/Tx1 WsBDZ7EEbRIwf3B2sD0cFw+3z4Nx7p+MQqMHXQzxChgWWiR2aLEVaUYRtIqYJkZY0bqm i2UmkaVb5qY0sW7qJMI/Kb4TPUz6aY36KM1EguFa0U13+qv/4r5WQXMLr57LT99thTz3 tfNM65+wQeKY0RQGatX2SeQ2ucCBsh0CTAdvH+IJZafLPYgLVn1+dng6615lGdRoFZtd 5n3Q== X-Gm-Message-State: AC+VfDxfuDQmIMAyLTsS9T91etGoKSb/gvyMfWlL/9hQXSTDNQk4/Ohl bOCV0NUGh3trxr7miLKYnC3Dpg== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 In-Reply-To: <20230608090444.GA15075@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mailman-Approved-At: Fri, 09 Jun 2023 07:00:46 +0000 Subject: Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: philpotter.co.uk Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD52DC7EE29 for ; Thu, 8 Jun 2023 09:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236035AbjFHJog (ORCPT ); Thu, 8 Jun 2023 05:44:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235960AbjFHJoe (ORCPT ); Thu, 8 Jun 2023 05:44:34 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26B7F26B3 for ; Thu, 8 Jun 2023 02:44:24 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f736e0c9a8so2217695e9.2 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=yaY1SeETpr1491wAArwoEz9AJZvZ5z5Oelfq8FTwZjv5Pt/tYo5/JbhJmlnsdXccgT rV+izm1qoxfwqsvCOevTNpa9AXiPp34leL/teWpFI8DnWj2gT9oTkJf5RM1JedYJsqOR dOTz2gvKJANj4eEOoND3rs/e3YQmKzzRMznHOfQHFfxuyaer9zt098pnWbKtUtWgrjpL rngkJTI/oyNl1h5w6WjYslic/vZHxQYsDYNvUly4Suef2mFO3KaGuI4pOX3o87LWbC1v fP5qRuJh7sd0u5OqO4m/B3exo8izpU2YK4CbQWdtPhbZm6I3/7vshaMygPH9B4aEMU3h 0vHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=Aaa2ZWZC02Vw7ZXaNPTPJop3V4cg7SA6/tvK406LF55qIahUncozecqR6EeDl9yOrU RAADCl/IdrjWW2qIuAh1YR6Ffkym/93B22pRQrd1Bfry1T4ndX0iVKx8JfU9THCi8ySO GZly6LpyDDtWey1fiF8T49R4Rj9T31EQ/HD8pa2+KBxAM9q4wCMla2Ch3E9z4Kls1u9n h9pzrWU3O65r/zAjJxJt5sjWi5GryMZf86nc6tnVavdVqmsMLhtnaCP9mwAI5izC5o9J Y7NDtLd7GtEySwa6UrI5IuA+pnBpsrXQ0kDN6KcCdE9D0OmFrxwuhhDV3HPPPRaq30kW pmxA== X-Gm-Message-State: AC+VfDwuM7c31HTYTT4/tAMTd9r6CXen//P25vyszznYaT1fTJx2UKXk oDmOpiU90UaX2vSSTXPe/bxVMA== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B724EC7EE29 for ; Thu, 8 Jun 2023 09:51:39 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q7CIr-000614-89; Thu, 08 Jun 2023 09:51:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q7CIq-00060y-F3 for linux-f2fs-devel@lists.sourceforge.net; Thu, 08 Jun 2023 09:51:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=kcOwGU1KPtY5qE22XbAHDZxYAx u02ZW18JneZH9H2m+s6SLb8UiMBl9riThVZ9u/SbMw0KlKMHVuw6Ypp4cjAcR0UCkL+rHnMWtduFC PV6GTxKYXhnfkgtoHlqyhsgE3kZB3g3NiuMSw3nID7WPmQlvX/RWsVexcO8Z0zwVjr7o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=SeH+mBamRzIN5+alQBpTJ6FWAb jgaSROKSp/dVudtNmHmL68DdaiUhVE/xWKt0Ielg/pgROlWxU9R5zYd7hrNtpo54Apr/8oGozs7fb X/L5ID+IAuqtXGXlqyILpAoudi5nm/txnTG3q3EwTzxzgYH8o8OlB9XdJc9XnrsJ7wi4=; Received: from mail-lj1-f169.google.com ([209.85.208.169]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1q7CIm-00Eade-Iz for linux-f2fs-devel@lists.sourceforge.net; Thu, 08 Jun 2023 09:51:36 +0000 Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2b1c30a1653so3432161fa.2 for ; Thu, 08 Jun 2023 02:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217886; x=1688809886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=FFq9AOBlooH5uGiOo4u0Mw6JSyvszVEwuY7y/MTzYJN6TwrDklEr6bPXExElD4Xycx tXPeOqcvbGuNN3rmjBC+RvOmuth1JfdbA8tUiv1ePcRJ1BWsL6R/vDrDK7vQ99uFEo4o P0msyHIhb38U5rItg9IIC5lbYH3YFrMMvyDoSouyJkOscWcz2ajYaI2VsLmKi1i2Wu1A xfK5Y1EL9zkcziZ9rUgSHf4qyMElbPJX9uwt+J+R+77TEc6zLoKb0Ju5rRJWNEu2zXSh b6X4WfCkCUSqt28yzVj7p1qCzURhMvhQxAzsIEmGeZjFBvqId0lPThd4hz2d1zkUbxDP FiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217886; x=1688809886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=a2eTr4etv+s/EEy8LJDOAyU+TAqueQfTCWqcpv8IhgQxTz0WXe+lrTbUgS2wHf4kgB CWZ0KeKtPhE0WA1Zu/C4gc/YkOsuwW5Ygaba5v8JYKyvmW2QeZY+VOR7jGf0qANOzzKz KhHqb5L7y9+9c23wsRjTLDQo/ALrL8oO+Xf9cPuZUG9xUp6Rt5GtLPbeEMnkT3wcCOUD LULAwDzp+rs2nGnzKIJmhvnR2lC1Z5WIy6ZuVf0qo7bYtC/ifhnL+QXVfufZlQipuDsm z+DZ+qYnLJjzX4DIgTOH6vsBMupljPRRUTOftq4B3ZOM/CRxze6plDMcsVD8naCQr31S Pocg== X-Gm-Message-State: AC+VfDxLaALz6pgiCOmokrC0h8+LKf4yymP2CMYQ6PCN3aceeQk7OB3J SCkcac1Y4r8aVXwf5DGvEPiBpgzEJs1X1P43Gn0WAm9J X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> X-Headers-End: 1q7CIm-00Eade-Iz Subject: Re: [f2fs-dev] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Potter Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Date: Thu, 8 Jun 2023 10:44:20 +0100 Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UML8h5O2z3O+JsvV9eYFHHAW8xW5xKd47xLX2aGhag4=; b=txX+XHuWjGxbWY CdKeIjfF5B7faiOk9A/BJ3/6I0/SXlKIN/vYG5fJAesh3WRyU/vQEjKV++TJIxUHVP4s+b5Us/H2v bbA+9Q2lfnWrvYPWrE1Ree69WNDUqQo196J4kAAvht6pQFleOZsfSXL8mdnevH3Ls63Xp/KVCkHFd cHpQSrfqYNMv0Ewvgf1ESvhnBQY2qcn3qmTtkta60XiiDwfxPzhs/Lo5rr9lm4a+prvlDSAuSX7U0 1Ouph1ffznqDGViDcZSqS6TmdyH3KEf1OSiMEoYCW4Ywd9e3tUAFZxjtN8aCtIq8wqYS4dtNt2CJj PRB8b5gdDIa9vIjYGMrQ==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=yaY1SeETpr1491wAArwoEz9AJZvZ5z5Oelfq8FTwZjv5Pt/tYo5/JbhJmlnsdXccgT rV+izm1qoxfwqsvCOevTNpa9AXiPp34leL/teWpFI8DnWj2gT9oTkJf5RM1JedYJsqOR dOTz2gvKJANj4eEOoND3rs/e3YQmKzzRMznHOfQHFfxuyaer9zt098pnWbKtUtWgrjpL rngkJTI/oyNl1h5w6WjYslic/vZHxQYsDYNvUly4Suef2mFO3KaGuI4pOX3o87LWbC1v fP5qRuJh7sd0u5OqO4m/B3exo8izpU2YK4CbQWdtPhbZm6I3/7vshaMygPH9B4aEMU3h 0vHQ== Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+glud-user-mode-linux-devel=m.gmane-mx.org@lists.infradead.org To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECA58C7EE23 for ; Thu, 8 Jun 2023 09:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=60umfaVn7Y6cpgTcjhEAlzii7TqM2P5at4sT294VbEk=; b=jrjSpcKsHfaj6j Rvjp2HQHB6PbsJAKjPpoDE1ntg2aSymesPvU5ob5akHnxUMFRGu1Qmto4Mc1NP8BCbZ5O/qqGczOO tEZVUSIMyzQAmOWnisvx1pZ5gaP4v/vBfkUP9L2Ux933lKiMUrIWsibILR2DixUUFS5mpRccOcGCl v3n2do/YJB4pC7fBif5WxI+UTWj4CIx7IFnkjtfPIiBQNOwO/YMn/WNpMzoaQOSa7CCEsRNYstPkC AwkRPTsyKjPL4KFn1wC448rFuf4z9x7rAEZrXHoTaPBgtoUAbh5X0Q54n8NeZjaOG/46hpXc31r1q GA6r40znVHDXo9ISZSVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBw-008jBB-1y; Thu, 08 Jun 2023 09:44:28 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBs-008j9W-2J for linux-mtd@lists.infradead.org; Thu, 08 Jun 2023 09:44:27 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-30af56f5f52so280544f8f.1 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=yaY1SeETpr1491wAArwoEz9AJZvZ5z5Oelfq8FTwZjv5Pt/tYo5/JbhJmlnsdXccgT rV+izm1qoxfwqsvCOevTNpa9AXiPp34leL/teWpFI8DnWj2gT9oTkJf5RM1JedYJsqOR dOTz2gvKJANj4eEOoND3rs/e3YQmKzzRMznHOfQHFfxuyaer9zt098pnWbKtUtWgrjpL rngkJTI/oyNl1h5w6WjYslic/vZHxQYsDYNvUly4Suef2mFO3KaGuI4pOX3o87LWbC1v fP5qRuJh7sd0u5OqO4m/B3exo8izpU2YK4CbQWdtPhbZm6I3/7vshaMygPH9B4aEMU3h 0vHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=ix0ycQH0VyZhqWirHXIr6+pnQ7IdJhw8zNpYZeKC77o1n1B9SKUx+USZqq/1CiTGdD sAQvMABpQvnnW+fR0fUJdvlWJPSZ6wHx+W+lKYiqXDje6poVQSO5RAHh3Vn6jiZOirGI MPug0YC1oflxfBIvI+2W5jLIL1wDoYh85WDn7mtYYBcvzjGqZPTk5PA6ThsBJHvNCzJm WQudRNZdGyGg9rcDEOxGbdtDjZ5/gBJYERgVrvVFcL14XB4R2fpN997MR9n2cSm4NXvq IeAaQGcGv8dZqzZ14GcUWcpWiuBTsSHWUI6sbvT52Q6equURpeF/hFLh3q5gu6m7VxHz lbQQ== X-Gm-Message-State: AC+VfDxMdcoMzX4tb9v47rQwsxBUcJ4lUIvgiNXxwSgUMil5gMjc6p6O DmEI5ZetH+AFwNJpweKT4GPfCA== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_024424_755394_B08E1B48 X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC06CC7EE45 for ; Thu, 8 Jun 2023 09:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UML8h5O2z3O+JsvV9eYFHHAW8xW5xKd47xLX2aGhag4=; b=txX+XHuWjGxbWY CdKeIjfF5B7faiOk9A/BJ3/6I0/SXlKIN/vYG5fJAesh3WRyU/vQEjKV++TJIxUHVP4s+b5Us/H2v bbA+9Q2lfnWrvYPWrE1Ree69WNDUqQo196J4kAAvht6pQFleOZsfSXL8mdnevH3Ls63Xp/KVCkHFd cHpQSrfqYNMv0Ewvgf1ESvhnBQY2qcn3qmTtkta60XiiDwfxPzhs/Lo5rr9lm4a+prvlDSAuSX7U0 1Ouph1ffznqDGViDcZSqS6TmdyH3KEf1OSiMEoYCW4Ywd9e3tUAFZxjtN8aCtIq8wqYS4dtNt2CJj PRB8b5gdDIa9vIjYGMrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBw-008jB3-0d; Thu, 08 Jun 2023 09:44:28 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBs-008j9X-2I for linux-um@lists.infradead.org; Thu, 08 Jun 2023 09:44:25 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-307d58b3efbso285745f8f.0 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=yaY1SeETpr1491wAArwoEz9AJZvZ5z5Oelfq8FTwZjv5Pt/tYo5/JbhJmlnsdXccgT rV+izm1qoxfwqsvCOevTNpa9AXiPp34leL/teWpFI8DnWj2gT9oTkJf5RM1JedYJsqOR dOTz2gvKJANj4eEOoND3rs/e3YQmKzzRMznHOfQHFfxuyaer9zt098pnWbKtUtWgrjpL rngkJTI/oyNl1h5w6WjYslic/vZHxQYsDYNvUly4Suef2mFO3KaGuI4pOX3o87LWbC1v fP5qRuJh7sd0u5OqO4m/B3exo8izpU2YK4CbQWdtPhbZm6I3/7vshaMygPH9B4aEMU3h 0vHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=f/3lEfF2yp19gyUHYAUbuzjOS3rRHHfw2roSyjAEuGjUXvJlIGvXZVgkCVI/uuTedF sunGoqyIBfakytPLkOh8eN6cJmG/Zmi7dIqIKYThQyJz4UWI8jXQjwTWxDKZwyfRfaIt QLlwGyCKkPDQoXShrIo6Bw+WLQZYERDbupvwCdk4pl/ixjTkwFQ1QCpRay9ZAM/+XD9R qtzXcwNX08v5JCn+Of+OmbBfzWznEWpWKf5z9kwKzqjj5cjqsfQhb2wJR35HyYMI0Cni +9HqD+nM8MXLWwFfEN95Wo0p2wmF4T9Kev6iLagu1oop+I9p4hlVcapei9tJBEApheaM Y2Qg== X-Gm-Message-State: AC+VfDypjWrhTf+Tn1FqhErQMuOk1faY4xvCwePfCNAEUGJPDLhjmNr0 Cvq/h5N7RO1+FMFM9/67PorY1w== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_024424_751960_1CFA1C26 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um