From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA802C7EE25 for ; Thu, 8 Jun 2023 16:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vLJJPMXLR0Di4X/GCayAz9rPIVM6L53DwHx9pmTx8KU=; b=b6hhXRtzvlJfhn 4nHL9IFtO94vscv9RzgaW6O6zRuQiyyB+Asier5F5j/uTZo85RCyGbrKeDlefARODOOqdTQZvxqTf UF+riRHKUrhAVFitwd/WfkgtfqzvvF/dI/SsPzb8EkaQEW/stor8XskSaXbpCxzCX2WgQc/Q09e0E K7rlA/9/NGD5UOvisYlDOrYIHZulgR/lFGvAQEsbkQtaMTYn7ultzXt2k9E8/SsjwXn3ki/5t8KvV l7gpOJlt4YybZK9xeJND6NeB/Cqh6uUTSfTRxKNqikYvbodBV1LaQMHav0UdkZKrIcwrOseljb3GK lmfWeDjj5O/jkR3QEv5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7Ic8-009uap-3C; Thu, 08 Jun 2023 16:35:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7Ic5-009uJH-1P for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 16:35:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mfnbtev31uFyEY3OhGP9nDmwVwNJ/fmqpOtxac0yHZI=; b=bT5s0Vb6l+/HbrzHFoe+F1K3dy OdYtl/xh4w6NTkuwm3zmrZb4syiVtYZ+1vWvLpaNmUDmESD6juzgdUsRzvlI+yRj+vUf54ssuYaU9 aiZ1m5N90dSlwVgHxibwaWSIRMAd+TmgdQfWD38sDLGa1QRJgtzhoG0PhUs6i0dDP7Kbh1LQyyUeG lGwoDz+IS+8oJEZnN5KT0rfHtP/CuPWHuu0mgiMc0qJHJw17G87cOgOjQzS+DLTurelyJuot0vV75 VYHoVsn8wnHMfmOk39BJAPBu3harCOQYhuSY0BnbVIsmA+vMEBYZh6Sxoa2z1fgx/Zlq/UJdfGDnj 10Utx6WA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55434) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7Ia3-0000gL-EG; Thu, 08 Jun 2023 17:33:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q7Ia2-0000xd-LI; Thu, 08 Jun 2023 17:33:46 +0100 Date: Thu, 8 Jun 2023 17:33:46 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com, Vladimir Oltean Subject: Re: [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word Message-ID: References: <20230608163415.511762-1-maxime.chevallier@bootlin.com> <20230608163415.511762-3-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230608163415.511762-3-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_093553_485889_D13A2B6A X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 08, 2023 at 06:34:14PM +0200, Maxime Chevallier wrote: > Q-USGMII is a derivative of USGMII, that uses a specific formatting for > the control word. The layout is close to the USXGMII control word, but > doesn't support speeds over 1Gbps. Use a dedicated decoding logic for > the USGMII control word, re-using USXGMII definitions with a custom mask > and only considering 10/100/1000 speeds Seems to be a duplicate patch? Please see my comments on the other submission of this patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A49C7EE2E for ; Thu, 8 Jun 2023 16:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233833AbjFHQfb (ORCPT ); Thu, 8 Jun 2023 12:35:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235844AbjFHQeh (ORCPT ); Thu, 8 Jun 2023 12:34:37 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCFF3592; Thu, 8 Jun 2023 09:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mfnbtev31uFyEY3OhGP9nDmwVwNJ/fmqpOtxac0yHZI=; b=bT5s0Vb6l+/HbrzHFoe+F1K3dy OdYtl/xh4w6NTkuwm3zmrZb4syiVtYZ+1vWvLpaNmUDmESD6juzgdUsRzvlI+yRj+vUf54ssuYaU9 aiZ1m5N90dSlwVgHxibwaWSIRMAd+TmgdQfWD38sDLGa1QRJgtzhoG0PhUs6i0dDP7Kbh1LQyyUeG lGwoDz+IS+8oJEZnN5KT0rfHtP/CuPWHuu0mgiMc0qJHJw17G87cOgOjQzS+DLTurelyJuot0vV75 VYHoVsn8wnHMfmOk39BJAPBu3harCOQYhuSY0BnbVIsmA+vMEBYZh6Sxoa2z1fgx/Zlq/UJdfGDnj 10Utx6WA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55434) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7Ia3-0000gL-EG; Thu, 08 Jun 2023 17:33:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q7Ia2-0000xd-LI; Thu, 08 Jun 2023 17:33:46 +0100 Date: Thu, 8 Jun 2023 17:33:46 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com, Vladimir Oltean Subject: Re: [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word Message-ID: References: <20230608163415.511762-1-maxime.chevallier@bootlin.com> <20230608163415.511762-3-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608163415.511762-3-maxime.chevallier@bootlin.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 06:34:14PM +0200, Maxime Chevallier wrote: > Q-USGMII is a derivative of USGMII, that uses a specific formatting for > the control word. The layout is close to the USXGMII control word, but > doesn't support speeds over 1Gbps. Use a dedicated decoding logic for > the USGMII control word, re-using USXGMII definitions with a custom mask > and only considering 10/100/1000 speeds Seems to be a duplicate patch? Please see my comments on the other submission of this patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!