Re: [OE-Core][PATCH v3 4/4] core-image-ptest: append ptest directory to artifacts list

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Fri, Jun 09, 2023 at 08:48:02AM +0200, Alexis Lothor� via lists.openembedded.org wrote:
> From: Alexis Lothor� <alexis.lothore@bootlin.com>
> 
> TESTIMAGE_FAILED_QA_ARTIFACTS is defined in testimage.bbclass with a
> minimal list of files to retrieve when a test fail. By appending the ptest
> directory only in core-image-ptest.bb, thanks to multiconfig feature used
> in the recipe, only failing ptests will lead to corresponding ptest
> artifacts retrieval, instead of all ptests artifacts retrieval.
> 
> Signed-off-by: Alexis Lothor� <alexis.lothore@bootlin.com>
> ---
>  meta/recipes-core/images/core-image-ptest.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/images/core-image-ptest.bb b/meta/recipes-core/images/core-image-ptest.bb
> index 90c26641ba3a..e1be81bb2666 100644
> --- a/meta/recipes-core/images/core-image-ptest.bb
> +++ b/meta/recipes-core/images/core-image-ptest.bb
> @@ -28,6 +28,7 @@ QB_MEM:virtclass-mcextend-lttng-tools = "-m 4096"
>  QB_MEM:virtclass-mcextend-python3-cryptography = "-m 4096"
>  
>  TEST_SUITES = "ping ssh parselogs ptest"
> +TESTIMAGE_FAILED_QA_ARTIFACTS:append=" ${libdir}/${MCNAME}/ptest"

Why not += ? Also, spaces around =.

If :append is used, bbappend in other layers can not easily override
this variable.

Cheers,

-Mikko