From: Simon Horman <simon.horman@corigine.com>
To: edward.cree@amd.com
Cc: linux-net-drivers@amd.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com,
Edward Cree <ecree.xilinx@gmail.com>,
netdev@vger.kernel.org, habetsm.xilinx@gmail.com,
Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Subject: Re: [PATCH v2 net-next 1/6] sfc: add fallback action-set-lists for TC offload
Date: Fri, 9 Jun 2023 11:37:20 +0200 [thread overview]
Message-ID: <ZILy0ObbkpbpgpfB@corigine.com> (raw)
In-Reply-To: <096d731b63e7edbec1a64283387ec5da378664c9.1686240142.git.ecree.xilinx@gmail.com>
On Thu, Jun 08, 2023 at 05:42:30PM +0100, edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> When offloading a TC encap action, the action information for the
> hardware might not be "ready": if there's currently no neighbour entry
> available for the destination address, we can't construct the Ethernet
> header to prepend to the packet. In this case, we still offload the
> flow rule, but with its action-set-list ID pointing at a "fallback"
> action which simply delivers the packet to its default destination (as
> though no flow rule had matched), thus allowing software TC to handle
> it. Later, when we receive a neighbouring update that allows us to
> construct the encap header, the rule will become "ready" and we will
> update its action-set-list ID in hardware to point at the actual
> offloaded actions.
> This patch sets up these fallback ASLs, but does not yet use them.
>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-09 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:42 [PATCH v2 net-next 0/6] sfc: TC encap actions offload edward.cree
2023-06-08 16:42 ` [PATCH v2 net-next 1/6] sfc: add fallback action-set-lists for TC offload edward.cree
2023-06-09 9:37 ` Simon Horman [this message]
2023-06-08 16:42 ` [PATCH v2 net-next 2/6] sfc: some plumbing towards TC encap action offload edward.cree
2023-06-09 9:35 ` Simon Horman
2023-06-08 16:42 ` [PATCH v2 net-next 3/6] sfc: add function to atomically update a rule in the MAE edward.cree
2023-06-09 9:35 ` Simon Horman
2023-06-08 16:42 ` [PATCH v2 net-next 4/6] sfc: MAE functions to create/update/delete encap headers edward.cree
2023-06-09 9:36 ` Simon Horman
2023-06-08 16:42 ` [PATCH v2 net-next 5/6] sfc: neighbour lookup for TC encap action offload edward.cree
2023-06-09 9:37 ` Simon Horman
2023-06-09 10:25 ` Pieter Jansen van Vuuren
2023-06-08 16:42 ` [PATCH v2 net-next 6/6] sfc: generate encap headers for TC offload edward.cree
2023-06-09 9:36 ` Simon Horman
2023-06-09 10:29 ` Pieter Jansen van Vuuren
2023-06-10 7:21 ` [PATCH v2 net-next 0/6] sfc: TC encap actions offload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZILy0ObbkpbpgpfB@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pieter.jansen-van-vuuren@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.