From: andy.shevchenko@gmail.com
To: Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Subject: Re: [libgpiod][PATCH 2/2] bindings: cxx: examples: fix potential glitch in gpiosetcxx
Date: Fri, 9 Jun 2023 23:19:54 +0300 [thread overview]
Message-ID: <ZIOJaopktUw8Rh1p@surfacebook> (raw)
In-Reply-To: <20230609153607.133379-3-warthog618@gmail.com>
Fri, Jun 09, 2023 at 11:36:07PM +0800, Kent Gibson kirjoitti:
> gpiosetcxx requests lines without setting their output value, and so
> sets them all inactive, and subsequently sets them to their requested
> value. This can result in glitches on lines which were active and
> are set active.
>
> As this is example code, it is also important to demonstrate that the
> output value can be set by the request itself.
>
> Request the lines with the correct output values set in the request
> itself.
Same question about commenting in the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-09 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 15:36 [libgpiod][PATCH 0/2] fix potential glitches in bindings example gpiosets Kent Gibson
2023-06-09 15:36 ` [libgpiod][PATCH 1/2] bindings: python: examples: fix potential glitch in gpioset.py Kent Gibson
2023-06-09 20:18 ` andy.shevchenko
2023-06-12 14:26 ` Bartosz Golaszewski
2023-06-12 14:44 ` Andy Shevchenko
2023-06-12 14:53 ` Kent Gibson
2023-06-12 14:58 ` Bartosz Golaszewski
2023-06-12 14:27 ` Bartosz Golaszewski
2023-06-09 15:36 ` [libgpiod][PATCH 2/2] bindings: cxx: examples: fix potential glitch in gpiosetcxx Kent Gibson
2023-06-09 20:19 ` andy.shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-12 14:56 [libgpiod][PATCH 0/2] bindings: cxx: " Bartosz Golaszewski
2023-06-12 14:56 ` [libgpiod][PATCH 2/2] bindings: cxx: examples: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIOJaopktUw8Rh1p@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.