All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Petr Machata <petrm@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, kernel@pengutronix.de, vadimp@nvidia.com
Subject: Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
Date: Mon, 12 Jun 2023 11:20:31 +0300	[thread overview]
Message-ID: <ZIbVT+1PgXtElVs3@shredder> (raw)
In-Reply-To: <20230612072222.839292-1-u.kleine-koenig@pengutronix.de>

On Mon, Jun 12, 2023 at 09:22:22AM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>

I assume it's intended for net-next.

> ---
>  drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> index 2c586c2308ae..41298835a11e 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> @@ -751,7 +751,7 @@ static void mlxsw_i2c_remove(struct i2c_client *client)
>  
>  int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)
>  {
> -	i2c_driver->probe_new = mlxsw_i2c_probe;
> +	i2c_driver->probe = mlxsw_i2c_probe;
>  	i2c_driver->remove = mlxsw_i2c_remove;
>  	return i2c_add_driver(i2c_driver);
>  }
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> -- 
> 2.39.2
> 

  reply	other threads:[~2023-06-12  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  7:22 [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe() Uwe Kleine-König
2023-06-12  8:20 ` Ido Schimmel [this message]
2023-06-12  9:50   ` Uwe Kleine-König
2023-06-12 11:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIbVT+1PgXtElVs3@shredder \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vadimp@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.