From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9F3C88CB5 for ; Mon, 12 Jun 2023 14:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232222AbjFLOAV (ORCPT ); Mon, 12 Jun 2023 10:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236492AbjFLN7x (ORCPT ); Mon, 12 Jun 2023 09:59:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ABE25198E; Mon, 12 Jun 2023 06:59:27 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA4FB1FB; Mon, 12 Jun 2023 07:00:10 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.27.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB8E63F71E; Mon, 12 Jun 2023 06:59:20 -0700 (PDT) Date: Mon, 12 Jun 2023 14:59:13 +0100 From: Mark Rutland To: Doug Anderson Cc: Petr Mladek , Andrew Morton , Matthias Kaehlcke , kgdb-bugreport@lists.sourceforge.net, Stephane Eranian , mpe@ellerman.id.au, Tzung-Bi Shih , Daniel Thompson , linuxppc-dev@lists.ozlabs.org, Sumit Garg , npiggin@gmail.com, davem@davemloft.net, Marc Zyngier , Stephen Boyd , sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu, Catalin Marinas , ravi.v.shankar@intel.com, Randy Dunlap , Pingfan Liu , Guenter Roeck , Lecopzer Chen , Ian Rogers , ito-yuichi@fujitsu.com, ricardo.neri@intel.com, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Will Deacon , Chen-Yu Tsai , linux-kernel@vger.kernel.org, Masayoshi Mizuma , Andi Kleen Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs Message-ID: References: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid> <20230519101840.v5.15.Ic55cb6f90ef5967d8aaa2b503a4e67c753f64d3a@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Mon, Jun 12, 2023 at 06:55:37AM -0700, Doug Anderson wrote: > Mark, > > On Mon, Jun 12, 2023 at 3:33 AM Mark Rutland wrote: > > > > On Fri, May 19, 2023 at 10:18:39AM -0700, Douglas Anderson wrote: > > > On arm64, NMI support needs to be detected at runtime. Add a weak > > > function to the perf hardlockup detector so that an architecture can > > > implement it to detect whether NMIs are available. > > > > > > Signed-off-by: Douglas Anderson > > > --- > > > While I won't object to this patch landing, I consider it part of the > > > arm64 perf hardlockup effort. I would be OK with the earlier patches > > > in the series landing and then not landing ${SUBJECT} patch nor > > > anything else later. > > > > FWIW, everything prior to this looks fine to me, so I reckon it'd be worth > > splitting the series here and getting the buddy lockup detector in first, to > > avoid a log-jam on all the subsequent NMI bits. > > I think the whole series has already landed in Andrew's tree, > including the arm64 "perf" lockup detector bits. I saw all the > notifications from Andrew go through over the weekend that they were > moved from an "unstable" branch to a "stable" one and I see them at: > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-nonmm-stable > > When I first saw Anderw land the arm64 perf lockup detector bits in > his unstable branch several weeks ago, I sent a private message to the > arm64 maintainers (yourself included) to make sure you were aware of > it and that it hadn't been caught in mail filters. I got the > impression that everything was OK. Is that not the case? Sorry; I'm slowly catching up with a backlog of email, and I'm just behind. Feel free to ignore this; sorry for the noise! If we spot anything going wrong in testing we can look at fixing those up. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC747C88CB4 for ; Mon, 12 Jun 2023 14:00:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qftcp0NTxz30Q4 for ; Tue, 13 Jun 2023 00:00:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=mark.rutland@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qftc0631Fz2yQB for ; Mon, 12 Jun 2023 23:59:58 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA4FB1FB; Mon, 12 Jun 2023 07:00:10 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.27.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB8E63F71E; Mon, 12 Jun 2023 06:59:20 -0700 (PDT) Date: Mon, 12 Jun 2023 14:59:13 +0100 From: Mark Rutland To: Doug Anderson Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs Message-ID: References: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid> <20230519101840.v5.15.Ic55cb6f90ef5967d8aaa2b503a4e67c753f64d3a@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ian Rogers , ito-yuichi@fujitsu.com, Lecopzer Chen , ravi.v.shankar@intel.com, Catalin Marinas , ricardo.neri@intel.com, Stephane Eranian , sparclinux@vger.kernel.org, Guenter Roeck , Will Deacon , Daniel Thompson , Andi Kleen , Marc Zyngier , Chen-Yu Tsai , Matthias Kaehlcke , kgdb-bugreport@lists.sourceforge.net, Masayoshi Mizuma , Petr Mladek , Tzung-Bi Shih , npiggin@gmail.com, Stephen Boyd , Pingfan Liu , linux-arm-kernel@lists.infradead.org, Sumit Garg , Randy Dunlap , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.o rg, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 12, 2023 at 06:55:37AM -0700, Doug Anderson wrote: > Mark, > > On Mon, Jun 12, 2023 at 3:33 AM Mark Rutland wrote: > > > > On Fri, May 19, 2023 at 10:18:39AM -0700, Douglas Anderson wrote: > > > On arm64, NMI support needs to be detected at runtime. Add a weak > > > function to the perf hardlockup detector so that an architecture can > > > implement it to detect whether NMIs are available. > > > > > > Signed-off-by: Douglas Anderson > > > --- > > > While I won't object to this patch landing, I consider it part of the > > > arm64 perf hardlockup effort. I would be OK with the earlier patches > > > in the series landing and then not landing ${SUBJECT} patch nor > > > anything else later. > > > > FWIW, everything prior to this looks fine to me, so I reckon it'd be worth > > splitting the series here and getting the buddy lockup detector in first, to > > avoid a log-jam on all the subsequent NMI bits. > > I think the whole series has already landed in Andrew's tree, > including the arm64 "perf" lockup detector bits. I saw all the > notifications from Andrew go through over the weekend that they were > moved from an "unstable" branch to a "stable" one and I see them at: > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-nonmm-stable > > When I first saw Anderw land the arm64 perf lockup detector bits in > his unstable branch several weeks ago, I sent a private message to the > arm64 maintainers (yourself included) to make sure you were aware of > it and that it hadn't been caught in mail filters. I got the > impression that everything was OK. Is that not the case? Sorry; I'm slowly catching up with a backlog of email, and I'm just behind. Feel free to ignore this; sorry for the noise! If we spot anything going wrong in testing we can look at fixing those up. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C38EBC88CB2 for ; Mon, 12 Jun 2023 13:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wNONrte3oKH18hcAnYuO+MRtr0d84i1jA0mgR8Fw9vE=; b=JPvSAR4P5Dyiqy 0r5d/icf36g0/gNYNX4v2XGtn/KWEl4+aa0ATvazdd1t7pg5bb/p2+jB5zudEsqR3UtPQWtGxKbjX uH8+2sYiQNAoKIzxWax0CgE16GHbDkjTi+qcF85vz5YRTorW7qN59qXnbTHmhnL9lxOO0ADagp3zG BrlIk5xdKSRD3Bi2mykz1adHMJZOpC1R88H20aGcu9ATFCn1jOcFYk+mrrEPhciPjGxo+TriLV5/K zBWqx8J6sJxIo5KK4xim9WJQI1WQSJPJMzKla3NW1PZ49SFdb/zclxOp4rR1GoZ8GUu3WN6NMHT35 DJhSWacsyPCqe1l71WIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8i4w-004DyX-3A; Mon, 12 Jun 2023 13:59:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8i4t-004DxB-1W for linux-arm-kernel@lists.infradead.org; Mon, 12 Jun 2023 13:59:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA4FB1FB; Mon, 12 Jun 2023 07:00:10 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.27.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB8E63F71E; Mon, 12 Jun 2023 06:59:20 -0700 (PDT) Date: Mon, 12 Jun 2023 14:59:13 +0100 From: Mark Rutland To: Doug Anderson Cc: Petr Mladek , Andrew Morton , Matthias Kaehlcke , kgdb-bugreport@lists.sourceforge.net, Stephane Eranian , mpe@ellerman.id.au, Tzung-Bi Shih , Daniel Thompson , linuxppc-dev@lists.ozlabs.org, Sumit Garg , npiggin@gmail.com, davem@davemloft.net, Marc Zyngier , Stephen Boyd , sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu, Catalin Marinas , ravi.v.shankar@intel.com, Randy Dunlap , Pingfan Liu , Guenter Roeck , Lecopzer Chen , Ian Rogers , ito-yuichi@fujitsu.com, ricardo.neri@intel.com, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Will Deacon , Chen-Yu Tsai , linux-kernel@vger.kernel.org, Masayoshi Mizuma , Andi Kleen Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs Message-ID: References: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid> <20230519101840.v5.15.Ic55cb6f90ef5967d8aaa2b503a4e67c753f64d3a@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_065927_611104_CF381A86 X-CRM114-Status: GOOD ( 23.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMTIsIDIwMjMgYXQgMDY6NTU6MzdBTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBNYXJrLAo+IAo+IE9uIE1vbiwgSnVuIDEyLCAyMDIzIGF0IDM6MzPigK9BTSBNYXJr IFJ1dGxhbmQgPG1hcmsucnV0bGFuZEBhcm0uY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBGcmksIE1h eSAxOSwgMjAyMyBhdCAxMDoxODozOUFNIC0wNzAwLCBEb3VnbGFzIEFuZGVyc29uIHdyb3RlOgo+ ID4gPiBPbiBhcm02NCwgTk1JIHN1cHBvcnQgbmVlZHMgdG8gYmUgZGV0ZWN0ZWQgYXQgcnVudGlt ZS4gQWRkIGEgd2Vhawo+ID4gPiBmdW5jdGlvbiB0byB0aGUgcGVyZiBoYXJkbG9ja3VwIGRldGVj dG9yIHNvIHRoYXQgYW4gYXJjaGl0ZWN0dXJlIGNhbgo+ID4gPiBpbXBsZW1lbnQgaXQgdG8gZGV0 ZWN0IHdoZXRoZXIgTk1JcyBhcmUgYXZhaWxhYmxlLgo+ID4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBEb3VnbGFzIEFuZGVyc29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4gPiA+IC0tLQo+ID4g PiBXaGlsZSBJIHdvbid0IG9iamVjdCB0byB0aGlzIHBhdGNoIGxhbmRpbmcsIEkgY29uc2lkZXIg aXQgcGFydCBvZiB0aGUKPiA+ID4gYXJtNjQgcGVyZiBoYXJkbG9ja3VwIGVmZm9ydC4gSSB3b3Vs ZCBiZSBPSyB3aXRoIHRoZSBlYXJsaWVyIHBhdGNoZXMKPiA+ID4gaW4gdGhlIHNlcmllcyBsYW5k aW5nIGFuZCB0aGVuIG5vdCBsYW5kaW5nICR7U1VCSkVDVH0gcGF0Y2ggbm9yCj4gPiA+IGFueXRo aW5nIGVsc2UgbGF0ZXIuCj4gPgo+ID4gRldJVywgZXZlcnl0aGluZyBwcmlvciB0byB0aGlzIGxv b2tzIGZpbmUgdG8gbWUsIHNvIEkgcmVja29uIGl0J2QgYmUgd29ydGgKPiA+IHNwbGl0dGluZyB0 aGUgc2VyaWVzIGhlcmUgYW5kIGdldHRpbmcgdGhlIGJ1ZGR5IGxvY2t1cCBkZXRlY3RvciBpbiBm aXJzdCwgdG8KPiA+IGF2b2lkIGEgbG9nLWphbSBvbiBhbGwgdGhlIHN1YnNlcXVlbnQgTk1JIGJp dHMuCj4gCj4gSSB0aGluayB0aGUgd2hvbGUgc2VyaWVzIGhhcyBhbHJlYWR5IGxhbmRlZCBpbiBB bmRyZXcncyB0cmVlLAo+IGluY2x1ZGluZyB0aGUgYXJtNjQgInBlcmYiIGxvY2t1cCBkZXRlY3Rv ciBiaXRzLiBJIHNhdyBhbGwgdGhlCj4gbm90aWZpY2F0aW9ucyBmcm9tIEFuZHJldyBnbyB0aHJv dWdoIG92ZXIgdGhlIHdlZWtlbmQgdGhhdCB0aGV5IHdlcmUKPiBtb3ZlZCBmcm9tIGFuICJ1bnN0 YWJsZSIgYnJhbmNoIHRvIGEgInN0YWJsZSIgb25lIGFuZCBJIHNlZSB0aGVtIGF0Ogo+IAo+IGh0 dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2FrcG0vbW0uZ2l0 L2xvZy8/aD1tbS1ub25tbS1zdGFibGUKPiAKPiBXaGVuIEkgZmlyc3Qgc2F3IEFuZGVydyBsYW5k IHRoZSBhcm02NCBwZXJmIGxvY2t1cCBkZXRlY3RvciBiaXRzIGluCj4gaGlzIHVuc3RhYmxlIGJy YW5jaCBzZXZlcmFsIHdlZWtzIGFnbywgSSBzZW50IGEgcHJpdmF0ZSBtZXNzYWdlIHRvIHRoZQo+ IGFybTY0IG1haW50YWluZXJzICh5b3Vyc2VsZiBpbmNsdWRlZCkgdG8gbWFrZSBzdXJlIHlvdSB3 ZXJlIGF3YXJlIG9mCj4gaXQgYW5kIHRoYXQgaXQgaGFkbid0IGJlZW4gY2F1Z2h0IGluIG1haWwg ZmlsdGVycy4gSSBnb3QgdGhlCj4gaW1wcmVzc2lvbiB0aGF0IGV2ZXJ5dGhpbmcgd2FzIE9LLiBJ cyB0aGF0IG5vdCB0aGUgY2FzZT8KClNvcnJ5OyBJJ20gc2xvd2x5IGNhdGNoaW5nIHVwIHdpdGgg YSBiYWNrbG9nIG9mIGVtYWlsLCBhbmQgSSdtIGp1c3QgYmVoaW5kLgoKRmVlbCBmcmVlIHRvIGln bm9yZSB0aGlzOyBzb3JyeSBmb3IgdGhlIG5vaXNlIQoKSWYgd2Ugc3BvdCBhbnl0aGluZyBnb2lu ZyB3cm9uZyBpbiB0ZXN0aW5nIHdlIGNhbiBsb29rIGF0IGZpeGluZyB0aG9zZSB1cC4KClRoYW5r cywKTWFyay4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK