From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E10AC88CB2 for ; Mon, 12 Jun 2023 17:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235701AbjFLRXs (ORCPT ); Mon, 12 Jun 2023 13:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbjFLRXq (ORCPT ); Mon, 12 Jun 2023 13:23:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC828B2; Mon, 12 Jun 2023 10:23:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 721F862905; Mon, 12 Jun 2023 17:23:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F868C433A1; Mon, 12 Jun 2023 17:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686590624; bh=num+HBDgMxiuiJVhhkLVPXPpTBWWc1dgJNLDNOGS0Fk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uE12zDMfqRoci4thscAdp3EhSwgKJovJnYvOw3krcV88NGXiZRfF9rOltrCAswAXN TfhY5m2ULY71VP3EtGag4nbFEWKPxzFyMuPG3QaaBg/FgP+axXyraqmxKkRVEr1jrU F66fBJdtR7u5XF+bUxf0nc+uNB6UiSdxpS8WPdPSdUngO54Nwdyul+O0NltvPBgBM8 TvC8+1fybwIMNUxG4m6semSiG+yDfRzznvXhkjSxhCVJnuQm8vMTm8aA0J1tYNM/j8 U+YEG8QI3Byfa1wCkMeiCHNt8OmLMklpSKeGCgZAzvJPIay/RL6ThyyfZw0zP4XgJK 1ODSUu14Pl9WA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D1BF540692; Mon, 12 Jun 2023 14:23:41 -0300 (-03) Date: Mon, 12 Jun 2023 14:23:41 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Suzuki K Poulose , "Naveen N. Rao" , Kan Liang , German Gomez , Ali Saidi , Jing Zhang , Athira Rajeev , Miguel Ojeda , ye xingchen , Liam Howlett , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , K Prateek Nayak , Changbin Du , Ravi Bangoria , Sean Christopherson , Andi Kleen , "Steinar H. Gunderson" , Yuan Can , Brian Robbins , liuwenyu , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org Subject: Re: [PATCH v2 26/26] perf hist: Fix srcline memory leak Message-ID: References: <20230608232823.4027869-1-irogers@google.com> <20230608232823.4027869-27-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Jun 12, 2023 at 07:46:14AM -0700, Ian Rogers escreveu: > On Mon, Jun 12, 2023 at 7:16 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Mon, Jun 12, 2023 at 11:13:59AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Jun 08, 2023 at 04:28:23PM -0700, Ian Rogers escreveu: > > > > srcline isn't freed if it is SRCLINE_UNKNOWN. Avoid strduping in this > > > > case as such strdups are redundant and leak memory. > > > > > > The patch is ok as its what the rest of the code is doing, i.e. strcmp() > > > to check if a srcline is the unknown one, but how about the following > > > patch on top of yours? > > > > [acme@quaco perf-tools-next]$ strings ~/bin/perf | grep '??:0' > > ??:0 > > SRCLINE_UNKNOWN ((char *) "??:0") > > [acme@quaco perf-tools-next]$ > > Agreed, the strcmps make me nervous as they won't distinguish heap > from a global meaning we could end up with things like pointers to > freed memory. The comparison with the global is always going to be > same imo. > > Acked-by: Ian Rogers Thanks, applied and added your Acked-by. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94F24C88CB2 for ; Mon, 12 Jun 2023 17:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CRi82CG4D3KEilaLODXhme32Uq5+LVpgpxiZsrSE+MQ=; b=v5Kkdhmt6fxE68 B+EbR4vqmLTSFjWrjjWhEGI59EUopB6zcYtRKYDPfTMLpWmBPCXhMgO8pkqa9y4X8wtEEb/dPeTQD ghJ2ZBOrzl54zObFxUXjIoPv0RrSYIQMpDLVVHbrZ87s2KQJElYsJ+0b8eoYNKSsaBaO6adjIX0dr Gm16jmeT4iIOYHLb+qrFl+THe2WdkkAPAKFvzrYh1rQmJec9tBDCWSap/73dhHW0YwFZjfex6tTXp wSt9Xi/W68piCInHHrFb1NbbrAEI2bAuUH439f6goJxVeoDTnw4t2beJRXhXe0ocvDn6Z5ECNZKs1 OyTL3h0o28m9DajeoCvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8lGf-004kEg-09; Mon, 12 Jun 2023 17:23:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8lGe-004kEM-0V for linux-arm-kernel@bombadil.infradead.org; Mon, 12 Jun 2023 17:23:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=8iEhXpiGxqLBGCglCcDkLyoQtOO6klDrJI2OX5LFJVA=; b=DL16ehNmhy3CCJ10uEK+lk/kaa Zw7XQloe34hdcTwUAUoCE20rodqvdabaaHU1DeeCRNui+J9QXBANnRXWJzwcg+pAq3oA7jnHQlc5u hth8bNIeYxXpNrJ3Z5MI58+frTV2ge4him7NoqFyP1WF245LR/1JUW+o8KGUcLPQUN5WYe55OeOpf vAskh4EFp3rBLDlZMyj9t7Zg6N4Wmm8fCQjOccNDofeQwOG2BmR4tNRBMcLENQbpkiKVsljvrGV9O 6BQ++qruObfyfE0yvGYMG3vbtWPQjU8biIriwI6Sm5j3Nc4+GM9jTFcjykrSfn2KiQQ5DUloEF3Eq bSCEI/cA==; Received: from [187.19.173.213] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q8lGc-008wmO-00; Mon, 12 Jun 2023 17:23:46 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D1BF540692; Mon, 12 Jun 2023 14:23:41 -0300 (-03) Date: Mon, 12 Jun 2023 14:23:41 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Suzuki K Poulose , "Naveen N. Rao" , Kan Liang , German Gomez , Ali Saidi , Jing Zhang , Athira Rajeev , Miguel Ojeda , ye xingchen , Liam Howlett , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , K Prateek Nayak , Changbin Du , Ravi Bangoria , Sean Christopherson , Andi Kleen , "Steinar H. Gunderson" , Yuan Can , Brian Robbins , liuwenyu , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org Subject: Re: [PATCH v2 26/26] perf hist: Fix srcline memory leak Message-ID: References: <20230608232823.4027869-1-irogers@google.com> <20230608232823.4027869-27-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBKdW4gMTIsIDIwMjMgYXQgMDc6NDY6MTRBTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBNb24sIEp1biAxMiwgMjAyMyBhdCA3OjE24oCvQU0gQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvCj4gPGFjbWVAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gRW0gTW9uLCBKdW4g MTIsIDIwMjMgYXQgMTE6MTM6NTlBTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxobyBkZSBNZWxvIGVz Y3JldmV1Ogo+ID4gPiBFbSBUaHUsIEp1biAwOCwgMjAyMyBhdCAwNDoyODoyM1BNIC0wNzAwLCBJ YW4gUm9nZXJzIGVzY3JldmV1Ogo+ID4gPiA+IHNyY2xpbmUgaXNuJ3QgZnJlZWQgaWYgaXQgaXMg U1JDTElORV9VTktOT1dOLiBBdm9pZCBzdHJkdXBpbmcgaW4gdGhpcwo+ID4gPiA+IGNhc2UgYXMg c3VjaCBzdHJkdXBzIGFyZSByZWR1bmRhbnQgYW5kIGxlYWsgbWVtb3J5Lgo+ID4gPgo+ID4gPiBU aGUgcGF0Y2ggaXMgb2sgYXMgaXRzIHdoYXQgdGhlIHJlc3Qgb2YgdGhlIGNvZGUgaXMgZG9pbmcs IGkuZS4gc3RyY21wKCkKPiA+ID4gdG8gY2hlY2sgaWYgYSBzcmNsaW5lIGlzIHRoZSB1bmtub3du IG9uZSwgYnV0IGhvdyBhYm91dCB0aGUgZm9sbG93aW5nCj4gPiA+IHBhdGNoIG9uIHRvcCBvZiB5 b3Vycz8KPiA+Cj4gPiBbYWNtZUBxdWFjbyBwZXJmLXRvb2xzLW5leHRdJCBzdHJpbmdzIH4vYmlu L3BlcmYgfCBncmVwICc/PzowJwo+ID4gPz86MAo+ID4gU1JDTElORV9VTktOT1dOICgoY2hhciAq KSAiPz86MCIpCj4gPiBbYWNtZUBxdWFjbyBwZXJmLXRvb2xzLW5leHRdJAo+IAo+IEFncmVlZCwg dGhlIHN0cmNtcHMgbWFrZSBtZSBuZXJ2b3VzIGFzIHRoZXkgd29uJ3QgZGlzdGluZ3Vpc2ggaGVh cAo+IGZyb20gYSBnbG9iYWwgbWVhbmluZyB3ZSBjb3VsZCBlbmQgdXAgd2l0aCB0aGluZ3MgbGlr ZSBwb2ludGVycyB0bwo+IGZyZWVkIG1lbW9yeS4gVGhlIGNvbXBhcmlzb24gd2l0aCB0aGUgZ2xv YmFsIGlzIGFsd2F5cyBnb2luZyB0byBiZQo+IHNhbWUgaW1vLgo+IAo+IEFja2VkLWJ5OiBJYW4g Um9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+CgpUaGFua3MsIGFwcGxpZWQgYW5kIGFkZGVkIHlv dXIgQWNrZWQtYnkuCgotIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK