From: Jason Gunthorpe <jgg@nvidia.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com
Subject: Re: [PATCH v5 for-next 1/7] RDMA/bnxt_re: Use the common mmap helper functions
Date: Mon, 12 Jun 2023 15:07:03 -0300 [thread overview]
Message-ID: <ZIdex3yPdSiX6qfA@nvidia.com> (raw)
In-Reply-To: <1686563342-15233-2-git-send-email-selvin.xavier@broadcom.com>
On Mon, Jun 12, 2023 at 02:48:56AM -0700, Selvin Xavier wrote:
> @@ -4002,6 +4044,13 @@ int bnxt_re_alloc_ucontext(struct ib_ucontext *ctx, struct ib_udata *udata)
> resp.comp_mask |= BNXT_RE_UCNTX_CMASK_HAVE_MODE;
> resp.mode = rdev->chip_ctx->modes.wqe_mode;
>
> + entry = bnxt_re_mmap_entry_insert(uctx, 0, BNXT_RE_MMAP_SH_PAGE, NULL);
> + if (!entry) {
> + rc = -ENOMEM;
> + goto cfail;
> + }
> + uctx->shpage_mmap = &entry->rdma_entry;
How can this be called with a NULL offset return?
It seems like the offset is hardwired by userspace?
If so it should use of the insert exact offset APIs
Jason
next prev parent reply other threads:[~2023-06-12 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:48 [PATCH v5 for-next 0/7] RDMA/bnxt_re: driver update for supporting low latency push Selvin Xavier
2023-06-12 9:48 ` [PATCH v5 for-next 1/7] RDMA/bnxt_re: Use the common mmap helper functions Selvin Xavier
2023-06-12 18:07 ` Jason Gunthorpe [this message]
2023-06-13 4:48 ` Selvin Xavier
2023-06-12 9:48 ` [PATCH v5 for-next 2/7] RDMA/bnxt_re: Add disassociate ucontext support Selvin Xavier
2023-06-12 9:48 ` [PATCH v5 for-next 3/7] RDMA/bnxt_re: Optimize the bnxt_re_init_hwrm_hdr usage Selvin Xavier
2023-06-12 9:48 ` [PATCH v5 for-next 4/7] RDMA/bnxt_re: Query function capabilities from firmware Selvin Xavier
2023-06-12 9:49 ` [PATCH v5 for-next 5/7] RDMA/bnxt_re: Move the interface version to chip context structure Selvin Xavier
2023-06-12 9:49 ` [PATCH v5 for-next 6/7] RDMA/bnxt_re: Reorg the bar mapping Selvin Xavier
2023-06-12 9:49 ` [PATCH v5 for-next 7/7] RDMA/bnxt_re: Enable low latency push Selvin Xavier
2023-06-12 18:19 ` Jason Gunthorpe
2023-06-13 5:23 ` Selvin Xavier
2023-06-13 11:41 ` Jason Gunthorpe
2023-06-13 11:51 ` Selvin Xavier
2023-06-12 18:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIdex3yPdSiX6qfA@nvidia.com \
--to=jgg@nvidia.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.