From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183CBC7EE2F for ; Mon, 12 Jun 2023 21:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l72NRoMSM0sDHNt1e2q4cau6O2yKA6n5aeBc3gUVjZg=; b=dbaI2ZNqMt8Z4g 3o6fu007C3J+IbXaMwKj7dEIQ3MWfbUqXXTTl/aIhgvY5Rr2yZBX/ZIRsShgVouSusS/nqmGAtIQd wyTIFxuBeqIM2Dnqw8unGgwJz+D1PZRd5aOIf37pAKj2sqyuvwlvNsHYdxjxdRlGqe/bRPSn/i4Gj Fu92mxT+GzzuU9QAv055FAq2g+mK41XVCjF70L4E9SI4M1MTbGAky0R2DICYxAY1ZojRpM/e6X0CU Zjj8yXcienh6okewsyiXGiBuMaoQWBWsyUG84OdLXlNGs7mcRo3Eb/Yc8+LlmRDHz4rlyxX7LEWZE 6/cc1eAauG5Epxf7Is/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8orn-005Str-1p; Mon, 12 Jun 2023 21:14:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8ork-005StL-0v; Mon, 12 Jun 2023 21:14:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xwwebQPgbNOKpFrm5K41615nrmEyOJejBS23JzW+wa4=; b=P9gF7R78DXM9CvUbX2txIGJInw f/GSSTc9Zc+TCjTFpsVCR9o0N7QafjmgU88Zb/MoCLk+RI0zbWWZ6F09YaPbvuBsMcBYzw1mOmZ9e 9jBXXYG7+oJjYBsHPzmw/RQh9zeS9k+MYyOBe3GNkx/MX68Hus+lIYaqCbtWCbl4HLnV7j4OmJKJO Ua7b0draa/WshwtQHsqbP/vvSOCevxos0ct46UF7/Af7jWWB18gZva4setkjZUw1OIAMHqj4S42Ge C5Eo1IU5D1LInVm/2MVeY5jtkilwzuDCSpyydyU0MO8zCGOZdsZFFv0THIB1J11IE91g081djlcNY UlV5dR9w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41672) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8ora-0006Pm-S5; Mon, 12 Jun 2023 22:14:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q8orZ-0005KR-PL; Mon, 12 Jun 2023 22:14:09 +0100 Date: Mon, 12 Jun 2023 22:14:09 +0100 From: "Russell King (Oracle)" To: arinc9.unal@gmail.com Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v4 3/7] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Message-ID: References: <20230612075945.16330-1-arinc.unal@arinc9.com> <20230612075945.16330-4-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230612075945.16330-4-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_141420_344278_003BD0E2 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMTIsIDIwMjMgYXQgMTA6NTk6NDFBTSArMDMwMCwgYXJpbmM5LnVuYWxAZ21h aWwuY29tIHdyb3RlOgo+IEZyb206IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNv bT4KPiAKPiBUaGUgY2hlY2sgZm9yIHNldHRpbmcgdGhlIENQVV9QT1JUIGJpdHMgbXVzdCBpbmNs dWRlIHRoZSBub24tTVQ3NjIxIFNvQwo+IE1UNzUzMCBzd2l0Y2ggdmFyaWFudHMgdG8gdHJhcCBm cmFtZXMuIEV4cGFuZCB0aGUgY2hlY2sgdG8gaW5jbHVkZSB0aGVtLgoKLi4uIGFuZCBub3cgeW91 IGFkZCBzdXBwb3J0IGZvciB0aGlzIHRvIHRoZSBNVDc1MzAsIHdoaWNoIGlzIHdoYXQKYWxlcnRl ZCBtZSB0byB3aGF0IHNlZW1zIHRvIGJlIGEgbWlzdGFrZSBpbiB0aGUgcHJldmlvdXMgcGF0Y2gu CgoiVGhlIHNldHVwIG9mIENQVV9QT1JUKCkgbmVlZHMgdG8gYmUgZG9uZSBmb3IgdGhlIE1UNzUz MCBzd2l0Y2ggdmFyaWFudHMKYXMgd2VsbCBhcyB0aGUgTVQ3NjIxLiIKCi0tIApSTUsncyBQYXRj aCBzeXN0ZW06IGh0dHBzOi8vd3d3LmFybWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8K RlRUUCBpcyBoZXJlISA4ME1icHMgZG93biAxME1icHMgdXAuIERlY2VudCBjb25uZWN0aXZpdHkg YXQgbGFzdCEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B24C7EE2E for ; Mon, 12 Jun 2023 21:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235702AbjFLVUV (ORCPT ); Mon, 12 Jun 2023 17:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238598AbjFLVUE (ORCPT ); Mon, 12 Jun 2023 17:20:04 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5321BF1; Mon, 12 Jun 2023 14:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xwwebQPgbNOKpFrm5K41615nrmEyOJejBS23JzW+wa4=; b=P9gF7R78DXM9CvUbX2txIGJInw f/GSSTc9Zc+TCjTFpsVCR9o0N7QafjmgU88Zb/MoCLk+RI0zbWWZ6F09YaPbvuBsMcBYzw1mOmZ9e 9jBXXYG7+oJjYBsHPzmw/RQh9zeS9k+MYyOBe3GNkx/MX68Hus+lIYaqCbtWCbl4HLnV7j4OmJKJO Ua7b0draa/WshwtQHsqbP/vvSOCevxos0ct46UF7/Af7jWWB18gZva4setkjZUw1OIAMHqj4S42Ge C5Eo1IU5D1LInVm/2MVeY5jtkilwzuDCSpyydyU0MO8zCGOZdsZFFv0THIB1J11IE91g081djlcNY UlV5dR9w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41672) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8ora-0006Pm-S5; Mon, 12 Jun 2023 22:14:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q8orZ-0005KR-PL; Mon, 12 Jun 2023 22:14:09 +0100 Date: Mon, 12 Jun 2023 22:14:09 +0100 From: "Russell King (Oracle)" To: arinc9.unal@gmail.com Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v4 3/7] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Message-ID: References: <20230612075945.16330-1-arinc.unal@arinc9.com> <20230612075945.16330-4-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230612075945.16330-4-arinc.unal@arinc9.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 10:59:41AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > The check for setting the CPU_PORT bits must include the non-MT7621 SoC > MT7530 switch variants to trap frames. Expand the check to include them. ... and now you add support for this to the MT7530, which is what alerted me to what seems to be a mistake in the previous patch. "The setup of CPU_PORT() needs to be done for the MT7530 switch variants as well as the MT7621." -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!