Re: [Intel-xe] [PATCH] drm/xe : Fix GT looping for standalone media

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Jun 13, 2023 at 03:12:32PM +0530, Riana Tauro wrote:
> Currently the id of primary gt is set using gt_count and not
> the media gt.
> 
> set gt->info.id of media gt using gt_count
> 
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index bd1f59b49928..2991cf5365d5 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -590,7 +590,7 @@ static int xe_info_init(struct xe_device *xe,
>  		 * up with platforms that support both together.
>  		 */
>  		drm_WARN_ON(&xe->drm, id != 0);
> -		gt->info.id = 1;

I agree with change but Matt R is the expert here.

If we go with the change the above drm_WARN_ON & FIXME comment need to
be deleted too.

Matt

> +		gt->info.id = xe->info.gt_count++;
>  	}
>  
>  	return 0;
> -- 
> 2.40.0
>