From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: linux-acpi@vger.kernel.org, rafael@kernel.org,
ilpo.jarvinen@linux.intel.com, pali@kernel.org,
hdegoede@redhat.com, markgross@kernel.org,
fengguang.wu@intel.com, dvhart@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86/dell/dell-rbtn: Fix resources leaking on error path
Date: Tue, 13 Jun 2023 18:12:40 +0300 [thread overview]
Message-ID: <ZIiHaEn7nW7yAFK8@smile.fi.intel.com> (raw)
In-Reply-To: <20230613084310.2775896-1-michal.wilczynski@intel.com>
On Tue, Jun 13, 2023 at 11:43:10AM +0300, Michal Wilczynski wrote:
> Currently rbtn_add() in case of failure is leaking resources. Fix this
> by adding a proper rollback. Move devm_kzalloc() before rbtn_acquire(),
> so it doesn't require rollback in case of failure. While at it, remove
> unnecessary assignment of NULL to device->driver_data and unnecessary
> whitespace, plus add a break for the default case in a switch.
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Isn't also suggested by Pali?
> Fixes: 817a5cdb40c8 ("dell-rbtn: Dell Airplane Mode Switch driver")
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
...
Hans, can it (an additional tag) be folded into applied change?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-13 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:43 [PATCH v2] platform/x86/dell/dell-rbtn: Fix resources leaking on error path Michal Wilczynski
2023-06-13 10:41 ` Hans de Goede
2023-06-13 15:12 ` Andy Shevchenko [this message]
2023-06-13 15:21 ` Wilczynski, Michal
2023-06-13 15:35 ` Hans de Goede
2023-06-13 16:40 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIiHaEn7nW7yAFK8@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=dvhart@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.