From: Wolfram Sang <wsa@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Evan.Quan@amd.com, Lijo.Lazar@amd.com,
Sanket.Goswami@amd.com
Subject: Re: [PATCH v2] usb: typec: ucsi: Mark dGPUs as DEVICE scope
Date: Wed, 14 Jun 2023 10:47:35 +0200 [thread overview]
Message-ID: <ZIl+pyKgFdQuYCKm@shikoro> (raw)
In-Reply-To: <20230614001621.iyxi2khz4hmcbl3x@intel.intel>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Wed, Jun 14, 2023 at 02:16:21AM +0200, Andi Shyti wrote:
> Hi Mario,
>
> On Thu, May 18, 2023 at 11:11:50AM -0500, Mario Limonciello wrote:
> > power_supply_is_system_supplied() checks whether any power
> > supplies are present that aren't batteries to decide whether
> > the system is running on DC or AC. Downstream drivers use
> > this to make performance decisions.
> >
> > Navi dGPUs include an UCSI function that has been exported
> > since commit 17631e8ca2d3 ("i2c: designware: Add driver
> > support for AMD NAVI GPU").
> >
> > This UCSI function registers a power supply since commit
> > 992a60ed0d5e ("usb: typec: ucsi: register with power_supply class")
> > but this is not a system power supply.
> >
> > As the power supply for a dGPU is only for powering devices connected
> > to dGPU, create a device property to indicate that the UCSI endpoint
> > is only for the scope of `POWER_SUPPLY_SCOPE_DEVICE`.
> >
> > Link: https://lore.kernel.org/lkml/20230516182541.5836-2-mario.limonciello@amd.com/
> > Reviewed-by: Evan Quan <evan.quan@amd.com>
> > Tested-by: Evan Quan <evan.quan@amd.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>
> Acked-by: Andi Shyti <andi.shyti@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-06-14 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 16:11 [PATCH v2] usb: typec: ucsi: Mark dGPUs as DEVICE scope Mario Limonciello
2023-05-19 8:12 ` Heikki Krogerus
2023-05-20 17:24 ` Sebastian Reichel
2023-05-21 9:23 ` Gregor Riepl
2023-05-21 12:59 ` Mario Limonciello
2023-06-14 0:16 ` Andi Shyti
2023-06-14 8:47 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIl+pyKgFdQuYCKm@shikoro \
--to=wsa@kernel.org \
--cc=Evan.Quan@amd.com \
--cc=Lijo.Lazar@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=ajayg@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.