From: Simon Horman <simon.horman@corigine.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Jakub Buchocki <jakubx.buchocki@intel.com>,
michal.swiatkowski@linux.intel.com, jiri@resnulli.us,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net v2] ice: Fix ice module unload
Date: Wed, 14 Jun 2023 10:05:00 +0200 [thread overview]
Message-ID: <ZIl0rPQ4EWr10JpX@corigine.com> (raw)
In-Reply-To: <20230612171421.21570-1-anthony.l.nguyen@intel.com>
On Mon, Jun 12, 2023 at 10:14:21AM -0700, Tony Nguyen wrote:
> From: Jakub Buchocki <jakubx.buchocki@intel.com>
>
> Clearing the interrupt scheme before PFR reset,
> during the removal routine, could cause the hardware
> errors and possibly lead to system reboot, as the PF
> reset can cause the interrupt to be generated.
>
> Place the call for PFR reset inside ice_deinit_dev(),
> wait until reset and all pending transactions are done,
> then call ice_clear_interrupt_scheme().
>
> This introduces a PFR reset to multiple error paths.
>
> Additionally, remove the call for the reset from
> ice_load() - it will be a part of ice_unload() now.
>
> Error example:
> [ 75.229328] ice 0000:ca:00.1: Failed to read Tx Scheduler Tree - User Selection data from flash
> [ 77.571315] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
> [ 77.571418] {1}[Hardware Error]: event severity: recoverable
> [ 77.571459] {1}[Hardware Error]: Error 0, type: recoverable
> [ 77.571500] {1}[Hardware Error]: section_type: PCIe error
> [ 77.571540] {1}[Hardware Error]: port_type: 4, root port
> [ 77.571580] {1}[Hardware Error]: version: 3.0
> [ 77.571615] {1}[Hardware Error]: command: 0x0547, status: 0x4010
> [ 77.571661] {1}[Hardware Error]: device_id: 0000:c9:02.0
> [ 77.571703] {1}[Hardware Error]: slot: 25
> [ 77.571736] {1}[Hardware Error]: secondary_bus: 0xca
> [ 77.571773] {1}[Hardware Error]: vendor_id: 0x8086, device_id: 0x347a
> [ 77.571821] {1}[Hardware Error]: class_code: 060400
> [ 77.571858] {1}[Hardware Error]: bridge: secondary_status: 0x2800, control: 0x0013
> [ 77.572490] pcieport 0000:c9:02.0: AER: aer_status: 0x00200000, aer_mask: 0x00100020
> [ 77.572870] pcieport 0000:c9:02.0: [21] ACSViol (First)
> [ 77.573222] pcieport 0000:c9:02.0: AER: aer_layer=Transaction Layer, aer_agent=Receiver ID
> [ 77.573554] pcieport 0000:c9:02.0: AER: aer_uncor_severity: 0x00463010
> [ 77.691273] {2}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
> [ 77.691738] {2}[Hardware Error]: event severity: recoverable
> [ 77.691971] {2}[Hardware Error]: Error 0, type: recoverable
> [ 77.692192] {2}[Hardware Error]: section_type: PCIe error
> [ 77.692403] {2}[Hardware Error]: port_type: 4, root port
> [ 77.692616] {2}[Hardware Error]: version: 3.0
> [ 77.692825] {2}[Hardware Error]: command: 0x0547, status: 0x4010
> [ 77.693032] {2}[Hardware Error]: device_id: 0000:c9:02.0
> [ 77.693238] {2}[Hardware Error]: slot: 25
> [ 77.693440] {2}[Hardware Error]: secondary_bus: 0xca
> [ 77.693641] {2}[Hardware Error]: vendor_id: 0x8086, device_id: 0x347a
> [ 77.693853] {2}[Hardware Error]: class_code: 060400
> [ 77.694054] {2}[Hardware Error]: bridge: secondary_status: 0x0800, control: 0x0013
> [ 77.719115] pci 0000:ca:00.1: AER: can't recover (no error_detected callback)
> [ 77.719140] pcieport 0000:c9:02.0: AER: device recovery failed
> [ 77.719216] pcieport 0000:c9:02.0: AER: aer_status: 0x00200000, aer_mask: 0x00100020
> [ 77.719390] pcieport 0000:c9:02.0: [21] ACSViol (First)
> [ 77.719557] pcieport 0000:c9:02.0: AER: aer_layer=Transaction Layer, aer_agent=Receiver ID
> [ 77.719723] pcieport 0000:c9:02.0: AER: aer_uncor_severity: 0x00463010
>
> Fixes: 5b246e533d01 ("ice: split probe into smaller functions")
> Signed-off-by: Jakub Buchocki <jakubx.buchocki@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-14 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 17:14 [PATCH net v2] ice: Fix ice module unload Tony Nguyen
2023-06-14 8:05 ` Simon Horman [this message]
2023-06-15 6:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIl0rPQ4EWr10JpX@corigine.com \
--to=simon.horman@corigine.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=jakubx.buchocki@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.