From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf tool x86: Fix perf_env memory leak
Date: Wed, 14 Jun 2023 10:42:37 -0300 [thread overview]
Message-ID: <ZInDzUVOyuUda7A7@kernel.org> (raw)
In-Reply-To: <60477a13-1b8b-5aad-b635-73b9d8e3f734@amd.com>
Em Wed, Jun 14, 2023 at 08:52:43AM +0530, Ravi Bangoria escreveu:
> On 14-Jun-23 6:36 AM, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jun 13, 2023 at 04:54:16PM -0700, Ian Rogers escreveu:
> >> Found by leak sanitizer:
> >> ```
> >> ==1632594==ERROR: LeakSanitizer: detected memory leaks
> >>
> >> Direct leak of 21 byte(s) in 1 object(s) allocated from:
> >> #0 0x7f2953a7077b in __interceptor_strdup ../../../../src/libsanitizer/asan/asan_interceptors.cpp:439
> >> #1 0x556701d6fbbf in perf_env__read_cpuid util/env.c:369
> >> #2 0x556701d70589 in perf_env__cpuid util/env.c:465
> >> #3 0x55670204bba2 in x86__is_amd_cpu arch/x86/util/env.c:14
> >> #4 0x5567020487a2 in arch__post_evsel_config arch/x86/util/evsel.c:83
> >> #5 0x556701d8f78b in evsel__config util/evsel.c:1366
> >> #6 0x556701ef5872 in evlist__config util/record.c:108
> >> #7 0x556701cd6bcd in test__PERF_RECORD tests/perf-record.c:112
> >> #8 0x556701cacd07 in run_test tests/builtin-test.c:236
> >> #9 0x556701cacfac in test_and_print tests/builtin-test.c:265
> >> #10 0x556701cadddb in __cmd_test tests/builtin-test.c:402
> >> #11 0x556701caf2aa in cmd_test tests/builtin-test.c:559
> >> #12 0x556701d3b557 in run_builtin tools/perf/perf.c:323
> >> #13 0x556701d3bac8 in handle_internal_command tools/perf/perf.c:377
> >> #14 0x556701d3be90 in run_argv tools/perf/perf.c:421
> >> #15 0x556701d3c3f8 in main tools/perf/perf.c:537
> >> #16 0x7f2952a46189 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
> >>
> >> SUMMARY: AddressSanitizer: 21 byte(s) leaked in 1 allocation(s).
> >> ```
> >>
> >> Fixes: daea405f5f06 ("perf tool x86: Consolidate is_amd check into single function")
> >
> > Its a fix, yes, but it is not for this daea405f5f06 patch, he just moved the
> > perf_mem_is_amd_cpu(), that was leaky, to a different file, the fixes is
> > for for:
> >
> > f7b58cbdb3ff36eb ("perf mem/c2c: Add load store event mappings for
> > AMD").
> >
> > Right?
>
> Yeah that's correct "Fixes" commit. Thanks for the fix Ian!
Thanks, I'm taking that as an:
Acked-by: Ravi Bangoria <ravi.bangoria@amd.com>
Ok?
- Arnaldo
next prev parent reply other threads:[~2023-06-14 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 23:54 [PATCH v1] perf tool x86: Fix perf_env memory leak Ian Rogers
2023-06-14 1:06 ` Arnaldo Carvalho de Melo
2023-06-14 3:22 ` Ravi Bangoria
2023-06-14 4:05 ` Ian Rogers
2023-06-14 13:42 ` Arnaldo Carvalho de Melo [this message]
2023-06-14 14:03 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInDzUVOyuUda7A7@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.