From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A42ADEB64D8 for ; Wed, 14 Jun 2023 16:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hrHN7/tvr5TC8jzN/42satnxWNWhk95dYNp9/9rXnfA=; b=OKxia7mooy3Kmj X9y9DyDDB0MvzVq+uaZwgHqv1KQVizEMzULK7OOfIlY6xkfU1gj2+pGNGimlLMmNSQS5xr1b3f376 oNZgujnA5/EXRjUqgQnlYEsaI78/JQQ03SprVnwmRUwUSAwyvBqa+R5lXx3JlNWaZqK/W0rK6b4VV RxLGt4suaJGHPAdSmqBw9/ATaWQ94vFDKCPNV9E1RtsVZl29lga0lNMZGO0fWm9KhtftiaGBfgwUB n/I260DGnybmLi7+L+rlud+timuENS1GKBtqe2lM9kCcPdnhGP0nRUMsxo1fBDoPC27wNgle68gvj rzp/zGcVrOR1NolHufnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9TFt-00CByP-0T; Wed, 14 Jun 2023 16:21:57 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9TFp-00CBxd-1r; Wed, 14 Jun 2023 16:21:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QWph71KWV3aPlqaV648UJHe6lbKZBpXdiDZJikc9zP8=; b=y45S5FcBhDXz+6NaXk1EUEetiF Vc+jk0MdpAtlg8qedoWjj6F9Zx4e7xguW8BAmEOEp2GikxxxOl8ZPV+zZLnrJHFphEVu89yYUHoBx jstoLPfDBdQt0YvbHkJXz+4agTaR9PuMcHXVI8Y2hNpO7BS0uy8Y5tjm/p1WiXvAzk8peUiqaC96g xBNo9bbF9J22MdPpTtUQMn81sfT+5ZQf2AlSOLPl0F3Zz5wrboKUSmlEqBtkYxQnJbPVMTCaBSyiA C4rKMZGYgpFMuo6t/mXfVKG/Hag5OHRTOMQcKuZ7x7FsbtDy91b7kpYYA/0z4gl395hb8tiN0gCEy UljwbNjQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51956) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9TFi-0001xs-6h; Wed, 14 Jun 2023 17:21:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q9TFf-0000Yu-9i; Wed, 14 Jun 2023 17:21:43 +0100 Date: Wed, 14 Jun 2023 17:21:43 +0100 From: "Russell King (Oracle)" To: AngeloGioacchino Del Regno Cc: Wei-chin Tsai =?utf-8?B?KOiUoee2reaZiSk=?= , "linux-kernel@vger.kernel.org" , Mel Lee =?utf-8?B?KOadjuWlh+mMmik=?= , "linux-mediatek@lists.infradead.org" , wsd_upstream , "linux-arm-kernel@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "matthias.bgg@gmail.com" , Ivan Tseng =?utf-8?B?KOabvuW/l+i7kik=?= Subject: Re: [PATCH v2 2/3] memory: export symbols for memory related functions Message-ID: References: <20230614032038.11699-1-Wei-chin.Tsai@mediatek.com> <20230614032038.11699-3-Wei-chin.Tsai@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_092153_639697_3265B60C X-CRM114-Status: GOOD ( 28.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMTQsIDIwMjMgYXQgMDI6MTE6MjVQTSArMDIwMCwgQW5nZWxvR2lvYWNjaGlu byBEZWwgUmVnbm8gd3JvdGU6Cj4gSWwgMTQvMDYvMjMgMTE6NTksIFdlaS1jaGluIFRzYWkgKOiU oee2reaZiSkgaGEgc2NyaXR0bzoKPiA+IE9uIFdlZCwgMjAyMy0wNi0xNCBhdCAwODoxNiArMDEw MCwgUnVzc2VsbCBLaW5nIChPcmFjbGUpIHdyb3RlOgo+ID4gPiAgIAkKPiA+ID4gRXh0ZXJuYWwg ZW1haWwgOiBQbGVhc2UgZG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW50 aWwKPiA+ID4geW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBvciB0aGUgY29udGVudC4KPiA+ ID4gICBPbiBXZWQsIEp1biAxNCwgMjAyMyBhdCAxMToyMDozNEFNICswODAwLCBXZWkgQ2hpbiBU c2FpIHdyb3RlOgo+ID4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9rZXJuZWwvcHJvY2Vzcy5j IGIvYXJjaC9hcm0va2VybmVsL3Byb2Nlc3MuYwo+ID4gPiA+IGluZGV4IDBlOGZmODU4OTBhZC4u ZGY5MTQxMmExMDY5IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtL2tlcm5lbC9wcm9jZXNz LmMKPiA+ID4gPiArKysgYi9hcmNoL2FybS9rZXJuZWwvcHJvY2Vzcy5jCj4gPiA+ID4gQEAgLTM0 Myw2ICszNDMsNyBAQCBjb25zdCBjaGFyICphcmNoX3ZtYV9uYW1lKHN0cnVjdCB2bV9hcmVhX3N0 cnVjdAo+ID4gPiAqdm1hKQo+ID4gPiA+ICAgewo+ID4gPiA+ICAgcmV0dXJuIGlzX2dhdGVfdm1h KHZtYSkgPyAiW3ZlY3RvcnNdIiA6IE5VTEw7Cj4gPiA+ID4gICB9Cj4gPiA+ID4gK0VYUE9SVF9T WU1CT0xfR1BMKGFyY2hfdm1hX25hbWUpOwo+ID4gPiAuLi4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEv a2VybmVsL3NpZ25hbC5jIGIva2VybmVsL3NpZ25hbC5jCj4gPiA+ID4gaW5kZXggYjUzNzBmZTVj MTk4Li5hMWFiZTc3ZmNkYzMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEva2VybmVsL3NpZ25hbC5jCj4g PiA+ID4gKysrIGIva2VybmVsL3NpZ25hbC5jCj4gPiA+ID4gQEAgLTQ3MDAsNiArNDcwMCw3IEBA IF9fd2VhayBjb25zdCBjaGFyICphcmNoX3ZtYV9uYW1lKHN0cnVjdAo+ID4gPiB2bV9hcmVhX3N0 cnVjdCAqdm1hKQo+ID4gPiA+ICAgewo+ID4gPiA+ICAgcmV0dXJuIE5VTEw7Cj4gPiA+ID4gICB9 Cj4gPiA+ID4gK0VYUE9SVF9TWU1CT0xfR1BMKGFyY2hfdm1hX25hbWUpOwo+ID4gPiAKPiA+ID4g SGF2ZSB5b3UgY29uZmlybWVkOgo+ID4gPiAxKSB3aGV0aGVyIHRoaXMgYWN0dWFsbHkgYnVpbGRz Cj4gPiA+IDIpIHdoZXRoZXIgdGhpcyByZXN1bHRzIGluIG9uZSBvciB0d28gYXJjaF92bWFfbmFt ZSBleHBvcnRzCj4gPiA+IAo+ID4gPiA/Cj4gPiA+IAo+ID4gPiAtLSAKPiA+ID4gUk1LJ3MgUGF0 Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMv Cj4gPiA+IEZUVFAgaXMgaGVyZSEgODBNYnBzIGRvd24gMTBNYnBzIHVwLiBEZWNlbnQgY29ubmVj dGl2aXR5IGF0IGxhc3QhCj4gPiAKPiA+IEhpIFJ1c3NlbGwsCj4gPiAKPiA+IFdlIGRpZCBjb25m aXJtIHRoYXQgaXQgY2FuIGJlIGJ1aWx0IHN1Y2Nlc3NmdWxseSBpbiBrZXJuZWwgNi4xIGFuZCBy dW4KPiA+IHdlbGwgaW4gb3VyIHN5c3RlbS4KPiA+IAo+IAo+IEl0IHJ1bnMgd2VsbCBpbiB5b3Vy IHN5c3RlbSBhbmQgY2FuIGJlIGJ1aWx0IHN1Y2Nlc3NmdWxseSBiZWNhdXNlIHlvdSdyZSBidWls ZGluZwo+IGZvciBBUk02NCwgbm90IGZvciBBUk0uLi4KPiAKPiA+IEFjdHVhbGx5LCB3ZSBvbmx5 IHVzZSB0aGlzIGV4cG9ydCBzeW1ib2wgImFyY2hfdm1hX25hbWUiCj4gPiBmcm9tIGtlcm5lbC9z aWduYWwuYyBpbiBhcm02NC4gV2UgYWxzbyBleHBvcnQgc3ltYm9sIGZvciBhcmNoX3ZtYV9uYW1l Cj4gPiBpbiBhcmNoL2FybS9rZXJuZWwvcHJvY2Vzcy5jIGJlY2F1c2UgdGhhdCwgb25lIGRheSBp biB0aGUgZnV0dXJlLCAgd2UKPiA+IGFyZSBhZnJhaWQgdGhhdCB3ZSBhbHNvIG5lZWQgdGhpcyBm dW5jdGlvbiBpbiBhcm0gcGxhdGZvcm0uCgpXaGF0IEknbSB0cnlpbmcgdG8gZ2V0IGF0IGlzIHRo YXQgd2UgaGF2ZSBhcmNoX3ZtYV9uYW1lIGluCmFyY2gvYXJtL2tlcm5lbC9wcm9jZXNzLmMgYW5k IGFsc28gYSB3ZWFrIGZ1bmN0aW9uIGluIGtlcm5lbC9zaWduYWwuYy4KCkJvdGggb2YgdGhlc2Ug ZW5kIHVwIGFkZGluZyBhbiBlbnRyeSBpbnRvIHRoZSBfX2tzeW10YWJfc3RyaW5ncwpzZWN0aW9u IGFuZCBhIF9fX2tzeW10YWIgc2VjdGlvbiBmb3IgdGhpcyBzeW1ib2wuIFNvIHdlIGVuZCB1cCB3 aXRoCnR3byBlbnRyaWVzIGluIGVhY2guCgpOb3csIGlmIHRoZSBvbmUgZnJvbSBrZXJuZWwvc2ln bmFsLmMgcG9pbnRzIGF0IGl0cyBvd24gd2VhayBmdW5jdGlvbiwKYW5kIHRoYXQgaXMgZm91bmQg Zmlyc3QsIHRoZW4gdGhhdCdzIHRoZSBmdW5jdGlvbiB0aGF0IGlzIGdvaW5nIHRvIGJlCmJvdW5k LCBub3QgdGhlIGZ1bmN0aW9uIHRoYXQncyBvdmVycmlkaW5nIGl0LgoKSWYsIGluc3RlYWQsIHRo ZSBleHBvcnQgaW4ga2VybmVsL3NpZ25hbC5jIGVuZHMgdXAgcG9pbnRpbmcgYXQgdGhlCm92ZXJy aWRlbiBmdW5jdGlvbiwgdGhlbiB0aGUgZXhwb3J0IGluIGFyY2gvYXJtL2tlcm5lbC9wcm9jZXNz LmMgaXMKZW50aXJlbHkgcmVkdW5kYW50LgoKU28sIHlvdSBuZWVkIHRvIGdldCB0byB0aGUgYm90 dG9tIG9mIHRoaXMuLi4gYW5kIHVudGlsIHlvdSBkbyBJJ20KYWZyYWlkIEknbGwgaGF2ZSB0byBO QUsgdGhpcyBwYXRjaC4KCkZvciB0aGUgcmVjb3JkLCBJIHN1c3BlY3QgaXQncyB0aGUgbGF0dGVy IHNjZW5hcmlvICh3ZSBlbmQgdXAgd2l0aAp0d28gZW50cmllcyBwb2ludGluZyBhdCB0aGUgc2Ft ZSBmdW5jdGlvbikgYnV0IHRoYXQncyBub3RoaW5nIG1vcmUKdGhhbiBhIGh1bmNoLgoKLS0gClJN SydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9w YXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5l Y3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C4BEB64DB for ; Wed, 14 Jun 2023 16:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233041AbjFNQV6 (ORCPT ); Wed, 14 Jun 2023 12:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232936AbjFNQVw (ORCPT ); Wed, 14 Jun 2023 12:21:52 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E600119; Wed, 14 Jun 2023 09:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QWph71KWV3aPlqaV648UJHe6lbKZBpXdiDZJikc9zP8=; b=y45S5FcBhDXz+6NaXk1EUEetiF Vc+jk0MdpAtlg8qedoWjj6F9Zx4e7xguW8BAmEOEp2GikxxxOl8ZPV+zZLnrJHFphEVu89yYUHoBx jstoLPfDBdQt0YvbHkJXz+4agTaR9PuMcHXVI8Y2hNpO7BS0uy8Y5tjm/p1WiXvAzk8peUiqaC96g xBNo9bbF9J22MdPpTtUQMn81sfT+5ZQf2AlSOLPl0F3Zz5wrboKUSmlEqBtkYxQnJbPVMTCaBSyiA C4rKMZGYgpFMuo6t/mXfVKG/Hag5OHRTOMQcKuZ7x7FsbtDy91b7kpYYA/0z4gl395hb8tiN0gCEy UljwbNjQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51956) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9TFi-0001xs-6h; Wed, 14 Jun 2023 17:21:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q9TFf-0000Yu-9i; Wed, 14 Jun 2023 17:21:43 +0100 Date: Wed, 14 Jun 2023 17:21:43 +0100 From: "Russell King (Oracle)" To: AngeloGioacchino Del Regno Cc: Wei-chin Tsai =?utf-8?B?KOiUoee2reaZiSk=?= , "linux-kernel@vger.kernel.org" , Mel Lee =?utf-8?B?KOadjuWlh+mMmik=?= , "linux-mediatek@lists.infradead.org" , wsd_upstream , "linux-arm-kernel@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "matthias.bgg@gmail.com" , Ivan Tseng =?utf-8?B?KOabvuW/l+i7kik=?= Subject: Re: [PATCH v2 2/3] memory: export symbols for memory related functions Message-ID: References: <20230614032038.11699-1-Wei-chin.Tsai@mediatek.com> <20230614032038.11699-3-Wei-chin.Tsai@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 14, 2023 at 02:11:25PM +0200, AngeloGioacchino Del Regno wrote: > Il 14/06/23 11:59, Wei-chin Tsai (蔡維晉) ha scritto: > > On Wed, 2023-06-14 at 08:16 +0100, Russell King (Oracle) wrote: > > > > > > External email : Please do not click links or open attachments until > > > you have verified the sender or the content. > > > On Wed, Jun 14, 2023 at 11:20:34AM +0800, Wei Chin Tsai wrote: > > > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > > > > index 0e8ff85890ad..df91412a1069 100644 > > > > --- a/arch/arm/kernel/process.c > > > > +++ b/arch/arm/kernel/process.c > > > > @@ -343,6 +343,7 @@ const char *arch_vma_name(struct vm_area_struct > > > *vma) > > > > { > > > > return is_gate_vma(vma) ? "[vectors]" : NULL; > > > > } > > > > +EXPORT_SYMBOL_GPL(arch_vma_name); > > > ... > > > > diff --git a/kernel/signal.c b/kernel/signal.c > > > > index b5370fe5c198..a1abe77fcdc3 100644 > > > > --- a/kernel/signal.c > > > > +++ b/kernel/signal.c > > > > @@ -4700,6 +4700,7 @@ __weak const char *arch_vma_name(struct > > > vm_area_struct *vma) > > > > { > > > > return NULL; > > > > } > > > > +EXPORT_SYMBOL_GPL(arch_vma_name); > > > > > > Have you confirmed: > > > 1) whether this actually builds > > > 2) whether this results in one or two arch_vma_name exports > > > > > > ? > > > > > > -- > > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! > > > > Hi Russell, > > > > We did confirm that it can be built successfully in kernel 6.1 and run > > well in our system. > > > > It runs well in your system and can be built successfully because you're building > for ARM64, not for ARM... > > > Actually, we only use this export symbol "arch_vma_name" > > from kernel/signal.c in arm64. We also export symbol for arch_vma_name > > in arch/arm/kernel/process.c because that, one day in the future, we > > are afraid that we also need this function in arm platform. What I'm trying to get at is that we have arch_vma_name in arch/arm/kernel/process.c and also a weak function in kernel/signal.c. Both of these end up adding an entry into the __ksymtab_strings section and a ___ksymtab section for this symbol. So we end up with two entries in each. Now, if the one from kernel/signal.c points at its own weak function, and that is found first, then that's the function that is going to be bound, not the function that's overriding it. If, instead, the export in kernel/signal.c ends up pointing at the overriden function, then the export in arch/arm/kernel/process.c is entirely redundant. So, you need to get to the bottom of this... and until you do I'm afraid I'll have to NAK this patch. For the record, I suspect it's the latter scenario (we end up with two entries pointing at the same function) but that's nothing more than a hunch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!