From: Sean Christopherson <seanjc@google.com>
To: baomingtong001@208suo.com
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: [PATCH] KVM: x86: remove unneeded variable
Date: Wed, 14 Jun 2023 12:18:46 -0700 [thread overview]
Message-ID: <ZIoSlrXifl/ikSBC@google.com> (raw)
In-Reply-To: <a2510fb15553a294236646321cf1b3a4@208suo.com>
+Dave, -Ave
scripts/get_maintainers.pl is your friend. It avoids typos (well, if you wrap
it with scripts instead of copy+pasting), and makes sures patches get routed to
the right folks (KVM x86 patches are routed through the KVM tree, not the tip tree).
On Wed, Jun 14, 2023, baomingtong001@208suo.com wrote:
> fix the following coccicheck warning:
>
> arch/x86/kvm/emulate.c:1315:5-7: Unneeded variable: "rc".Return
> "X86EMUL_CONTINUE".
> arch/x86/kvm/emulate.c:4559:5-7: Unneeded variable: "rc".Return
> "X86EMUL_CONTINUE".
> arch/x86/kvm/emulate.c:1180:5-7: Unneeded variable: "rc".Return
> "X86EMUL_CONTINUE".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
> arch/x86/kvm/emulate.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 936a397a08cd..7a7e29e4e203 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -1177,7 +1177,6 @@ static int decode_modrm(struct x86_emulate_ctxt *ctxt,
> {
> u8 sib;
> int index_reg, base_reg, scale;
> - int rc = X86EMUL_CONTINUE;
> ulong modrm_ea = 0;
>
> ctxt->modrm_reg = ((ctxt->rex_prefix << 1) & 8); /* REX.R */
> @@ -1199,16 +1198,16 @@ static int decode_modrm(struct x86_emulate_ctxt
> *ctxt,
Please resend, unless mine eyes deceive, this is whitespace damaged.
prev parent reply other threads:[~2023-06-14 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614032736.13264-1-luojianhong@cdjrlc.com>
2023-06-14 3:30 ` Fwd: [PATCH] KVM: x86: remove unneeded variable baomingtong001
2023-06-14 19:18 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIoSlrXifl/ikSBC@google.com \
--to=seanjc@google.com \
--cc=baomingtong001@208suo.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.