From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings
Date: Wed, 14 Jun 2023 19:18:22 -0600 [thread overview]
Message-ID: <ZIpm3pcs3iCP9UaR@work> (raw)
Address the following -Wstringop-overflow warnings seen when
built with ARM architecture and aspeed_g4_defconfig configuration
(notice that under this configuration CGROUP_SUBSYS_COUNT == 0):
kernel/cgroup/cgroup.c:1208:16: warning: 'find_existing_css_set' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
kernel/cgroup/cgroup.c:1258:15: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
kernel/cgroup/cgroup.c:6089:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
kernel/cgroup/cgroup.c:6153:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
These changes are based on commit d20d30ebb199 ("cgroup: Avoid compiler
warnings with no subsystems").
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
kernel/cgroup/cgroup.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index cd497b90e11a..1ee76e62eb98 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1200,6 +1200,9 @@ static struct css_set *find_css_set(struct css_set *old_cset,
unsigned long key;
int ssid;
+ if (!CGROUP_HAS_SUBSYS_CONFIG)
+ return NULL;
+
lockdep_assert_held(&cgroup_mutex);
/* First see if we already have a cgroup group that matches
@@ -6045,6 +6048,9 @@ int __init cgroup_init(void)
struct cgroup_subsys *ss;
int ssid;
+ if (!CGROUP_HAS_SUBSYS_CONFIG)
+ return -EINVAL;
+
BUILD_BUG_ON(CGROUP_SUBSYS_COUNT > 16);
BUG_ON(cgroup_init_cftypes(NULL, cgroup_base_files));
BUG_ON(cgroup_init_cftypes(NULL, cgroup_psi_files));
--
2.34.1
next reply other threads:[~2023-06-15 1:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 1:18 Gustavo A. R. Silva [this message]
2023-06-20 19:51 ` [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings Kees Cook
2023-06-20 19:51 ` Kees Cook
2023-06-21 20:42 ` Tejun Heo
2023-06-21 20:42 ` Tejun Heo
2023-06-22 10:11 ` Steven Price
2023-06-22 10:11 ` Steven Price
2023-06-22 14:09 ` Gustavo A. R. Silva
[not found] ` <0d6377ef-bc34-784a-8694-478d0ade085e-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
2023-06-22 18:50 ` Tejun Heo
2023-06-22 18:50 ` Tejun Heo
2023-06-22 10:20 ` Krzysztof Kozlowski
2023-06-22 14:09 ` Gustavo A. R. Silva
2023-06-22 14:09 ` Gustavo A. R. Silva
2023-08-15 19:04 ` Gustavo A. R. Silva
[not found] ` <e1c07dd0-e6bf-ca9c-107a-97c5043b1bc7-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
2023-08-16 19:22 ` Tejun Heo
2023-08-16 19:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIpm3pcs3iCP9UaR@work \
--to=gustavoars@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.