From: Oliver Upton <oliver.upton@linux.dev>
To: Shaoqin Huang <shahuang@redhat.com>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Salil Mehta <salil.mehta@huawei.com>
Subject: Re: [PATCH kvmtool 12/21] Add helpers to pause the VM from vCPU thread
Date: Thu, 15 Jun 2023 08:59:39 +0000 [thread overview]
Message-ID: <ZIrS+wRuzzp3BZ9L@linux.dev> (raw)
In-Reply-To: <10695b6a-65d5-2df3-e89e-8cc2cd75b8ac@redhat.com>
Hi Shaoqin,
On Fri, Jun 09, 2023 at 06:59:53PM +0800, Shaoqin Huang wrote:
> Hi Oliver,
>
> I have a play with this series, the guest always hang when hotplug two more
> cpus, it seems the kvm_cpu_continue_vm forget to continue the current cpu.
Thanks for testing the series out. Heh, a bit of a silly bug on my part,
sorry about that.
> > +void kvm_cpu__pause_vm(struct kvm_cpu *vcpu)
> > +{
> > + /*
> > + * Mark the calling vCPU as paused to avoid waiting indefinitely for a
> > + * signal exit.
> > + */
> > + vcpu->paused = true;
> > + kvm__pause(vcpu->kvm);
> > +}
> > +
> > +void kvm_cpu__continue_vm(struct kvm_cpu *vcpu)
> > +{
> Here should add:
> vcpu->paused = false;
> > + kvm__continue(vcpu->kvm);
> > +}
> > +
LGTM, I'll stick this in v2.
> > int kvm_cpu__start(struct kvm_cpu *cpu)
> > {
> > sigset_t sigset;
>
> --
> Shaoqin
>
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-06-15 8:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 22:16 [PATCH kvmtool 00/21] arm64: Handle PSCI calls in userspace Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 01/21] update_headers: Use a list for arch-generic headers Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 02/21] update_headers: Add missing entries to list of headers to copy Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 03/21] Copy 64-bit alignment attrtibutes from Linux 6.4-rc1 Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 04/21] Update headers with " Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 05/21] Import arm-smccc.h from " Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 06/21] aarch64: Copy cputype.h " Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 07/21] arm: Stash kvm_vcpu_init for later use Oliver Upton
2023-05-26 22:16 ` [PATCH kvmtool 08/21] arm: Add support for resetting a vCPU Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 09/21] arm: Use KVM_SET_MP_STATE ioctl to power off non-boot vCPUs Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 10/21] aarch64: Expose ARM64_CORE_REG() for general use Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 11/21] arm: Generalize execution state specific VM initialization Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 12/21] Add helpers to pause the VM from vCPU thread Oliver Upton
2023-06-09 10:59 ` Shaoqin Huang
2023-06-15 8:59 ` Oliver Upton [this message]
2023-05-26 22:17 ` [PATCH kvmtool 13/21] aarch64: Add support for finding vCPU for given MPIDR Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 14/21] aarch64: Add skeleton implementation for PSCI Oliver Upton
2023-06-13 15:10 ` Joey Gouly
2023-05-26 22:17 ` [PATCH kvmtool 15/21] aarch64: psci: Implement CPU_SUSPEND Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 16/21] aarch64: psci: Implement CPU_OFF Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 17/21] aarch64: psci: Implement CPU_ON Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 18/21] aarch64: psci: Implement AFFINITY_INFO Oliver Upton
2023-05-26 22:17 ` [PATCH kvmtool 19/21] aarch64: psci: Implement MIGRATE_INFO_TYPE Oliver Upton
2023-05-26 22:18 ` [PATCH kvmtool 20/21] aarch64: psci: Implement SYSTEM_{OFF,RESET} Oliver Upton
2023-05-26 22:19 ` [PATCH kvmtool 21/21] aarch64: smccc: Start sending PSCI to userspace Oliver Upton
2023-06-14 12:05 ` [PATCH kvmtool 00/21] arm64: Handle PSCI calls in userspace Joey Gouly
2023-06-14 16:05 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIrS+wRuzzp3BZ9L@linux.dev \
--to=oliver.upton@linux.dev \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shahuang@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.