From: Simon Horman <simon.horman@corigine.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
bjorn@kernel.org, magnus.karlsson@intel.com,
jonathan.lemon@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
maxtram95@gmail.com
Subject: Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
Date: Thu, 15 Jun 2023 16:40:08 +0200 [thread overview]
Message-ID: <ZIsiyKfr/WdzKlji@corigine.com> (raw)
In-Reply-To: <ZIsXdcawAWc/9Izo@boxer>
On Thu, Jun 15, 2023 at 03:51:49PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> > On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > > left behind this, remove it.
> > >
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >
> > Yeah this is a stub for !CONFIG_XDP_SOCKETS...
>
> Wait, I am not sure if this should go to bpf tree and have fixes tag
> pointing to the cited commit?
>
> Functionally this commit does not fix anything but it feels that
> f2f167583601 was incomplete.
FWIIW, I think that bpf-next is appropriate for this patch
as it doesn't address a bug.
next prev parent reply other threads:[~2023-06-15 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:46 [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard() YueHaibing
2023-06-15 13:49 ` Maciej Fijalkowski
2023-06-15 13:51 ` Maciej Fijalkowski
2023-06-15 14:40 ` Simon Horman [this message]
2023-06-16 1:34 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsiyKfr/WdzKlji@corigine.com \
--to=simon.horman@corigine.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.