From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 27/28] media: ov2680: Read and log sensor revision during probe
Date: Thu, 15 Jun 2023 17:43:43 +0300 [thread overview]
Message-ID: <ZIsjn8AqpDNWeIpA@smile.fi.intel.com> (raw)
In-Reply-To: <20230615141349.172363-28-hdegoede@redhat.com>
On Thu, Jun 15, 2023 at 04:13:48PM +0200, Hans de Goede wrote:
> Read and log sensor revision during probe.
>
> Since this means that the driver will now already log a message on
> successful probe drop the "ov2680 init correctly" log message.
...
> - ret = cci_read(sensor->regmap, OV2680_REG_CHIP_ID, &chip_id, NULL);
> + cci_read(sensor->regmap, OV2680_REG_CHIP_ID, &chip_id, &ret);
> + cci_read(sensor->regmap, OV2680_REG_SC_CMMN_SUB_ID, &rev, &ret);
> if (ret < 0) {
> dev_err(sensor->dev, "failed to read chip id\n");
> return -ENODEV;
Even in the original code I don't see justification why the error code should
be shadowed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-15 15:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 14:13 [PATCH v2 00/28] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Hans de Goede
2023-06-15 14:13 ` [PATCH v2 01/28] media: ov2680: Remove auto-gain and auto-exposure controls Hans de Goede
2023-06-15 14:13 ` [PATCH v2 02/28] media: ov2680: Fix ov2680_bayer_order() Hans de Goede
2023-06-15 14:13 ` [PATCH v2 03/28] media: ov2680: Fix vflip / hflip set functions Hans de Goede
2023-06-16 13:47 ` Dan Scally
2023-06-15 14:13 ` [PATCH v2 04/28] media: ov2680: Use select VIDEO_V4L2_SUBDEV_API Hans de Goede
2023-06-15 14:13 ` [PATCH v2 05/28] media: ov2680: Don't take the lock for try_fmt calls Hans de Goede
2023-06-15 14:13 ` [PATCH v2 06/28] media: ov2680: Add ov2680_fill_format() helper function Hans de Goede
2023-06-15 14:13 ` [PATCH v2 07/28] media: ov2680: Fix ov2680_set_fmt() which == V4L2_SUBDEV_FORMAT_TRY not working Hans de Goede
2023-06-15 14:13 ` [PATCH v2 08/28] media: ov2680: Fix regulators being left enabled on ov2680_power_on() errors Hans de Goede
2023-06-16 14:27 ` Dan Scally
2023-06-15 14:13 ` [PATCH v2 09/28] media: ov2680: Convert to new CCI register access helpers Hans de Goede
2023-06-15 14:13 ` [PATCH v2 10/28] media: ov2680: Store dev instead of i2c_client in ov2680_dev Hans de Goede
2023-06-15 14:13 ` [PATCH v2 11/28] media: ov2680: Check for "powerdown" GPIO con-id before checking for "reset" GPIO con-id Hans de Goede
2023-06-15 14:13 ` [PATCH v2 12/28] media: ov2680: Add runtime-pm support Hans de Goede
2023-06-15 14:13 ` [PATCH v2 13/28] media: ov2680: Drop is_enabled flag Hans de Goede
2023-06-15 14:13 ` [PATCH v2 14/28] media: ov2680: Add support for more clk setups Hans de Goede
2023-06-15 14:13 ` [PATCH v2 15/28] media: ov2680: Add support for 19.2 MHz clock Hans de Goede
2023-06-15 14:13 ` [PATCH v2 16/28] media: ov2680: Add endpoint matching support Hans de Goede
2023-06-15 14:13 ` [PATCH v2 17/28] media: ov2680: Add support for ACPI enumeration Hans de Goede
2023-06-15 14:41 ` Andy Shevchenko
2023-06-16 17:27 ` Hans de Goede
2023-06-15 14:13 ` [PATCH v2 18/28] media: ov2680: Fix ov2680_enum_frame_interval() Hans de Goede
2023-06-15 14:13 ` [PATCH v2 19/28] media: ov2680: Annotate the per mode register setting lists Hans de Goede
2023-06-15 14:13 ` [PATCH v2 20/28] media: ov2680: Add ov2680_mode struct Hans de Goede
2023-06-15 14:13 ` [PATCH v2 21/28] media: ov2680: Make setting the mode algorithm based Hans de Goede
2023-06-15 14:13 ` [PATCH v2 22/28] media: ov2680: Add an __ov2680_get_pad_format() helper function Hans de Goede
2023-06-15 14:13 ` [PATCH v2 23/28] media: ov2680: Implement selection support Hans de Goede
2023-06-15 14:13 ` [PATCH v2 24/28] media: ov2680: Fix exposure and gain ctrls range and default value Hans de Goede
2023-06-15 14:13 ` [PATCH v2 25/28] media: ov2680: Add a bunch of register tweaks Hans de Goede
2023-06-15 14:13 ` [PATCH v2 26/28] media: ov2680: Drop unnecessary pad checks Hans de Goede
2023-06-15 14:13 ` [PATCH v2 27/28] media: ov2680: Read and log sensor revision during probe Hans de Goede
2023-06-15 14:43 ` Andy Shevchenko [this message]
2023-06-16 17:30 ` Hans de Goede
2023-06-15 14:13 ` [PATCH v2 28/28] media: ov2680: Add link-freq and pixel-rate controls Hans de Goede
2023-06-15 17:32 ` [PATCH v2 00/28] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Rui Miguel Silva
2023-06-16 17:06 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsjn8AqpDNWeIpA@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.