From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56306EB64D7 for ; Fri, 16 Jun 2023 10:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yXertCCRK8wjPDDY0ARIR2ebSZQ840097drHr4YoeU0=; b=MOCfh2YxEWgOsM mWh6N8Z6LAFkNJ12lt1uka23jTH01UEcGoORUnqSP15sH+03bbexwv4nQ1JIw1JFOM9+jzrjgaAlV MMMUjXv8dgTGTfKRA23OZojVnNb0Fci7AVLQsNGWRPafCKQOVKKYP2IL+hafwQXwgdl9IumYfp3xv nQp83NVATaV+5k75QQFGWWxCdFlHxvClX8dWkBpvBQ0lZIP2ID2Z8v9zghWFIPQ3Pnp2Q3n1lXnGo DJz/DvV3j9nH7aCA48CyQ5LS6Aj7j8D4XZWZRVNJuJsNj4WA66rDiK+pi/du63jVBXSVcvm6Ormth THWUyKrNw17TRKnVLTEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA6N1-00HYum-38; Fri, 16 Jun 2023 10:07:55 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA6Mz-00HYtS-0G; Fri, 16 Jun 2023 10:07:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CN5z6yqj1tqEFliZI81j5Oh/vP4LbpjN18lNA0r+5gc=; b=xF0qVwuWG/LttaBQxfRVx6ay+y Bb+oeoLhhqgGdYrBQyPSWcSA/ED7hOWalkmJ4HZQCbTXITHUQFVd6+UptZ8bdZiJgoR5xMki/rUIn 4sBE/25wVZeBeFo9bTVxDA999+qjVteJwn0GpwfSk+KeFdFu7vpXoRGXDoemnhwHPghTpIXnFfkCc NYSTtMp9hPRMJ/d+rgSM0Z0oHSqvw4fnom+lgT5e4FUUUZij8yyKpETBY25BiZIJAqx4HjJwitIUo LV0sWfs6za3PR7q06xGXhYH3FQzED2kQIPM1iIt96KChtAGPsS36e71hFctU6kiDoS+vq+y6Gp0YA djCdVTXQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35780) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qA6Mf-0004k6-Ed; Fri, 16 Jun 2023 11:07:33 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qA6MW-0002PI-V2; Fri, 16 Jun 2023 11:07:25 +0100 Date: Fri, 16 Jun 2023 11:07:24 +0100 From: "Russell King (Oracle)" To: arinc9.unal@gmail.com Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v5 1/6] net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP Message-ID: References: <20230616025327.12652-1-arinc.unal@arinc9.com> <20230616025327.12652-2-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230616025327.12652-2-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_030753_115872_4EF91165 X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMDU6NTM6MjJBTSArMDMwMCwgYXJpbmM5LnVuYWxAZ21h aWwuY29tIHdyb3RlOgo+IEZyb206IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNv bT4KPiAKPiBNVDc1MzFfQ1BVX1BNQVAgcmVwcmVzZW50cyB0aGUgZGVzdGluYXRpb24gcG9ydCBt YXNrIGZvciB0cmFwcGVkLXRvLUNQVQo+IGZyYW1lcyAoZnVydGhlciByZXN0cmljdGVkIGJ5IFBD Ul9NQVRSSVgpLgo+IAo+IEN1cnJlbnRseSB0aGUgZHJpdmVyIHNldHMgdGhlIGZpcnN0IENQVSBw b3J0IGFzIHRoZSBzaW5nbGUgcG9ydCBpbiB0aGlzIGJpdAo+IG1hc2ssIHdoaWNoIHdvcmtzIGZp bmUgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIHRoZSBkZXZpY2UgdHJlZSBkZWZpbmVzIHBvcnQKPiA1 LCA2IG9yIDUrNiBhcyBDUFUgcG9ydHMuIFRoaXMgaXMgYmVjYXVzZSB0aGUgbG9naWMgY29pbmNp ZGVzIHdpdGggRFNBJ3MKPiBsb2dpYyBvZiBwaWNraW5nIHRoZSBmaXJzdCBDUFUgcG9ydCBhcyB0 aGUgQ1BVIHBvcnQgdGhhdCBhbGwgdXNlciBwb3J0cyBhcmUKPiBhZmZpbmUgdG8sIGJ5IGRlZmF1 bHQuCj4gCj4gQW4gdXBjb21pbmcgY2hhbmdlIHdvdWxkIGxpa2UgdG8gaW5mbHVlbmNlIERTQSdz IHNlbGVjdGlvbiBvZiB0aGUgZGVmYXVsdAo+IENQVSBwb3J0IHRvIG5vIGxvbmdlciBiZSB0aGUg Zmlyc3Qgb25lLCBhbmQgaW4gdGhhdCBjYXNlLCB0aGlzIGxvZ2ljIG5lZWRzCj4gYWRhcHRhdGlv bi4KPiAKPiBTaW5jZSB0aGVyZSBpcyBubyBvYnNlcnZlZCBsZWFrYWdlIG9yIGR1cGxpY2F0aW9u IG9mIGZyYW1lcyBpZiBhbGwgQ1BVCj4gcG9ydHMgYXJlIGRlZmluZWQgaW4gdGhpcyBiaXQgbWFz aywgc2ltcGx5IGluY2x1ZGUgdGhlbSBhbGwuCgpOaWNlIGFuZCBjbGVhciBjb21taXQgbWVzc2Fn ZSwgdGhhbmtzLgoKPiArCS8qIEFkZCB0aGUgQ1BVIHBvcnQgdG8gdGhlIENQVSBwb3J0IGJpdG1h cCBmb3IgTVQ3NTMxIGFuZCB0aGUgc3dpdGNoIG9uCj4gKwkgKiB0aGUgTVQ3OTg4IFNvQy4gVHJh cHBlZCBmcmFtZXMgd2lsbCBiZSB0cmFwcGVkIHRvIHRoZSBDUFUgcG9ydCB0aGF0Cj4gKwkgKiBp cyBhZmZpbmUgdG8gdGhlIGluYm91bmQgdXNlciBwb3J0LgoKQXMgYSBnZW5lcmFsIHJ1bGUsIEVu Z2xpc2ggZG9lc24ndCBsaWtlIHJlcGV0aXRpb24gaW4gc2VudGVuY2VzLCB3aGljaAptZWFucyB0 aGF0IGhhdmluZyAidHJhcHBlZCIgdHdpY2UgKG9yIG1vcmUgdGltZXMpIG1ha2VzIHRoZSBzZW50 ZW5jZQphd2t3YXJkLgoKIlRyYXBwZWQgZnJhbWVzIHdpbGwgYmUgZm9yd2FyZGVkIHRvIHRoZSBD UFUgcG9ydCB0aGF0IGlzIGFmZmluZSB0byB0aGUKaW5ib3VuZCB1c2VyIHBvcnQuIgoKcmVhZHMg bXVjaCBiZXR0ZXIuCgpBcGFydCBmcm9tIHRoYXQuLi4KClJldmlld2VkLWJ5OiBSdXNzZWxsIEtp bmcgKE9yYWNsZSkgPHJtaytrZXJuZWxAYXJtbGludXgub3JnLnVrPgoKVGhhbmtzIQoKLS0gClJN SydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9w YXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5l Y3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380F2EB64D8 for ; Fri, 16 Jun 2023 10:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245570AbjFPKJX (ORCPT ); Fri, 16 Jun 2023 06:09:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244894AbjFPKIu (ORCPT ); Fri, 16 Jun 2023 06:08:50 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D92835A3; Fri, 16 Jun 2023 03:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CN5z6yqj1tqEFliZI81j5Oh/vP4LbpjN18lNA0r+5gc=; b=xF0qVwuWG/LttaBQxfRVx6ay+y Bb+oeoLhhqgGdYrBQyPSWcSA/ED7hOWalkmJ4HZQCbTXITHUQFVd6+UptZ8bdZiJgoR5xMki/rUIn 4sBE/25wVZeBeFo9bTVxDA999+qjVteJwn0GpwfSk+KeFdFu7vpXoRGXDoemnhwHPghTpIXnFfkCc NYSTtMp9hPRMJ/d+rgSM0Z0oHSqvw4fnom+lgT5e4FUUUZij8yyKpETBY25BiZIJAqx4HjJwitIUo LV0sWfs6za3PR7q06xGXhYH3FQzED2kQIPM1iIt96KChtAGPsS36e71hFctU6kiDoS+vq+y6Gp0YA djCdVTXQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35780) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qA6Mf-0004k6-Ed; Fri, 16 Jun 2023 11:07:33 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qA6MW-0002PI-V2; Fri, 16 Jun 2023 11:07:25 +0100 Date: Fri, 16 Jun 2023 11:07:24 +0100 From: "Russell King (Oracle)" To: arinc9.unal@gmail.com Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v5 1/6] net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP Message-ID: References: <20230616025327.12652-1-arinc.unal@arinc9.com> <20230616025327.12652-2-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230616025327.12652-2-arinc.unal@arinc9.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 05:53:22AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > MT7531_CPU_PMAP represents the destination port mask for trapped-to-CPU > frames (further restricted by PCR_MATRIX). > > Currently the driver sets the first CPU port as the single port in this bit > mask, which works fine regardless of whether the device tree defines port > 5, 6 or 5+6 as CPU ports. This is because the logic coincides with DSA's > logic of picking the first CPU port as the CPU port that all user ports are > affine to, by default. > > An upcoming change would like to influence DSA's selection of the default > CPU port to no longer be the first one, and in that case, this logic needs > adaptation. > > Since there is no observed leakage or duplication of frames if all CPU > ports are defined in this bit mask, simply include them all. Nice and clear commit message, thanks. > + /* Add the CPU port to the CPU port bitmap for MT7531 and the switch on > + * the MT7988 SoC. Trapped frames will be trapped to the CPU port that > + * is affine to the inbound user port. As a general rule, English doesn't like repetition in sentences, which means that having "trapped" twice (or more times) makes the sentence awkward. "Trapped frames will be forwarded to the CPU port that is affine to the inbound user port." reads much better. Apart from that... Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!