From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DCDCEB64D7 for ; Fri, 16 Jun 2023 10:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fg1W1twqWD7+/cbMensLKadpmnDk3lSC2VfdyQxLVmw=; b=2ECOHoiqCXAlQO o0MEDApb5aa/7W9/H9i+6+BB2uZSVNx1JIplbO5nNNb2HpfqZW1cIeq4wpEbnTFSVJaqN6RsS1MCR KA/n1RoSceBP9/QJVdplwrvQ3ouhGk7MqpfWmTL8JCQUCekzUw9cSLmbUVs2v681u16HGkFvJ04Dx 0Jw+SEzC9cQ8Dzg5ZUCM2QJJ82AfdFh3UVW69o4sIuCVftNSlG3nuWwUve73+8PfhAph438xRHvIb V3t2zIy4qTd4jwaRsdgMJEAQw7L2BjqSaDQHrfWICDNRJJDoZibNqR35Tsb3SS0VUknbmB+kBRHlA McGGEnfe0q9T9OscSsoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA6X3-00HaXd-0d; Fri, 16 Jun 2023 10:18:17 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA6X0-00HaWJ-1I; Fri, 16 Jun 2023 10:18:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ldYgwDt7voxDOksHBbsKUYFGw63dx52D9aj9AQa3YSg=; b=0+liBd742WkgK8Mdlp4lP6ky1Z mwbmgUC+sDSAA7CM8Q8EOPIq7cF39x1/cbeQ73mLiZDnQIpbgu3Z2r1CL4tQnZFIcwWO03mecTh5A JfAl5V3Is1NfjAMg8g0SkaR0cFzU4FlpVpuAqA+t4fMJX3XQhWm/Wsl/1LIe4Hp/b0ZKP/8rV3A0X Ma2Kfi1bcRhi5e72QP1sBwwuHs4QVoKP+lMacig1m+3pups2ggSs7WlYcWMgusypgbOgL9aCzwy6/ C3SjPly7/QQokDFuVgR8vx0224Jswndt21p0I+loXubSlc1MD/jbfRMcBFdEjL3BV/A41g6y6pPIA wqkcWFJg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33540) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qA6Wk-0004lz-BV; Fri, 16 Jun 2023 11:17:58 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qA6Wg-0002QQ-6G; Fri, 16 Jun 2023 11:17:54 +0100 Date: Fri, 16 Jun 2023 11:17:54 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: arinc9.unal@gmail.com, =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v5 2/6] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Message-ID: References: <20230616025327.12652-1-arinc.unal@arinc9.com> <20230616025327.12652-3-arinc.unal@arinc9.com> <20230616100314.x2qak6t7uxo2qnja@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230616100314.x2qak6t7uxo2qnja@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_031814_436607_1379BD70 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMDE6MDM6MTRQTSArMDMwMCwgVmxhZGltaXIgT2x0ZWFu IHdyb3RlOgo+IE9uIEZyaSwgSnVuIDE2LCAyMDIzIGF0IDA1OjUzOjIzQU0gKzAzMDAsIGFyaW5j OS51bmFsQGdtYWlsLmNvbSB3cm90ZToKPiA+IEZyb206IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVu YWxAYXJpbmM5LmNvbT4KPiA+IAo+ID4gVGhlIGNoZWNrIGZvciBzZXR0aW5nIHRoZSBDUFVfUE9S VCBiaXRzIG11c3QgaW5jbHVkZSB0aGUgbm9uLU1UNzYyMSBTb0MKPiA+IE1UNzUzMCBzd2l0Y2gg dmFyaWFudHMgdG8gdHJhcCBmcmFtZXMuIEV4cGFuZCB0aGUgY2hlY2sgdG8gaW5jbHVkZSB0aGVt Lgo+ID4gCj4gPiBGaXhlczogYjhmMTI2YThkNTQzICgibmV0LW5leHQ6IGRzYTogYWRkIGRzYSBz dXBwb3J0IGZvciBNZWRpYXRlayBNVDc1MzAgc3dpdGNoIikKPiA+IFNpZ25lZC1vZmYtYnk6IEFy xLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNvbT4KPiA+IC0tLQo+IAo+IHdoeSBkbyB5 b3Ugc2F5IG5vbi1NVDc2MjEgd2hlbiB0aGUgY2hhbmdlIHNwZWNpZmljYWxseSBpbmNsdWRlcyBN VDc2MjE/Cj4gV2hhdCBpcyB0aGUgYWZmZWN0ZWQgU29DIHRoZW4/CgpUaGFua3MgZm9yIGZhbGxp bmcgaW50byBvbmUgb2YgdGhlIGlzc3VlcyB0aGF0IG1ha2VzIHJldmlld2luZyB0aGVzZQpwYXRj aGVzIGRpZmZpY3VsdC4gOi8KCj4gPiAtCWlmIChwcml2LT5pZCA9PSBJRF9NVDc2MjEpCj4gPiAr CWlmIChwcml2LT5pZCA9PSBJRF9NVDc1MzAgfHwgcHJpdi0+aWQgPT0gSURfTVQ3NjIxKQo+ID4g IAkJbXQ3NTMwX3Jtdyhwcml2LCBNVDc1MzBfTUZDLCBDUFVfTUFTSywgQ1BVX0VOIHwgQ1BVX1BP UlQocG9ydCkpOwoKSSAqdGhpbmsqIHdoYXQgdGhlIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBiZSBz YXlpbmcgaXMgdGhhdCB0aGUgc2V0dXAKZm9yIHRoZSBDUFUgcG9ydCgqKSBpcyBuZWNlc3Nhcnkg bm90IG9ubHkgZm9yIE1UNzYyMSwgYnV0IGFsc28gZm9yCk1UNzUzMCB2YXJpYW50cyBhcyB3ZWxs LgoKVGhhdCBjYW4gYmUgY29uc3RydWVkIGZyb20gdGhlIGNvbW1pdCBtZXNzYWdlLCBidXQgaXQg ZG9lc24ndCBlYXNpbHkKcmVhZCB0aGF0IHdheS4KCiogLSBpbiB0aGlzIGNhc2UsIGl0J3MgdGhl IENQVSBwb3J0IGZpZWxkIGFuZCB0aGUgQ1BVIGVuYWJsZSBiaXQuCk5vdGUgdGhhdCBDUFVfTUFT SyBvbmx5IGNvdmVycyBDUFVfUE9SVCgpIGFuZCBub3QgQ1BVX0VOLCBidXQgdGhpcwpkb2Vzbid0 IG1hdHRlciBmb3IgbXQ3NTMwX3JtdygpLgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6 Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgw TWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDBCEB64D8 for ; Fri, 16 Jun 2023 10:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343906AbjFPKSl (ORCPT ); Fri, 16 Jun 2023 06:18:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343595AbjFPKSQ (ORCPT ); Fri, 16 Jun 2023 06:18:16 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A8B3A9E; Fri, 16 Jun 2023 03:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ldYgwDt7voxDOksHBbsKUYFGw63dx52D9aj9AQa3YSg=; b=0+liBd742WkgK8Mdlp4lP6ky1Z mwbmgUC+sDSAA7CM8Q8EOPIq7cF39x1/cbeQ73mLiZDnQIpbgu3Z2r1CL4tQnZFIcwWO03mecTh5A JfAl5V3Is1NfjAMg8g0SkaR0cFzU4FlpVpuAqA+t4fMJX3XQhWm/Wsl/1LIe4Hp/b0ZKP/8rV3A0X Ma2Kfi1bcRhi5e72QP1sBwwuHs4QVoKP+lMacig1m+3pups2ggSs7WlYcWMgusypgbOgL9aCzwy6/ C3SjPly7/QQokDFuVgR8vx0224Jswndt21p0I+loXubSlc1MD/jbfRMcBFdEjL3BV/A41g6y6pPIA wqkcWFJg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33540) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qA6Wk-0004lz-BV; Fri, 16 Jun 2023 11:17:58 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qA6Wg-0002QQ-6G; Fri, 16 Jun 2023 11:17:54 +0100 Date: Fri, 16 Jun 2023 11:17:54 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: arinc9.unal@gmail.com, =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v5 2/6] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Message-ID: References: <20230616025327.12652-1-arinc.unal@arinc9.com> <20230616025327.12652-3-arinc.unal@arinc9.com> <20230616100314.x2qak6t7uxo2qnja@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230616100314.x2qak6t7uxo2qnja@skbuf> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 01:03:14PM +0300, Vladimir Oltean wrote: > On Fri, Jun 16, 2023 at 05:53:23AM +0300, arinc9.unal@gmail.com wrote: > > From: Arınç ÜNAL > > > > The check for setting the CPU_PORT bits must include the non-MT7621 SoC > > MT7530 switch variants to trap frames. Expand the check to include them. > > > > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") > > Signed-off-by: Arınç ÜNAL > > --- > > why do you say non-MT7621 when the change specifically includes MT7621? > What is the affected SoC then? Thanks for falling into one of the issues that makes reviewing these patches difficult. :/ > > - if (priv->id == ID_MT7621) > > + if (priv->id == ID_MT7530 || priv->id == ID_MT7621) > > mt7530_rmw(priv, MT7530_MFC, CPU_MASK, CPU_EN | CPU_PORT(port)); I *think* what the commit message should be saying is that the setup for the CPU port(*) is necessary not only for MT7621, but also for MT7530 variants as well. That can be construed from the commit message, but it doesn't easily read that way. * - in this case, it's the CPU port field and the CPU enable bit. Note that CPU_MASK only covers CPU_PORT() and not CPU_EN, but this doesn't matter for mt7530_rmw(). -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!